Re: [patch] getnameinfo.3: Fix _POSIX_C_SOURCE value for getaddrinfo()

[Sebastian Kirmayer <man-pages@kirmayer.eu>]

Hi Michael,

On Sun, Nov 22, 2020 at 11:57:51PM +0100, Michael Kerrisk (man-pages) wrote:
> Hi Sebastian,
> 
> On Sun, 22 Nov 2020 at 23:53, Sebastian Kirmayer <sebastian@kirmayer.de> wrote:
> >
> > Hi Michael,
> >
> > On Sun, Nov 22, 2020 at 11:42:02PM +0100, Michael Kerrisk (man-pages) wrote:
> > > Hi Sebastian,
> > >
> > > On 11/22/20 11:37 PM, Sebastian Kirmayer wrote:
> > > > The minimum value of _POSIX_C_SOURCE for getnameinfo() was mistyped as 201112L
> > > > (not a real POSIX version), it should be 200112L. This is the same typo that
> > > > was fixed for getaddrinfo.3 in commit 94db8ae1824ada8561c3dbbbed88a8a9175c4886
> > > >
> > > > According to the current documentation, this file should not compile, but
> > > > it does:
> > > >
> > > >     #define _POSIX_C_SOURCE 200112L
> > > >     #include <netdb.h>
> > > >     int (*mygetnameinfo)() = getnameinfo;
> > > >
> > > > (If _POSIX_C_SOURCE is changed to 200111L, the program does no longer compile.)
> > > >
> > > > man3/getnameinfo.3:
> > > >
> > > > @@ -27,7 +27,7 @@ Feature Test Macro Requirements for glibc (see
> > > >  .RE
> > > >  .PP
> > > >  .BR getnameinfo ():
> > > > -    Since glibc 2.22: _POSIX_C_SOURCE >= 201112L
> > > > +    Since glibc 2.22: _POSIX_C_SOURCE >= 200112L
> > > >      Glibc 2.21 and earlier: _POSIX_C_SOURCE
> > > >  .ad b
> > > >  .SH DESCRIPTION
> > >
> > > Thanks for taking the time to report, but I think you must be looking
> > > at a rather old version of the manual pages. It looks like that typo
> > > was fixed about three years ago in the Git tree!
> > >
> > > Thanks,
> > >
> > > Michael
> >
> > Oops, I accidently wrote getaddrinfo() in the subject. I meant to write
> > getnameinfo(), and I'm actually referencing the commit from three years
> > ago fixing it for getaddrinfo().
> 
> Ahh -- sorry, I should have looked more closely at your mail then.
> Fixed now. Thanks for the report!
> 
> Cheers,
> 
> Michael

I just saw your commit, and it seems that you made another typo while fixing
the previous typo: It should be 200112L, not 20112L.

Sebastian