From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15328C5519F for ; Sun, 22 Nov 2020 23:06:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CEFCE20773 for ; Sun, 22 Nov 2020 23:06:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726020AbgKVXGA (ORCPT ); Sun, 22 Nov 2020 18:06:00 -0500 Received: from buexe.b-5.de ([185.37.144.146]:52348 "EHLO buexe.b-5.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725788AbgKVXGA (ORCPT ); Sun, 22 Nov 2020 18:06:00 -0500 Received: from kirmayer.de (aftr-62-216-203-174.dynamic.mnet-online.de [62.216.203.174]) (authenticated bits=128) by buexe.b-5.de (8.15.2/8.15.2/b-5/buexe-3.6.3) with ESMTPSA id 0AMN5tXg017119 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 23 Nov 2020 00:05:57 +0100 Date: Mon, 23 Nov 2020 00:05:50 +0100 From: Sebastian Kirmayer To: "Michael Kerrisk (man-pages)" Cc: Sebastian Kirmayer , linux-man Subject: Re: [patch] getnameinfo.3: Fix _POSIX_C_SOURCE value for getaddrinfo() Message-ID: <20201122230550.GA8553@kirmayer.de> References: <20201122223707.GA7261@kirmayer.de> <921887e2-61ad-6212-c91b-beab3e4a7ab8@gmail.com> <20201122225339.GA8330@kirmayer.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-man@vger.kernel.org Hi Michael, On Sun, Nov 22, 2020 at 11:57:51PM +0100, Michael Kerrisk (man-pages) wrote: > Hi Sebastian, > > On Sun, 22 Nov 2020 at 23:53, Sebastian Kirmayer wrote: > > > > Hi Michael, > > > > On Sun, Nov 22, 2020 at 11:42:02PM +0100, Michael Kerrisk (man-pages) wrote: > > > Hi Sebastian, > > > > > > On 11/22/20 11:37 PM, Sebastian Kirmayer wrote: > > > > The minimum value of _POSIX_C_SOURCE for getnameinfo() was mistyped as 201112L > > > > (not a real POSIX version), it should be 200112L. This is the same typo that > > > > was fixed for getaddrinfo.3 in commit 94db8ae1824ada8561c3dbbbed88a8a9175c4886 > > > > > > > > According to the current documentation, this file should not compile, but > > > > it does: > > > > > > > > #define _POSIX_C_SOURCE 200112L > > > > #include > > > > int (*mygetnameinfo)() = getnameinfo; > > > > > > > > (If _POSIX_C_SOURCE is changed to 200111L, the program does no longer compile.) > > > > > > > > man3/getnameinfo.3: > > > > > > > > @@ -27,7 +27,7 @@ Feature Test Macro Requirements for glibc (see > > > > .RE > > > > .PP > > > > .BR getnameinfo (): > > > > - Since glibc 2.22: _POSIX_C_SOURCE >= 201112L > > > > + Since glibc 2.22: _POSIX_C_SOURCE >= 200112L > > > > Glibc 2.21 and earlier: _POSIX_C_SOURCE > > > > .ad b > > > > .SH DESCRIPTION > > > > > > Thanks for taking the time to report, but I think you must be looking > > > at a rather old version of the manual pages. It looks like that typo > > > was fixed about three years ago in the Git tree! > > > > > > Thanks, > > > > > > Michael > > > > Oops, I accidently wrote getaddrinfo() in the subject. I meant to write > > getnameinfo(), and I'm actually referencing the commit from three years > > ago fixing it for getaddrinfo(). > > Ahh -- sorry, I should have looked more closely at your mail then. > Fixed now. Thanks for the report! > > Cheers, > > Michael I just saw your commit, and it seems that you made another typo while fixing the previous typo: It should be 200112L, not 20112L. Sebastian