* [PATCH] process_madvise.2: SYNOPSIS: Fix prototype parameter type
@ 2021-02-11 17:44 Alejandro Colomar
2021-02-13 15:46 ` Michael Kerrisk (man-pages)
0 siblings, 1 reply; 2+ messages in thread
From: Alejandro Colomar @ 2021-02-11 17:44 UTC (permalink / raw)
To: mtk.manpages; +Cc: Alejandro Colomar, linux-man
The type of vlen is 'size_t', and not 'unsigned int'. Fix it.
......
$ grep_syscall process_madvise
mm/madvise.c:1161:
SYSCALL_DEFINE5(process_madvise, int, pidfd, const struct iovec __user *, vec,
size_t, vlen, int, behavior, unsigned int, flags)
include/linux/syscalls.h:887:
asmlinkage long sys_process_madvise(int pidfd, const struct iovec __user *vec,
size_t vlen, int behavior, unsigned int flags);
function grep_syscall()
{
if ! [ -v 1 ]; then
>&2 echo "Usage: ${FUNCNAME[0]} <syscall>";
return ${EX_USAGE};
fi
find * -type f \
|grep '\.c$' \
|sort -V \
|xargs pcregrep -Mn "(?s)^\w*SYSCALL_DEFINE.\(${1},.*?\)" \
|sed -E 's/^[^:]+:[0-9]+:/&\n/';
find * -type f \
|grep '\.[ch]$' \
|sort -V \
|xargs pcregrep -Mn "(?s)^asmlinkage\s+[\w\s]+\**sys_${1}\s*\(.*?\)" \
|sed -E 's/^[^:]+:[0-9]+:/&\n/';
}
Signed-off-by: Alejandro Colomar <alx.manpages@gmail.com>
---
man2/process_madvise.2 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/man2/process_madvise.2 b/man2/process_madvise.2
index 9dc90ced1..b00ceb6fc 100644
--- a/man2/process_madvise.2
+++ b/man2/process_madvise.2
@@ -33,7 +33,7 @@ process_madvise \- give advice about use of memory to a process
.B #include <sys/uio.h>
.PP
.BI "ssize_t process_madvise(int " pidfd ", const struct iovec *" iovec ,
-.BI " unsigned long " vlen ", int " advice ,
+.BI " size_t " vlen ", int " advice ,
.BI " unsigned int " flags ");"
.fi
.PP
--
2.30.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] process_madvise.2: SYNOPSIS: Fix prototype parameter type
2021-02-11 17:44 [PATCH] process_madvise.2: SYNOPSIS: Fix prototype parameter type Alejandro Colomar
@ 2021-02-13 15:46 ` Michael Kerrisk (man-pages)
0 siblings, 0 replies; 2+ messages in thread
From: Michael Kerrisk (man-pages) @ 2021-02-13 15:46 UTC (permalink / raw)
To: Alejandro Colomar; +Cc: mtk.manpages, linux-man
Hi Alex,
On 2/11/21 6:44 PM, Alejandro Colomar wrote:
> The type of vlen is 'size_t', and not 'unsigned int'. Fix it.
>
> ......
>
> $ grep_syscall process_madvise
> mm/madvise.c:1161:
> SYSCALL_DEFINE5(process_madvise, int, pidfd, const struct iovec __user *, vec,
> size_t, vlen, int, behavior, unsigned int, flags)
> include/linux/syscalls.h:887:
> asmlinkage long sys_process_madvise(int pidfd, const struct iovec __user *vec,
> size_t vlen, int behavior, unsigned int flags);
>
> function grep_syscall()
> {
> if ! [ -v 1 ]; then
> >&2 echo "Usage: ${FUNCNAME[0]} <syscall>";
> return ${EX_USAGE};
> fi
>
> find * -type f \
> |grep '\.c$' \
> |sort -V \
> |xargs pcregrep -Mn "(?s)^\w*SYSCALL_DEFINE.\(${1},.*?\)" \
> |sed -E 's/^[^:]+:[0-9]+:/&\n/';
>
> find * -type f \
> |grep '\.[ch]$' \
> |sort -V \
> |xargs pcregrep -Mn "(?s)^asmlinkage\s+[\w\s]+\**sys_${1}\s*\(.*?\)" \
> |sed -E 's/^[^:]+:[0-9]+:/&\n/';
> }
>
> Signed-off-by: Alejandro Colomar <alx.manpages@gmail.com>
Thanks. Patch applied.
Cheers,
Michael
> ---
> man2/process_madvise.2 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/man2/process_madvise.2 b/man2/process_madvise.2
> index 9dc90ced1..b00ceb6fc 100644
> --- a/man2/process_madvise.2
> +++ b/man2/process_madvise.2
> @@ -33,7 +33,7 @@ process_madvise \- give advice about use of memory to a process
> .B #include <sys/uio.h>
> .PP
> .BI "ssize_t process_madvise(int " pidfd ", const struct iovec *" iovec ,
> -.BI " unsigned long " vlen ", int " advice ,
> +.BI " size_t " vlen ", int " advice ,
> .BI " unsigned int " flags ");"
> .fi
> .PP
>
--
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-02-13 15:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-02-11 17:44 [PATCH] process_madvise.2: SYNOPSIS: Fix prototype parameter type Alejandro Colomar
2021-02-13 15:46 ` Michael Kerrisk (man-pages)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox