public inbox for linux-man@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] tkill.2: SYNOPSIS: Fix prototype parameter types
@ 2021-02-15 13:15 Alejandro Colomar
  2021-02-15 20:01 ` Michael Kerrisk (man-pages)
  0 siblings, 1 reply; 2+ messages in thread
From: Alejandro Colomar @ 2021-02-15 13:15 UTC (permalink / raw)
  To: mtk.manpages; +Cc: Alejandro Colomar, linux-man

All but the last parameters of t[g]kill() use 'pid_t',
both in the kernel and glibc.  Fix them.

......

.../linux/linux$ grep_syscall tkill
kernel/signal.c:3870:
SYSCALL_DEFINE2(tkill, pid_t, pid, int, sig)
include/linux/syscalls.h:685:
asmlinkage long sys_tkill(pid_t pid, int sig);
.../linux/linux$

.../gnu/glibc$ grep_glibc_prototype tgkill
sysdeps/unix/sysv/linux/bits/signal_ext.h:29:
extern int tgkill (__pid_t __tgid, __pid_t __tid, int __signal);
.../gnu/glibc$

Signed-off-by: Alejandro Colomar <alx.manpages@gmail.com>
---
 man2/tkill.2 | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/man2/tkill.2 b/man2/tkill.2
index 4b4eae312..24636719d 100644
--- a/man2/tkill.2
+++ b/man2/tkill.2
@@ -31,8 +31,8 @@
 tkill, tgkill \- send a signal to a thread
 .SH SYNOPSIS
 .nf
-.BI "int tkill(int " tid ", int " sig );
-.BI "int tgkill(int " tgid ", int " tid ", int " sig );
+.BI "int tkill(pid_t " tid ", int " sig );
+.BI "int tgkill(pid_t " tgid ", pid_t " tid ", int " sig );
 .fi
 .PP
 .IR Note :
-- 
2.30.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] tkill.2: SYNOPSIS: Fix prototype parameter types
  2021-02-15 13:15 [PATCH] tkill.2: SYNOPSIS: Fix prototype parameter types Alejandro Colomar
@ 2021-02-15 20:01 ` Michael Kerrisk (man-pages)
  0 siblings, 0 replies; 2+ messages in thread
From: Michael Kerrisk (man-pages) @ 2021-02-15 20:01 UTC (permalink / raw)
  To: Alejandro Colomar; +Cc: mtk.manpages, linux-man

Hi Alex,

On 2/15/21 2:15 PM, Alejandro Colomar wrote:
> All but the last parameters of t[g]kill() use 'pid_t',
> both in the kernel and glibc.  Fix them.
> 
> ......
> 
> .../linux/linux$ grep_syscall tkill
> kernel/signal.c:3870:
> SYSCALL_DEFINE2(tkill, pid_t, pid, int, sig)
> include/linux/syscalls.h:685:
> asmlinkage long sys_tkill(pid_t pid, int sig);
> .../linux/linux$
> 
> .../gnu/glibc$ grep_glibc_prototype tgkill
> sysdeps/unix/sysv/linux/bits/signal_ext.h:29:
> extern int tgkill (__pid_t __tgid, __pid_t __tid, int __signal);
> .../gnu/glibc$
> 
> Signed-off-by: Alejandro Colomar <alx.manpages@gmail.com>


Thanks! Patch applied.

Cheers,

Michael


> ---
>  man2/tkill.2 | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/man2/tkill.2 b/man2/tkill.2
> index 4b4eae312..24636719d 100644
> --- a/man2/tkill.2
> +++ b/man2/tkill.2
> @@ -31,8 +31,8 @@
>  tkill, tgkill \- send a signal to a thread
>  .SH SYNOPSIS
>  .nf
> -.BI "int tkill(int " tid ", int " sig );
> -.BI "int tgkill(int " tgid ", int " tid ", int " sig );
> +.BI "int tkill(pid_t " tid ", int " sig );
> +.BI "int tgkill(pid_t " tgid ", pid_t " tid ", int " sig );
>  .fi
>  .PP
>  .IR Note :
> 


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-02-15 20:01 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-02-15 13:15 [PATCH] tkill.2: SYNOPSIS: Fix prototype parameter types Alejandro Colomar
2021-02-15 20:01 ` Michael Kerrisk (man-pages)

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox