Re: [PATCH 1/4] userfaultfd.2: Add UFFD_FEATURE_THREAD_ID docs

Peter Xu
2021-03-04T15:56:19Z

On Thu, Mar 04, 2021 at 08:38:09AM +0200, Mike Rapoport wrote:
> On Wed, Mar 03, 2021 at 08:59:44PM -0500, Peter Xu wrote:
> > UFFD_FEATURE_THREAD_ID is supported since Linux 4.14.
> >
> > Signed-off-by: Peter Xu <peterx@redhat.com>
> > ---
> > man2/userfaultfd.2 | 12 ++++++++++++
> > 1 file changed, 12 insertions(+)
> >
> > diff --git a/man2/userfaultfd.2 b/man2/userfaultfd.2
> > index e7dc9f813..2d14effc6 100644
> > --- a/man2/userfaultfd.2
> > +++ b/man2/userfaultfd.2
> > @@ -77,6 +77,12 @@ When the last file descriptor referring to a userfaultfd object is closed,
> > all memory ranges that were registered with the object are unregistered
> > and unread events are flushed.
> > .\"
> > +.PP
> > +Since Linux 4.14, userfaultfd page fault message can selectively embed fault
>
> Maybe faulting? ^

Ok.

>
> > +thread ID information into the fault message. One needs to enable this feature
> > +explicitly using the
> > +.BR UFFD_FEATURE_THREAD_ID
> > +feature bit when initializing the userfaultfd context, otherwise disabled.
>
> "... otherwise thread ID reporting is disabled" ^

I changed to "... By default, thread ID reporting is diabled."

Thanks!

--
Peter Xu