Re: [PATCH v3] fanotify.7, fanotify_mark.2: Document FAN_FS_ERROR

[Jan Kara <jack@suse.cz>]

On Mon 01-11-21 17:04:45, Gabriel Krisman Bertazi wrote:
> FAN_FS_ERROR is a new event for fanotify to report filesystem errors.
> 
> Cc: Amir Goldstein <amir73il@gmail.com>
> Cc: Jan Kara <jack@suse.cz>
> Cc: Matthew Bobrowski <repnop@google.com>
> Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.com>

Just one more comment besides what Amir already wrote:

> @@ -599,6 +646,30 @@ field.
>  In that case, the audit subsystem will log information about the access
>  decision to the audit logs.
>  .\"
> +.SS Monitoring filesystems for errors
> +A single FAN_FS_ERROR event is stored per filesystem at once.
> +Extra error messages are suppressed and accounted for
> +inside the current FAN_FS_ERROR event record,
> +but details about the errors are lost.
> +.PP
> +Error types reported by FAN_FS_ERROR are generic errno values
> +but not all kinds of errors types are reported by all filesystems.
> +Refer to the filesystem documentation
> +for additional information on the type of errors that are reported,
> +and the meaning of those errors.

Hmm, I wish there was any filesystem documentation for this :). I think the
only real source of this information is the kernel source code?

									Honza
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR