Re: [PATCH] ptrace.2: Add details about usage of PTRACE_GET_SYSCALL_INFO

["Dmitry V. Levin" <ldv@strace.io>]

Hi Alex,

On Sat, Feb 25, 2023 at 02:21:51AM +0100, Alex Colomar wrote:
> Hi Dmitry!
> 
> On 2/25/23 01:08, Dmitry V. Levin wrote:
> > On Sat, Feb 25, 2023 at 01:43:18AM +0200, Φώτης Βαλασιάδης wrote:
> >> Better?
> >>
> >> diff --git a/man2/ptrace.2 b/man2/ptrace.2
> >> index 55d9fd36d..ad0543b0b 100644
> >> --- a/man2/ptrace.2
> >> +++ b/man2/ptrace.2
> >> @@ -1111,6 +1111,15 @@ stop.
> >>    .B PTRACE_SYSCALL_INFO_NONE
> >>    No component of the union contains relevant information.
> >>    .RE
> >> +.IP
> >> +Note that in case of
> >> +syscall entry or exit stops, the data returned by
> >> +.B PTRACE_GET_SYSCALL_INFO
> >> +is limited to type
> >> +.B PTRACE_SYSCALL_INFO_NONE
> >> +unless
> >> +.B PTRACE_O_TRACESYSGOOD
> >> +option is set before the corresponding ptrace stop has occurred.
> >>    .\"
> >>    .SS Death under ptrace
> >>    When a (possibly multithreaded) process receives a killing signal
> > 
> > LGTM, thanks.
> 
> Ahh, I see you already CCd Nate.  Thanks!
> 
> Thanks for the review!  I should take that as an Acked-by?

Sure, feel free to add:

Reviewed-by: Dmitry V. Levin <ldv@strace.io>


-- 
ldv