From: "Günther Noack" <gnoack3000@gmail.com>
To: "Alejandro Colomar" <alx.manpages@gmail.com>,
"Mickaël Salaün" <mic@digikod.net>
Cc: linux-man@vger.kernel.org, "Günther Noack" <gnoack3000@gmail.com>
Subject: [PATCH 0/4] landlock.7: Code example improvements
Date: Wed, 19 Apr 2023 20:54:39 +0200 [thread overview]
Message-ID: <20230419185443.7368-1-gnoack3000@gmail.com> (raw)
Various improvements as pointed out by Mickaël Salaün in
https://lore.kernel.org/linux-man/5d90e3b0-1577-7efd-03b8-f94b6e50fbc1@digikod.net/
* Checking system call results differently, for consistency
* Use constants for the compatibility table
(I'm not very attached to the other solution)
* Better wording for error message if Landlock unusable
* Return instead of exit() if Landlock unusable
Regarding the EOPNOTSUPP/ENOTSUP discussion, the consensus seems to be
that EOPNOTSUPP is preferable, because that is the only of the two
error codes that the kernel knows about.
Günther Noack (4):
landlock.7: Check syscall result with == -1 instead of <= 0
landlock.7: Use LANDLOCK_* constants for compatibility table
landlock.7: wfix: Error message wording in code example
landlock.7: Return instead of exit() if Landlock is unusable
man7/landlock.7 | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
base-commit: 6693a21cf73c502f2429b4ec07698130a2be9a93
--
2.40.0
next reply other threads:[~2023-04-19 18:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-19 18:54 Günther Noack [this message]
2023-04-19 18:54 ` [PATCH 1/4] landlock.7: Check syscall result with == -1 instead of <= 0 Günther Noack
2023-04-19 18:54 ` [PATCH 2/4] landlock.7: Use LANDLOCK_* constants for compatibility table Günther Noack
2023-04-19 18:54 ` [PATCH 3/4] landlock.7: wfix: Error message wording in code example Günther Noack
2023-04-19 18:54 ` [PATCH 4/4] landlock.7: Return instead of exit() if Landlock is unusable Günther Noack
2023-04-19 20:37 ` [PATCH 0/4] landlock.7: Code example improvements Alejandro Colomar
2023-04-20 16:34 ` Mickaël Salaün
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230419185443.7368-1-gnoack3000@gmail.com \
--to=gnoack3000@gmail.com \
--cc=alx.manpages@gmail.com \
--cc=linux-man@vger.kernel.org \
--cc=mic@digikod.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox