public inbox for linux-man@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] regex.3: "([^...])" is not an end of sentence
@ 2023-07-08  3:11 наб
  2023-07-08 10:10 ` Tom Schwindl
  0 siblings, 1 reply; 4+ messages in thread
From: наб @ 2023-07-08  3:11 UTC (permalink / raw)
  To: Alejandro Colomar (man-pages); +Cc: linux-man

[-- Attachment #1: Type: text/plain, Size: 576 bytes --]

Caused a double space before "not".

Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
---
 man3/regex.3 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/man3/regex.3 b/man3/regex.3
index 13e540b22..630c0369d 100644
--- a/man3/regex.3
+++ b/man3/regex.3
@@ -109,7 +109,7 @@ .SS Compilation
 Match-any-character operators don't match a newline.
 .IP
 A nonmatching list
-.RB ( [\[ha]...] )
+.RB ( [\[ha]...\&] )
 not containing a newline does not match a newline.
 .IP
 Match-beginning-of-line operator
-- 
2.39.2

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] regex.3: "([^...])" is not an end of sentence
  2023-07-08  3:11 [PATCH] regex.3: "([^...])" is not an end of sentence наб
@ 2023-07-08 10:10 ` Tom Schwindl
  2023-07-08 13:52   ` G. Branden Robinson
  0 siblings, 1 reply; 4+ messages in thread
From: Tom Schwindl @ 2023-07-08 10:10 UTC (permalink / raw)
  To: наб, Alejandro Colomar (man-pages); +Cc: linux-man

Hi,

On Sat Jul 8, 2023 at 5:11 AM CEST, наб wrote:
> Caused a double space before "not".
>
> Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
> ---
>  man3/regex.3 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/man3/regex.3 b/man3/regex.3
> index 13e540b22..630c0369d 100644
> --- a/man3/regex.3
> +++ b/man3/regex.3
> @@ -109,7 +109,7 @@ .SS Compilation
>  Match-any-character operators don't match a newline.
>  .IP
>  A nonmatching list
> -.RB ( [\[ha]...] )
> +.RB ( [\[ha]...\&] )
>  not containing a newline does not match a newline.
>  .IP
>  Match-beginning-of-line operator

I cannot reproduce this on my system; only one space is rendered.
After applying the patch, there are no visible changes. So if there really are
issues for some people, your patch at least doesn't break anything.

-- 
Best Regards,
Tom Schwindl

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] regex.3: "([^...])" is not an end of sentence
  2023-07-08 10:10 ` Tom Schwindl
@ 2023-07-08 13:52   ` G. Branden Robinson
  2023-07-08 17:49     ` Alejandro Colomar
  0 siblings, 1 reply; 4+ messages in thread
From: G. Branden Robinson @ 2023-07-08 13:52 UTC (permalink / raw)
  To: Tom Schwindl
  Cc: наб, Alejandro Colomar (man-pages), linux-man

[-- Attachment #1: Type: text/plain, Size: 2378 bytes --]

Hi Tom,

At 2023-07-08T10:10:01+0000, Tom Schwindl wrote:
> On Sat Jul 8, 2023 at 5:11 AM CEST, наб wrote:
> > diff --git a/man3/regex.3 b/man3/regex.3
> > index 13e540b22..630c0369d 100644
> > --- a/man3/regex.3
> > +++ b/man3/regex.3
> > @@ -109,7 +109,7 @@ .SS Compilation
> >  Match-any-character operators don't match a newline.
> >  .IP
> >  A nonmatching list
> > -.RB ( [\[ha]...] )
> > +.RB ( [\[ha]...\&] )
> >  not containing a newline does not match a newline.
> >  .IP
> >  Match-beginning-of-line operator
> 
> I cannot reproduce this on my system; only one space is rendered.

You may have the inter-sentence space amount configured to zero.[1]

I get the extra space with all of DWB 3.3 nroff, Heirloom Doctools
nroff, mandoc, and groff.

$ printf '.ll 100n\nA nonmatching list\n([\(ha...])\nnot containing a newline does not match a newline.\n' | groff -Tascii | cat -s
A nonmatching list ([^...])  not containing a newline does not match a newline.

[cd DWB][2]
$ printf '.ll 100n\nA nonmatching list\n([\(ha...])\nnot containing a newline does not match a newline.\n' | DWBHOME=. ./bin/nroff | cat -s
A nonmatching list ([...])  not containing a newline does not match a newline.

[cd Heirloom]
$ printf '.ll 100n\nA nonmatching list\n([\(ha...])\nnot containing a newline does not match a newline.\n' | ./bin/nroff | cat -s
A nonmatching list ([^...])  not containing a newline does not match a newline.

$ printf '.ll 100n\nA nonmatching list\n([\(ha...])\nnot containing a newline does not match a newline.\n' | mandoc | cat -s
()                                                                          ()

A nonmatching list ([^...])  not containing a newline does not match a newline.

                                                                                                  ()
Regards,
Branden

[1] Adding the following line to your man.local file in a groff
    installation would do the trick.

    .ss 12 0

    In groff, this is also the default for several "groff locales",
    including "cs", "de", "fr", "sv", and, new in groff 1.23.0, "it".

[2] I respelled the \[ha] special character escape sequence in legacy
    form for greater portability, but the "ha" special character _name_
    is not recognized by DWB troff (which has not been maintained for
    about 30 years).

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] regex.3: "([^...])" is not an end of sentence
  2023-07-08 13:52   ` G. Branden Robinson
@ 2023-07-08 17:49     ` Alejandro Colomar
  0 siblings, 0 replies; 4+ messages in thread
From: Alejandro Colomar @ 2023-07-08 17:49 UTC (permalink / raw)
  To: наб, G. Branden Robinson, Tom Schwindl; +Cc: linux-man


[-- Attachment #1.1: Type: text/plain, Size: 2688 bytes --]

Hi!

On 7/8/23 15:52, G. Branden Robinson wrote:
> Hi Tom,
> 
> At 2023-07-08T10:10:01+0000, Tom Schwindl wrote:
>> On Sat Jul 8, 2023 at 5:11 AM CEST, наб wrote:
>>> diff --git a/man3/regex.3 b/man3/regex.3
>>> index 13e540b22..630c0369d 100644
>>> --- a/man3/regex.3
>>> +++ b/man3/regex.3
>>> @@ -109,7 +109,7 @@ .SS Compilation
>>>   Match-any-character operators don't match a newline.
>>>   .IP
>>>   A nonmatching list
>>> -.RB ( [\[ha]...] )
>>> +.RB ( [\[ha]...\&] )
>>>   not containing a newline does not match a newline.
>>>   .IP
>>>   Match-beginning-of-line operator
>>
>> I cannot reproduce this on my system; only one space is rendered.
> 
> You may have the inter-sentence space amount configured to zero.[1]
> 
> I get the extra space with all of DWB 3.3 nroff, Heirloom Doctools
> nroff, mandoc, and groff.
> 
> $ printf '.ll 100n\nA nonmatching list\n([\(ha...])\nnot containing a newline does not match a newline.\n' | groff -Tascii | cat -s
> A nonmatching list ([^...])  not containing a newline does not match a newline.
> 
> [cd DWB][2]
> $ printf '.ll 100n\nA nonmatching list\n([\(ha...])\nnot containing a newline does not match a newline.\n' | DWBHOME=. ./bin/nroff | cat -s
> A nonmatching list ([...])  not containing a newline does not match a newline.
> 
> [cd Heirloom]
> $ printf '.ll 100n\nA nonmatching list\n([\(ha...])\nnot containing a newline does not match a newline.\n' | ./bin/nroff | cat -s
> A nonmatching list ([^...])  not containing a newline does not match a newline.
> 
> $ printf '.ll 100n\nA nonmatching list\n([\(ha...])\nnot containing a newline does not match a newline.\n' | mandoc | cat -s
> ()                                                                          ()
> 
> A nonmatching list ([^...])  not containing a newline does not match a newline.
> 
>                                                                                                    ()
> Regards,
> Branden
> 
> [1] Adding the following line to your man.local file in a groff
>      installation would do the trick.
> 
>      .ss 12 0
> 
>      In groff, this is also the default for several "groff locales",
>      including "cs", "de", "fr", "sv", and, new in groff 1.23.0, "it".
> 
> [2] I respelled the \[ha] special character escape sequence in legacy
>      form for greater portability, but the "ha" special character _name_
>      is not recognized by DWB troff (which has not been maintained for
>      about 30 years).

Thanks you all!  Patch applied.

Cheers,
Alex

-- 
<http://www.alejandro-colomar.es/>
GPG key fingerprint: A9348594CE31283A826FBDD8D57633D441E25BB5


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-07-08 17:50 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-08  3:11 [PATCH] regex.3: "([^...])" is not an end of sentence наб
2023-07-08 10:10 ` Tom Schwindl
2023-07-08 13:52   ` G. Branden Robinson
2023-07-08 17:49     ` Alejandro Colomar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox