From: Rik van Riel <riel@surriel.com>
To: Alejandro Colomar <alx@kernel.org>
Cc: linux-man@vger.kernel.org, kernel-team@meta.com,
linux-kernel@vger.kernel.org,
Matthew House <mattlloydhouse@gmail.com>,
Eric Biederman <ebiederm@xmission.com>
Subject: [PATCH v3] execve.2: execve also returns E2BIG if a string is too long
Date: Wed, 11 Oct 2023 12:43:01 -0400 [thread overview]
Message-ID: <20231011124301.4d93ea72@imladris.surriel.com> (raw)
The execve syscall returns -E2BIG in 3 cases:
- The total length of the command line arguments and environment is too large.
- An argument or environment string is longer than MAX_ARG_STRLEN.
- The full path to the executable exceeds MAX_ARG_STRLEN.
Spell out all 3 cases in the -E2BIG section.
Discovered by moving a too large commandline parameter to an environment
variable, and finding that things still did not work. Examined the code
in fs/exec.c to get the details.
This shell script starts failing at 2^17 on a system with 4kB page size:
./exec2big.sh: line 10: /bin/true: Argument list too long
fork failed at loop 17
STRING="a"
for loop in `seq 20`; do
STRING="$STRING$STRING"
export STRING
if /bin/true ; then
: # still under the limit
else
echo "fork failed at loop $loop"
fi
done
Signed-off-by: Rik van Riel <riel@surriel.com>
Suggested-by: Matthew House <mattlloydhouse@gmail.com>
---
man2/execve.2 | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/man2/execve.2 b/man2/execve.2
index 0d9582492ad1..85c6ec15df3c 100644
--- a/man2/execve.2
+++ b/man2/execve.2
@@ -449,7 +449,8 @@ The total number of bytes in the environment
.RI ( envp )
and argument list
.RI ( argv )
-is too large.
+is too large, an argument or environment string is too long, or
+the full path name to the executable is too long.
.TP
.B EACCES
Search permission is denied on a component of the path prefix of
--
2.41.0
next reply other threads:[~2023-10-11 16:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-11 16:43 Rik van Riel [this message]
2023-10-11 16:53 ` [PATCH v4] execve.2: execve also returns E2BIG if a string is too long Rik van Riel
2023-10-11 20:11 ` Using hg and git (Was: [PATCH v4] execve.2: execve also returns E2BIG if a string is too long) Alejandro Colomar
2023-10-11 20:14 ` [PATCH v4] execve.2: execve also returns E2BIG if a string is too long Alejandro Colomar
2023-10-11 20:53 ` Rik van Riel
2023-10-11 23:45 ` Alejandro Colomar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231011124301.4d93ea72@imladris.surriel.com \
--to=riel@surriel.com \
--cc=alx@kernel.org \
--cc=ebiederm@xmission.com \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-man@vger.kernel.org \
--cc=mattlloydhouse@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox