From: Mark Wielaard <mark@klomp.org>
To: linux-man@vger.kernel.org
Cc: "Alejandro Colomar" <alx@kernel.org>,
"Mark Wielaard" <mark@klomp.org>,
"Alexandra Hájková" <ahajkova@redhat.com>
Subject: [PATCH v2] close_range.2: Add _GNU_SOURCE and unistd.h to SYNOPSIS
Date: Mon, 12 Feb 2024 00:29:03 +0100 [thread overview]
Message-ID: <20240211232903.1622396-1-mark@klomp.org> (raw)
close_range is defined in unistd.h when _GNU_SOURCE is defined.
The linux/close_range.h include file only defines the (linux specific)
flags constants. The flags argument is an int, not an unsigned int, in
the glibc wrapper. Use the close_range library call in the example code
instead of syscall.
Fixes: 71a62d6c3c56 ("close_range.2: Glibc added a wrapper recently")
Fixes: c2356ba085ed ("close_range.2: Glibc 2.34 has added a close_range() wrapper")
Reported-by: Alexandra Hájková <ahajkova@redhat.com>
Signed-off-by: Mark Wielaard <mark@klomp.org>
---
man2/close_range.2 | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/man2/close_range.2 b/man2/close_range.2
index 380a47365..62b728e96 100644
--- a/man2/close_range.2
+++ b/man2/close_range.2
@@ -11,10 +11,13 @@ Standard C library
.RI ( libc ", " \-lc )
.SH SYNOPSIS
.nf
-.B #include <linux/close_range.h>
+.BR "#define _GNU_SOURCE" " /* See feature_test_macros(7) */"
+.B #include <unistd.h>
+.P
+.BR "#include <linux/close_range.h>" " /* For the flags constants */"
.P
.BI "int close_range(unsigned int " first ", unsigned int " last ,
-.BI " unsigned int " flags );
+.BI " int " flags );
.fi
.SH DESCRIPTION
The
@@ -205,7 +208,6 @@ result from the calls to
#include <limits.h>
#include <stdio.h>
#include <stdlib.h>
-#include <sys/syscall.h>
#include <unistd.h>
\&
/* Show the contents of the symbolic links in /proc/self/fd */
@@ -259,7 +261,7 @@ main(int argc, char *argv[])
\&
printf("========= About to call close_range() =======\en");
\&
- if (syscall(SYS_close_range, 3, \[ti]0U, 0) == \-1) {
+ if (close_range(3, \[ti]0U, 0) == \-1) {
perror("close_range");
exit(EXIT_FAILURE);
}
--
2.39.3
next reply other threads:[~2024-02-11 23:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-11 23:29 Mark Wielaard [this message]
2024-02-11 23:49 ` [PATCH v2] close_range.2: Add _GNU_SOURCE and unistd.h to SYNOPSIS Alejandro Colomar
2024-02-12 0:05 ` Mark Wielaard
2024-02-12 1:49 ` Alejandro Colomar
2024-02-12 12:06 ` Mark Wielaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240211232903.1622396-1-mark@klomp.org \
--to=mark@klomp.org \
--cc=ahajkova@redhat.com \
--cc=alx@kernel.org \
--cc=linux-man@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox