Re: [PATCH v2] close_range.2: Add _GNU_SOURCE and unistd.h to SYNOPSIS

Mark Wielaard
2024-02-12T12:06:19Z

Hi Alejandro,

On Mon, Feb 12, 2024 at 02:49:16AM +0100, Alejandro Colomar wrote:
> When we include a header not for a function but for constants, we
> specify which are those constants. For example, membarrier(2) has
>
> #include <linux/membarrier.h> /* Definition of MEMBARRIER_* constants */
> #include <sys/syscall.h> /* Definition of SYS_* constants */
>

Aha, ok, the other comment. Will reword for V3.

> Here, I'd use
> #include <linux/close_range.h> /* Definition of CLOSE_RANGE_* constants */
>
> BTW, I notice that it's near the 80-column limit. We try to limit
> ourselves to 79 columns, for an obscure reason. For that, we'll need to
> use only 1 space before the comment (otherwise, I'd agree to use 2).

Yeah, max 79 max sense (all my terminals are 80 chars wide).
Formatting the comment is a little tricky, but I believe I got it.

Cheers,

Mark