From: "G. Branden Robinson" <g.branden.robinson@gmail.com>
To: Alejandro Colomar <alx@kernel.org>
Cc: linux-man@vger.kernel.org
Subject: Re: [PATCH 3/3] man2/syscalls.2: srcfix
Date: Fri, 26 Apr 2024 16:41:02 -0500 [thread overview]
Message-ID: <20240426214102.6pioaplkwkbch6iw@illithid> (raw)
In-Reply-To: <Zh-gDFAi5uqljz2L@debian>
[-- Attachment #1: Type: text/plain, Size: 1388 bytes --]
Hi Alex,
At 2024-04-17T12:10:20+0200, Alejandro Colomar wrote:
> On Mon, Apr 15, 2024 at 05:39:53PM -0500, G. Branden Robinson wrote:
> > Migrate table entries from using font selection escape sequences to
> > font alternation macros to set man page cross references.
> >
> > This change was automatically driven by the following sed(1)
> > scripts, run in series. (Due to multiple uses of branching and
> > dependent relationships between some edits, one big script would not
> > serve.)
>
> Would it make sense to split this into 3 patches, so that each
> corresponds to one script? Or are the intermediate steps not good?
The intermediate steps are not useful. For example, after the first sed
script, we have changes like this:
diff --git a/man2/syscalls.2 b/man2/syscalls.2
index 7a7d6d730..979dba538 100644
--- a/man2/syscalls.2
+++ b/man2/syscalls.2
@@ -187,7 +187,8 @@ .SS System call list
\fBchdir\fP(2) 1.0
\fBchmod\fP(2) 1.0
\fBchown\fP(2) 2.2 T{
-See \fBchown\fP(2) for
+See .BR chown (2)
+for
version details
T}
\fBchown32\fP(2) 2.4
Having ".BR chown (2)" sitting out there as unformatted text (because
macro calls have to _start_ an input line) is obviously not useful.
However, I did discover that the second script was a no-op! So I'm
dropping that (actually, replacing it) and will submit a v2.
Regards,
Branden
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2024-04-26 21:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-15 22:39 [PATCH 3/3] man2/syscalls.2: srcfix G. Branden Robinson
2024-04-17 10:10 ` Alejandro Colomar
2024-04-26 21:41 ` G. Branden Robinson [this message]
2024-04-26 22:12 ` Alejandro Colomar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240426214102.6pioaplkwkbch6iw@illithid \
--to=g.branden.robinson@gmail.com \
--cc=alx@kernel.org \
--cc=linux-man@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox