Re: [PATCH] madvise: MADV_SOFT_OFFLINE requests can return -EBUSY

[Alejandro Colomar <alx@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1674 bytes --]

Hi Tyonnchie,

On Thu, Oct 10, 2024 at 05:41:38PM -0400, tyberry@redhat.com wrote:
> If any page(s) within the add+length range could not be offlined madvise
> will return -EBUSY. This might occur if the page is currently in use or
> locked.
> 
> Signed-off-by: Tyonnchie Berry <tyberry@redhat.com>
> 
> ---
> 
> diff --git a/man/man2/madvise.2 b/man/man2/madvise.2
> index 441edfbc1..13ee7957c 100644
> --- a/man/man2/madvise.2
> +++ b/man/man2/madvise.2
> @@ -702,6 +702,11 @@ The map exists, but the area maps something that isn't a file.
>  .BR MADV_COLLAPSE )
>  Could not charge hugepage to cgroup: cgroup limit exceeded.
>  .TP
> +.B EBUSY
> +(for
> +.B MADV_SOFT_OFFLINE )
> +If any page(s) within the add+length range could not be offlined madvise will return -EBUSY. This might occur if the page is currently in use or locked.

"any pages" includes the possible value 1; there's no need for "()".

Please use semantic newlines.  See man-pages(7).

$ MANWIDTH=72 man man-pages | sed -n '/Use semantic newlines/,/^$/p'
   Use semantic newlines
     In  the  source of a manual page, new sentences should be started
     on new lines, long sentences should be split into lines at clause
     breaks (commas, semicolons, colons, and so on), and long  clauses
     should be split at phrase boundaries.  This convention, sometimes
     known  as  "semantic newlines", makes it easier to see the effect
     of patches, which often operate at the level of  individual  sen‐
     tences, clauses, or phrases.


Have a lovely day!
Alex

> +.TP
>  .B EFAULT
>  .I advice
>  is
> 

-- 
<https://www.alejandro-colomar.es/>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]