Re: [PATCH man v2 2/2] TIOCLINUX.2const: Document missing TIOCL_SETSEL selection modes

["Günther Noack" <gnoack3000@gmail.com>]

Hello!

On Sun, Feb 23, 2025 at 03:19:02PM -0800, Jared Finder wrote:
> On 2025-02-23 13:36, Günther Noack wrote:
> >  man/man2const/TIOCLINUX.2const | 29 +++++++++++++++++++++++++++++
> >  1 file changed, 29 insertions(+)
> > 
> > diff --git a/man/man2const/TIOCLINUX.2const
> > b/man/man2const/TIOCLINUX.2const
> > index 5db3f6ea6..3aa1c7eb2 100644
> > --- a/man/man2const/TIOCLINUX.2const
> > +++ b/man/man2const/TIOCLINUX.2const
> > @@ -82,6 +82,35 @@ and saved in a kernel buffer.
> >  Select line-by-line.
> >  The indicated screen characters are highlighted
> >  and saved in a kernel buffer.
> > +.TP
> > +.B TIOCL_SELPOINTER
> > +Show the pointer at position
> > +.RI ( xe ,\~ ye ).
> 
> nit: Technically, "at the greater position of start or end".  See how ps and
> pe are swapped if ps > pe in vc_selection().

Thanks, that is a good point, I had missed that.

I happens at a central place in the code, where it technically affects
all operations except for TIOCL_SELMOUSEREPORT, but it only makes a
difference in the documentation of TIOCL_SELPOINTER.


> > +.TP
> > +.B TIOCL_SELCLEAR
> > +Remove the current selection highlight, if any,
> > +from the console holding the selection.
> 
> I'd recommend stating explicitly if this affects the stored characters. (I
> believe it does not.)

Thanks, added.

–Günther