public inbox for linux-man@vger.kernel.org
 help / color / mirror / Atom feed
From: "Jₑₙₛ Gustedt" <jens.gustedt@inria.fr>
To: Carlos O'Donell <carlos@redhat.com>
Cc: Alejandro Colomar <alx@kernel.org>,
	Michael Kerrisk <mtk.manpages@gmail.com>,
	linux-man@vger.kernel.org, Ulrich Drepper <drepper@redhat.com>,
	Ingo Molnar <mingo@kernel.org>, Todd Lewis <todd.lewis@gs.com>,
	Alexandre Oliva <aoliva@redhat.com>
Subject: Re: bug in futex.2, FUTEX_CMP_REQUEUE
Date: Tue, 27 May 2025 15:07:30 +0200	[thread overview]
Message-ID: <20250527150730.3b328571@inria.fr> (raw)
In-Reply-To: <30b84225-8965-44a4-8856-3ab2169ba226@redhat.com>

Hello Carlos,

On Tue, 27 May 2025 08:42:27 -0400, Carlos O'Donell wrote:

> Suggest:
> 
> (Specifying val as INT_MAX is not useful, because it would make the
>   FUTEX_CMP_REQUEUE  operation  equivalent  to  FUTEX_WAKE.)

That is not true because `val3` is checked for the first and not the
second, so they are not equivalent. And indeed `val` as `INT_MAX` is
usefull, because it provides a wake up of everybody with an additional
check of `val3`.

> Suggest:
> 
> (Specifying val2 as 0 is not useful, because it may make the
>   FUTEX_CMP_REQUEUE operation equivalent to FUTEX_WAKE depending
>   on val and val3.)

I think that specifying `val2` as `0` is in fact useful because it
provides a wake operation that additionally checks for `val3`. (and
does no requeing)


Thanks
Jₑₙₛ


-- 
:: ICube :::::::::::::::::::::::::::::: deputy director ::
:: Université de Strasbourg :::::::::::::::::::::: ICPS ::
:: INRIA antenne de Strasbourg :::::::::::::::::: Camus ::
:: INRIA PIQ program Strasbourg :::::::::: piq.inria.fr ::
:: :::::::::::::::::::::::::::::::::::: ☎ +33 368854536 ::
:: https://icube-icps.unistra.fr/index.php/Jens_Gustedt ::

  parent reply	other threads:[~2025-05-27 13:07 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-27  9:53 bug in futex.2, FUTEX_CMP_REQUEUE Jₑₙₛ Gustedt
2025-05-27 11:30 ` Carlos O'Donell
2025-05-27 12:21   ` Jₑₙₛ Gustedt
2025-05-27 12:28     ` Carlos O'Donell
2025-05-27 12:23   ` Alejandro Colomar
2025-05-27 12:35     ` Carlos O'Donell
2025-05-27 12:01 ` Alejandro Colomar
2025-05-27 12:12   ` Carlos O'Donell
2025-05-27 12:28     ` Jₑₙₛ Gustedt
2025-05-27 12:37       ` Carlos O'Donell
2025-05-27 12:51         ` Alejandro Colomar
2025-05-27 12:54           ` Carlos O'Donell
2025-05-27 12:28     ` Alejandro Colomar
2025-05-27 12:42       ` Carlos O'Donell
2025-05-27 12:57         ` Alejandro Colomar
2025-05-27 12:59           ` Alejandro Colomar
2025-05-27 13:07         ` Jₑₙₛ Gustedt [this message]
2025-05-29 23:35   ` Alejandro Colomar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250527150730.3b328571@inria.fr \
    --to=jens.gustedt@inria.fr \
    --cc=alx@kernel.org \
    --cc=aoliva@redhat.com \
    --cc=carlos@redhat.com \
    --cc=drepper@redhat.com \
    --cc=linux-man@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=mtk.manpages@gmail.com \
    --cc=todd.lewis@gs.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox