public inbox for linux-man@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH v3] man/man2/cachestat.2: add a man page for cachestat()
@ 2025-05-30 12:48 Matteo Croce
  2025-06-11  9:09 ` Alejandro Colomar
  0 siblings, 1 reply; 4+ messages in thread
From: Matteo Croce @ 2025-05-30 12:48 UTC (permalink / raw)
  To: linux-man; +Cc: Nhat Pham, Johannes Weiner, Matteo Croce

From: Matteo Croce <teknoraver@meta.com>

Add a missing man page for cachestat().
The text was converted from the commit message:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=cf264e1329fb0307e044f7675849f9f38b44c11a

Signed-off-by: Nhat Pham <nphamcs@gmail.com>
Signed-off-by: Matteo Croce <teknoraver@meta.com>
---
 man/man2/cachestat.2 | 111 +++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 111 insertions(+)
 create mode 100644 man/man2/cachestat.2

diff --git a/man/man2/cachestat.2 b/man/man2/cachestat.2
new file mode 100644
index 000000000..12dbd900d
--- /dev/null
+++ b/man/man2/cachestat.2
@@ -0,0 +1,111 @@
+.\" Copyright, the authors of the Linux man-pages project
+.\"
+.\" SPDX-License-Identifier: Linux-man-pages-copyleft
+.\"
+.TH cachestat 2 (date) "Linux man-pages (unreleased)"
+.SH NAME
+cachestat \- query the page cache statistics of a file
+.SH SYNOPSIS
+.nf
+.B #include <sys/mman.h>
+.P
+.B struct cachestat_range {
+.B "    __u64 off;"
+.B "    __u64 len;"
+.B };
+.P
+.B struct cachestat {
+.B "    __u64 nr_cache;"
+.B "    __u64 nr_dirty;"
+.B "    __u64 nr_writeback;"
+.B "    __u64 nr_evicted;"
+.B "    __u64 nr_recently_evicted;"
+.B };
+.P
+.BI "int cachestat(unsigned int " fd ", struct cachestat_range *" cstat_range ","
+.BI "              struct cachestat *" cstat ", unsigned int " flags ");"
+.nf
+.SH DESCRIPTION
+.B cachestat()
+queries the number of cached pages, dirty pages,
+pages marked for writeback, evicted pages,
+and recently evicted pages in the byte range specified by
+.I .off
+and
+.I .len
+in the
+.B cachestat_range
+structure.
+.P
+An evicted page is one that was previously in the page cache
+but has since been evicted.
+A page is considered recently evicted if its reentry into the cache
+would indicate active usage under memory pressure.
+.P
+The results are returned in a
+.B cachestat
+structure, pointed to by the
+.I cstat
+argument.
+.P
+The
+.I .off
+and
+.I .len
+fields must be non-negative.
+If
+.IR .len\~>\~0 ,
+the queried range is
+.RI [ .off ,\~ .off+.len ]
+. If
+.IR len\~==\~0 ,
+the range is from
+.I .off
+to the end of the file.
+.P
+The
+.I flags
+argument is reserved for future use and must be set to
+.BR 0 .
+.
+.P
+Currently,
+.B hugetlbfs
+files are not supported.
+.SH RETURN VALUE
+On success,
+.B cachestat()
+returns 0.
+On error, \-1 is returned,
+and
+.I errno
+is set appropriately.
+.SH ERRORS
+.TP
+.B EFAULT
+.I cstat
+or
+.I cstat_range
+point to an invalid address.
+.TP
+.B EINVAL
+Invalid
+.I flags
+value.
+.TP
+.B EBADF
+Invalid file descriptor.
+.TP
+.B EOPNOTSUPP
+The file descriptor refers to a
+.B hugetlbfs
+file, which is unsupported.
+.SH STANDARDS
+Linux.
+.SH HISTORY
+Linux 6.5.
+.SH CAVEATS
+Note that the status of a page may change after
+.B cachestat()
+retrieves it but before the values are returned to the application;
+thus, the values may be slightly outdated.
-- 
2.49.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v3] man/man2/cachestat.2: add a man page for cachestat()
  2025-05-30 12:48 [PATCH v3] man/man2/cachestat.2: add a man page for cachestat() Matteo Croce
@ 2025-06-11  9:09 ` Alejandro Colomar
  2025-06-11 14:11   ` Matteo Croce
  0 siblings, 1 reply; 4+ messages in thread
From: Alejandro Colomar @ 2025-06-11  9:09 UTC (permalink / raw)
  To: Matteo Croce; +Cc: linux-man, Nhat Pham, Johannes Weiner, Matteo Croce

[-- Attachment #1: Type: text/plain, Size: 3996 bytes --]

Hi Matteo,

On Fri, May 30, 2025 at 02:48:29PM +0200, Matteo Croce wrote:
> From: Matteo Croce <teknoraver@meta.com>
> 
> Add a missing man page for cachestat().
> The text was converted from the commit message:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=cf264e1329fb0307e044f7675849f9f38b44c11a
> 
> Signed-off-by: Nhat Pham <nphamcs@gmail.com>
> Signed-off-by: Matteo Croce <teknoraver@meta.com>

Thanks!  The patch looks good.  I was going to push it, when CI reported
some issues:

	MANDOC		.tmp/man/man2/cachestat.2.lint-man.mandoc.touch
	mandoc: .tmp/man/man2/cachestat.2:60:3: ERROR: skipping unknown macro:  If
	mandoc: .tmp/man/man2/cachestat.2:27:2: STYLE: fill mode already disabled, skipping: nf

See comments about that below.

> ---
>  man/man2/cachestat.2 | 111 +++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 111 insertions(+)
>  create mode 100644 man/man2/cachestat.2
> 
> diff --git a/man/man2/cachestat.2 b/man/man2/cachestat.2
> new file mode 100644
> index 000000000..12dbd900d
> --- /dev/null
> +++ b/man/man2/cachestat.2
> @@ -0,0 +1,111 @@
> +.\" Copyright, the authors of the Linux man-pages project
> +.\"
> +.\" SPDX-License-Identifier: Linux-man-pages-copyleft
> +.\"
> +.TH cachestat 2 (date) "Linux man-pages (unreleased)"
> +.SH NAME
> +cachestat \- query the page cache statistics of a file
> +.SH SYNOPSIS
> +.nf
> +.B #include <sys/mman.h>
> +.P
> +.B struct cachestat_range {
> +.B "    __u64 off;"
> +.B "    __u64 len;"
> +.B };
> +.P
> +.B struct cachestat {
> +.B "    __u64 nr_cache;"
> +.B "    __u64 nr_dirty;"
> +.B "    __u64 nr_writeback;"
> +.B "    __u64 nr_evicted;"
> +.B "    __u64 nr_recently_evicted;"
> +.B };
> +.P
> +.BI "int cachestat(unsigned int " fd ", struct cachestat_range *" cstat_range ","
> +.BI "              struct cachestat *" cstat ", unsigned int " flags ");"
> +.nf

This should be .fi  (.nf is no-fill mode, while .fi ends that --it
starts fill mode again--)

> +.SH DESCRIPTION
> +.B cachestat()
> +queries the number of cached pages, dirty pages,
> +pages marked for writeback, evicted pages,
> +and recently evicted pages in the byte range specified by
> +.I .off
> +and
> +.I .len
> +in the
> +.B cachestat_range
> +structure.
> +.P
> +An evicted page is one that was previously in the page cache
> +but has since been evicted.
> +A page is considered recently evicted if its reentry into the cache
> +would indicate active usage under memory pressure.
> +.P
> +The results are returned in a
> +.B cachestat
> +structure, pointed to by the
> +.I cstat
> +argument.
> +.P
> +The
> +.I .off
> +and
> +.I .len
> +fields must be non-negative.
> +If
> +.IR .len\~>\~0 ,
> +the queried range is
> +.RI [ .off ,\~ .off+.len ]
> +. If

The '.' should go in the previous line.


Have a lovely day!
Alex

> +.IR len\~==\~0 ,
> +the range is from
> +.I .off
> +to the end of the file.
> +.P
> +The
> +.I flags
> +argument is reserved for future use and must be set to
> +.BR 0 .
> +.
> +.P
> +Currently,
> +.B hugetlbfs
> +files are not supported.
> +.SH RETURN VALUE
> +On success,
> +.B cachestat()
> +returns 0.
> +On error, \-1 is returned,
> +and
> +.I errno
> +is set appropriately.
> +.SH ERRORS
> +.TP
> +.B EFAULT
> +.I cstat
> +or
> +.I cstat_range
> +point to an invalid address.
> +.TP
> +.B EINVAL
> +Invalid
> +.I flags
> +value.
> +.TP
> +.B EBADF
> +Invalid file descriptor.
> +.TP
> +.B EOPNOTSUPP
> +The file descriptor refers to a
> +.B hugetlbfs
> +file, which is unsupported.
> +.SH STANDARDS
> +Linux.
> +.SH HISTORY
> +Linux 6.5.
> +.SH CAVEATS
> +Note that the status of a page may change after
> +.B cachestat()
> +retrieves it but before the values are returned to the application;
> +thus, the values may be slightly outdated.
> -- 
> 2.49.0
> 
> 

-- 
<https://www.alejandro-colomar.es/>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v3] man/man2/cachestat.2: add a man page for cachestat()
  2025-06-11  9:09 ` Alejandro Colomar
@ 2025-06-11 14:11   ` Matteo Croce
  2025-06-11 15:42     ` Alejandro Colomar
  0 siblings, 1 reply; 4+ messages in thread
From: Matteo Croce @ 2025-06-11 14:11 UTC (permalink / raw)
  To: Alejandro Colomar; +Cc: linux-man, Nhat Pham, Johannes Weiner, Matteo Croce

Il giorno mer 11 giu 2025 alle ore 11:09 Alejandro Colomar
<alx@kernel.org> ha scritto:
>
> Hi Matteo,
>
> On Fri, May 30, 2025 at 02:48:29PM +0200, Matteo Croce wrote:
> > From: Matteo Croce <teknoraver@meta.com>
> >
> > Add a missing man page for cachestat().
> > The text was converted from the commit message:
> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=cf264e1329fb0307e044f7675849f9f38b44c11a
> >
> > Signed-off-by: Nhat Pham <nphamcs@gmail.com>
> > Signed-off-by: Matteo Croce <teknoraver@meta.com>
>
> Thanks!  The patch looks good.  I was going to push it, when CI reported
> some issues:
>
>         MANDOC          .tmp/man/man2/cachestat.2.lint-man.mandoc.touch
>         mandoc: .tmp/man/man2/cachestat.2:60:3: ERROR: skipping unknown macro:  If
>         mandoc: .tmp/man/man2/cachestat.2:27:2: STYLE: fill mode already disabled, skipping: nf
>

Oh nice, didn't know about mandoc. I'm using it to validate the man page with:

mandoc -W base,stop man/man2/cachestat.2

thanks!

> See comments about that below.
>
> > ---
> >  man/man2/cachestat.2 | 111 +++++++++++++++++++++++++++++++++++++++++++
> >  1 file changed, 111 insertions(+)
> >  create mode 100644 man/man2/cachestat.2
> >
> > diff --git a/man/man2/cachestat.2 b/man/man2/cachestat.2
> > new file mode 100644
> > index 000000000..12dbd900d
> > --- /dev/null
> > +++ b/man/man2/cachestat.2
> > @@ -0,0 +1,111 @@
> > +.\" Copyright, the authors of the Linux man-pages project
> > +.\"
> > +.\" SPDX-License-Identifier: Linux-man-pages-copyleft
> > +.\"
> > +.TH cachestat 2 (date) "Linux man-pages (unreleased)"
> > +.SH NAME
> > +cachestat \- query the page cache statistics of a file
> > +.SH SYNOPSIS
> > +.nf
> > +.B #include <sys/mman.h>
> > +.P
> > +.B struct cachestat_range {
> > +.B "    __u64 off;"
> > +.B "    __u64 len;"
> > +.B };
> > +.P
> > +.B struct cachestat {
> > +.B "    __u64 nr_cache;"
> > +.B "    __u64 nr_dirty;"
> > +.B "    __u64 nr_writeback;"
> > +.B "    __u64 nr_evicted;"
> > +.B "    __u64 nr_recently_evicted;"
> > +.B };
> > +.P
> > +.BI "int cachestat(unsigned int " fd ", struct cachestat_range *" cstat_range ","
> > +.BI "              struct cachestat *" cstat ", unsigned int " flags ");"
> > +.nf
>
> This should be .fi  (.nf is no-fill mode, while .fi ends that --it
> starts fill mode again--)
>
> > +.SH DESCRIPTION
> > +.B cachestat()
> > +queries the number of cached pages, dirty pages,
> > +pages marked for writeback, evicted pages,
> > +and recently evicted pages in the byte range specified by
> > +.I .off
> > +and
> > +.I .len
> > +in the
> > +.B cachestat_range
> > +structure.
> > +.P
> > +An evicted page is one that was previously in the page cache
> > +but has since been evicted.
> > +A page is considered recently evicted if its reentry into the cache
> > +would indicate active usage under memory pressure.
> > +.P
> > +The results are returned in a
> > +.B cachestat
> > +structure, pointed to by the
> > +.I cstat
> > +argument.
> > +.P
> > +The
> > +.I .off
> > +and
> > +.I .len
> > +fields must be non-negative.
> > +If
> > +.IR .len\~>\~0 ,
> > +the queried range is
> > +.RI [ .off ,\~ .off+.len ]
> > +. If
>
> The '.' should go in the previous line.
>
>
> Have a lovely day!
> Alex
>

I'm fixing these errors now, have a lovely day too!

-- 
Matteo Croce

perl -e 'for($t=0;;$t++){print chr($t*($t>>8|$t>>13)&255)}' |aplay

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v3] man/man2/cachestat.2: add a man page for cachestat()
  2025-06-11 14:11   ` Matteo Croce
@ 2025-06-11 15:42     ` Alejandro Colomar
  0 siblings, 0 replies; 4+ messages in thread
From: Alejandro Colomar @ 2025-06-11 15:42 UTC (permalink / raw)
  To: Matteo Croce; +Cc: linux-man, Nhat Pham, Johannes Weiner, Matteo Croce

[-- Attachment #1: Type: text/plain, Size: 1429 bytes --]

Hi Matteo,

On Wed, Jun 11, 2025 at 04:11:37PM +0200, Matteo Croce wrote:
> >         MANDOC          .tmp/man/man2/cachestat.2.lint-man.mandoc.touch
> >         mandoc: .tmp/man/man2/cachestat.2:60:3: ERROR: skipping unknown macro:  If
> >         mandoc: .tmp/man/man2/cachestat.2:27:2: STYLE: fill mode already disabled, skipping: nf
> >
> 
> Oh nice, didn't know about mandoc. I'm using it to validate the man page with:
> 
> mandoc -W base,stop man/man2/cachestat.2

I use `mandoc -Tlint man/man2/cachestat.2` (except that I ignore a few
of those warnings).  Here's the exact command that runs in the build
system (and thus in my CI):

	$ make lint-man-mandoc -R --debug=print |& head -n8
	make: warning: undefined variable 'GNUMAKEFLAGS'
	MANDOC		.tmp/man/man2/ioctl_fs.2.lint-man.mandoc.touch
	! (mandoc -Tlint  .tmp/man/man2/ioctl_fs.2 2>&1 \
	   | grep -v -f '/srv/alx/src/linux/man-pages/man-pages/master/share/mk/lint/man/mandoc.ignore.grep' \
	   || true; \
	) \
	| grep ^ >&2
	touch .tmp/man/man2/ioctl_fs.2.lint-man.mandoc.touch

You can run `make -R -j4 lint-man-mandoc` to lint it with the usual
exceptions that I configured.  Or `make -R -j4 lint build-all check` to
run even more checks.  Help about those is under CONTRIBUTING.d/ and
with `make -R help`.

> I'm fixing these errors now, have a lovely day too!

:-)

Cheers,
Alex

-- 
<https://www.alejandro-colomar.es/>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2025-06-11 15:42 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-30 12:48 [PATCH v3] man/man2/cachestat.2: add a man page for cachestat() Matteo Croce
2025-06-11  9:09 ` Alejandro Colomar
2025-06-11 14:11   ` Matteo Croce
2025-06-11 15:42     ` Alejandro Colomar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox