Re: [PATCH v5 7/8] man/man2/open_tree{,_attr}.2: document new open_tree_attr() API

Aleksa Sarai
2025-10-01T07:36:03Z

[-- Attachment #1: Type: text/plain, Size: 856 bytes --]

On 2025-10-01, Askar Safin <safinaskar@gmail.com> wrote:
> Aleksa Sarai <cyphar@cyphar.com>:
> > +mntfd2 = open_tree(mntfd1, "", OPEN_TREE_CLONE,
> > + &attr, sizeof(attr));
>
> Your whole so-called "open_tree_attr example" doesn't contain any open_tree_attr
> calls. :)
>
> I think you meant open_tree_attr here.

Oops.

>
> > +\&
> > +/* Create a new copy with the id-mapping cleared */
> > +memset(&attr, 0, sizeof(attr));
> > +attr.attr_clr = MOUNT_ATTR_IDMAP;
> > +mntfd3 = open_tree(mntfd1, "", OPEN_TREE_CLONE,
> > + &attr, sizeof(attr));
>
> And here.

Oops x2.

> Otherwise your whole patchset looks good. Add to whole patchset:
> Reviewed-by: Askar Safin <safinaskar@gmail.com>

--
Aleksa Sarai
Senior Software Engineer (Containers)
SUSE Linux GmbH
https://www.cyphar.com/

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 265 bytes --]