[PATCH v2] iman/man2/swapon.2: update priority section

[PATCH v2] iman/man2/swapon.2: update priority section

[Baoquan He]

This update the description about default priority value which is
changed in kernel.

Link: https://lore.kernel.org/all/20251011081624.224202-1-bhe@redhat.com/
Signed-off-by: Baoquan He <bhe@redhat.com>
Cc: chrisl@kernel.org
Cc: baohua@kernel.org
Cc: alx@kernel.org
---
 man/man2/swapon.2 | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/man/man2/swapon.2 b/man/man2/swapon.2
index df5e8d8c7ec6..20e213827733 100644
--- a/man/man2/swapon.2
+++ b/man/man2/swapon.2
@@ -60,9 +60,8 @@ These functions may be used only by a privileged process (one having the
 capability).
 .SS Priority
 Each swap area has a priority, either high or low.
-The default priority is low.
-Within the low-priority areas,
-newer areas are even lower priority than older areas.
+The default priority is the lowest,
+and all default areas share the same priority value, -1.
 .P
 All priorities set with
 .I swapflags
-- 
2.41.0

Re: [PATCH v2] iman/man2/swapon.2: update priority section

[Barry Song]

On Mon, Oct 20, 2025 at 6:56 AM Baoquan He <bhe@redhat.com> wrote:
>
> This update the description about default priority value which is
> changed in kernel.

Thanks for sending this. Would it be possible to include a reference to
the related commit — for example, at least the commit subject? Also,
does the man page prefer using a link to the kernel patchset?

>
> Link: https://lore.kernel.org/all/20251011081624.224202-1-bhe@redhat.com/
> Signed-off-by: Baoquan He <bhe@redhat.com>
> Cc: chrisl@kernel.org
> Cc: baohua@kernel.org
> Cc: alx@kernel.org
> ---
>  man/man2/swapon.2 | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/man/man2/swapon.2 b/man/man2/swapon.2
> index df5e8d8c7ec6..20e213827733 100644
> --- a/man/man2/swapon.2
> +++ b/man/man2/swapon.2
> @@ -60,9 +60,8 @@ These functions may be used only by a privileged process (one having the
>  capability).
>  .SS Priority
>  Each swap area has a priority, either high or low.
> -The default priority is low.
> -Within the low-priority areas,
> -newer areas are even lower priority than older areas.
> +The default priority is the lowest,
> +and all default areas share the same priority value, -1.

Not sure what “default areas” means.
maybe just the below?
"
Areas that are not assigned a priority will receive the default priority of -1.
"

>  .P
>  All priorities set with
>  .I swapflags
> --
> 2.41.0
>

Thanks
Barry

Re: [PATCH v2] iman/man2/swapon.2: update priority section

[Baoquan He]

On 10/20/25 at 05:21pm, Barry Song wrote:
> On Mon, Oct 20, 2025 at 6:56 AM Baoquan He <bhe@redhat.com> wrote:
> >
> > This update the description about default priority value which is
> > changed in kernel.
> 
> Thanks for sending this. Would it be possible to include a reference to
> the related commit — for example, at least the commit subject? Also,
> does the man page prefer using a link to the kernel patchset?

I see a lot of discussion link is provided in man-pages commit log, and
haven't seen a kernel commit. But I see kernel version is mentioned to
mark since when the man page update is made. It's the first time I
update man page, not sure what is better. Would love to hear suggestions
to improve. Thanks. 

https://git.kernel.org/pub/scm/docs/man-pages/man-pages.git


commit 8982bb673546d95b34f7c35be8cadd8091de2a25
Author: Thiago Jung Bauermann <thiago.bauermann@linaro.org>
Date:   Tue Sep 9 16:13:57 2025 -0300

    man/man2/sigaction.2: Update si_code list with Linux v6.16
    
    Update with missing si_code values from Linux v6.16's
    "include/uapi/asm-generic/siginfo.h".
    
    Signed-off-by: Thiago Jung Bauermann <thiago.bauermann@linaro.org>
    Message-ID: <20250909191357.44951-1-thiago.bauermann@linaro.org>
    Reviewed-by: Carlos O'Donell <carlos@redhat.com>
    Signed-off-by: Alejandro Colomar <alx@kernel.org>

> 
> >
> > Link: https://lore.kernel.org/all/20251011081624.224202-1-bhe@redhat.com/
> > Signed-off-by: Baoquan He <bhe@redhat.com>
> > Cc: chrisl@kernel.org
> > Cc: baohua@kernel.org
> > Cc: alx@kernel.org
> > ---
> >  man/man2/swapon.2 | 5 ++---
> >  1 file changed, 2 insertions(+), 3 deletions(-)
> >
> > diff --git a/man/man2/swapon.2 b/man/man2/swapon.2
> > index df5e8d8c7ec6..20e213827733 100644
> > --- a/man/man2/swapon.2
> > +++ b/man/man2/swapon.2
> > @@ -60,9 +60,8 @@ These functions may be used only by a privileged process (one having the
> >  capability).
> >  .SS Priority
> >  Each swap area has a priority, either high or low.
> > -The default priority is low.
> > -Within the low-priority areas,
> > -newer areas are even lower priority than older areas.
> > +The default priority is the lowest,
> > +and all default areas share the same priority value, -1.
> 
> Not sure what “default areas” means.
> maybe just the below?
> "
> Areas that are not assigned a priority will receive the default priority of -1.
> "

Sounds good to me. I will spin v3 to include the update. Thanks for the
great suggesiton.

Re: [PATCH v2] iman/man2/swapon.2: update priority section

[Alejandro Colomar]

[-- Attachment #1: Type: text/plain, Size: 3097 bytes --]

Hi Baoquan, Barry,

On Mon, Oct 20, 2025 at 09:09:20PM +0800, Baoquan He wrote:
> On 10/20/25 at 05:21pm, Barry Song wrote:
> > On Mon, Oct 20, 2025 at 6:56 AM Baoquan He <bhe@redhat.com> wrote:
> > >
> > > This update the description about default priority value which is
> > > changed in kernel.
> > 
> > Thanks for sending this. Would it be possible to include a reference to
> > the related commit — for example, at least the commit subject? Also,
> > does the man page prefer using a link to the kernel patchset?
> 
> I see a lot of discussion link is provided in man-pages commit log, and
> haven't seen a kernel commit. But I see kernel version is mentioned to
> mark since when the man page update is made. It's the first time I
> update man page, not sure what is better. Would love to hear suggestions
> to improve. Thanks. 
> 
> https://git.kernel.org/pub/scm/docs/man-pages/man-pages.git

Feel free to add as much information in the commit message as you want.
I'm always able to remove or edit something if I don't want it, but in
general, the more information you include, the better.  Thanks!


Have a lovely day!
Alex

> 
> 
> commit 8982bb673546d95b34f7c35be8cadd8091de2a25
> Author: Thiago Jung Bauermann <thiago.bauermann@linaro.org>
> Date:   Tue Sep 9 16:13:57 2025 -0300
> 
>     man/man2/sigaction.2: Update si_code list with Linux v6.16
>     
>     Update with missing si_code values from Linux v6.16's
>     "include/uapi/asm-generic/siginfo.h".
>     
>     Signed-off-by: Thiago Jung Bauermann <thiago.bauermann@linaro.org>
>     Message-ID: <20250909191357.44951-1-thiago.bauermann@linaro.org>
>     Reviewed-by: Carlos O'Donell <carlos@redhat.com>
>     Signed-off-by: Alejandro Colomar <alx@kernel.org>
> 
> > 
> > >
> > > Link: https://lore.kernel.org/all/20251011081624.224202-1-bhe@redhat.com/
> > > Signed-off-by: Baoquan He <bhe@redhat.com>
> > > Cc: chrisl@kernel.org
> > > Cc: baohua@kernel.org
> > > Cc: alx@kernel.org
> > > ---
> > >  man/man2/swapon.2 | 5 ++---
> > >  1 file changed, 2 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/man/man2/swapon.2 b/man/man2/swapon.2
> > > index df5e8d8c7ec6..20e213827733 100644
> > > --- a/man/man2/swapon.2
> > > +++ b/man/man2/swapon.2
> > > @@ -60,9 +60,8 @@ These functions may be used only by a privileged process (one having the
> > >  capability).
> > >  .SS Priority
> > >  Each swap area has a priority, either high or low.
> > > -The default priority is low.
> > > -Within the low-priority areas,
> > > -newer areas are even lower priority than older areas.
> > > +The default priority is the lowest,
> > > +and all default areas share the same priority value, -1.
> > 
> > Not sure what “default areas” means.
> > maybe just the below?
> > "
> > Areas that are not assigned a priority will receive the default priority of -1.
> > "
> 
> Sounds good to me. I will spin v3 to include the update. Thanks for the
> great suggesiton.
> 

-- 
<https://www.alejandro-colomar.es>
Use port 80 (that is, <...:80/>).

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]