Re: [PATCH v2 0/2] userfaultfd.2: Update to latest

[Alejandro Colomar <alx.manpages@gmail.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1223 bytes --]

Hi Jakub!

On 6/7/22 11:17, Jakub Wilk wrote:
> * G. Branden Robinson <g.branden.robinson@gmail.com>, 2022-06-06, 16:33:
>> At 2022-06-06T15:40:08-0400, Peter Xu wrote:
>>>> I think the patch below would improve a little bit the wording (and 
>>>> newlines).  I still have a bit of trouble understanding "When a 
>>>> kernel-originated fault was triggered on the registered range with 
>>>> this userfaultfd".  Did you maybe mean "range registered" instead of 
>>>> "registered range"?
>>>
>>> Since I'm not a native speaker I don't immediately see the difference 
>>> between the two.
>>
>> Short answer: I think your existing wording is acceptable.
> 
> I think you missed the context. You get a different parse tree when you 
> swap the words:
> 
>    ...triggered (on the registered range) (with this userfaultfd).
> 
> vs
> 
>    ...triggered (on the range (registered with this userfaultfd)).
> 

Thanks, that's a very nice way to show it!  It may help Peter too. 
Basically, the places where you can parenthesize sentences as if they 
were mathematical expressions is where lines breaks should go :)


Cheers,

Alex

-- 
Alejandro Colomar
<http://www.alejandro-colomar.es/>

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]