Re: [PATCH] capget.2, execve.2, readv.2, socketpair.2, utime.2, utimensat.2, getloadavg.3, proc.5, mount_namespaces.7, unix.7: ffix

["Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>]

Hi Alex,

On 11/20/20 10:55 PM, Alejandro Colomar (man-pages) wrote:
> Hi Michael,
> 
> As you said in other patches about global changes,
> I completely agree in that such changes,
> if automated in scripts,
> are very dangerous.
> 
> That said, yes, internally there's something in my head
> telling me to do such changes when I see them.
> 
> And yes, one good reason to fix them is that consistency
> simplifies scripting a lot.
> 
> So I tend to slowly fix some of them
> as I see them while fixing similar things.
> But I try not to add so many of those fixes that
> I would distract from the main fix.
> 
> The rationale for why some an not other fixes in this specific case:
> I first grepped to find the files the files that contained
> {.IR var [x]}:
> $ grep -rn "^\.I[ |R].* \\[.*\\]" |sort
> (BTW, I forgot to add that script to the commit msg,
> I'll add it in the next version).
> 
> And then inside the file I ctrl+F'd '[' to find them.
> That showed me a few more lines than I searched for,
> and found a few more fixes to do.
> They weren't completely unrelated,
> so I added them to the same patch.
> That's why I only changed some of:
>>> -(26) \fIstartcode\fP \ %lu \ [PT]
>>> +.RI "(26) " startcode "  %lu  [PT]"
> They showed up while finding branckets.
> 
> However... if you feel that's still too much for a patch,
> I completely understand it, so I can separate the changes.

It is too much :-).

> Please, tell me your thoughts.

Please, let's just start off with one patch that implements
your original idea: {.IR var [x]} -> {.I var[x]}. Then we can
discuss other changes.

Cheers,

Michael


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/