public inbox for linux-man@vger.kernel.org
 help / color / mirror / Atom feed
From: "Alejandro Colomar (man-pages)" <alx.manpages@gmail.com>
To: "G. Branden Robinson" <g.branden.robinson@gmail.com>
Cc: "Pali Rohár" <pali@kernel.org>,
	linux-man@vger.kernel.org,
	"Michael Kerrisk" <mtk.manpages@gmail.com>
Subject: Re: [PATCH] termios.3: Add information how to set baudrate to any other value
Date: Sat, 31 Jul 2021 13:24:47 +0200	[thread overview]
Message-ID: <2ce98cb8-8bba-8972-22cf-ce69760fa125@gmail.com> (raw)
In-Reply-To: <20210731015043.zbdab35mm36nfwsc@localhost.localdomain>

Hi Branden,

On 7/31/21 3:50 AM, G. Branden Robinson wrote:
> Hi, Pali & Alex!
> 
> At 2021-07-30T20:29:24+0200, Alejandro Colomar (man-pages) wrote:
>>>    for the speeds beyond those defined in POSIX.1 (57600 and above).
>>>    Thus, \fBB57600\fP & \fBCBAUDEX\fP is nonzero.
>>
>> I think this should go on a separate paragraph, don't you?
> 
> I would line break after the comma, quote the multiword literal in case
> the bold attribute gets stripped out of the output (copying and
> pasting man page text into emails, for instance), and use font style
> macros instead of font selection escape sequences.

I would too, but that was already existing text that was out of the 
scope of this patch :/

> 
>> .PP?
>>
>>> +Setting baudrate to other value than defined by
>>
>> wfix?:
>>
>> Setting the baud rate to a value other that those defined by
> 
> I'd say "baud rate" as two words in English prose (contrast with C), but
> "than" is correct.

Ouch!  I meant "than"; "that" was a typo that I introduced.  As I 
already applied the patch, I'll fix it myself in my tree before sending 
it to Michael.

Thanks,

Alex

> 
>>> +.B Bnnn
>>> +constants is possible via
>>
>> s/via/via the/?
> 
> I agree.
> 
>>
>>> +.B TCSETS2
>>> +ioctl, see
>>
>> s/,/;/
> 
> I agree.  Comma splices are evil.
> 
> Incidentally, when checking for semantic newline issues, I use the
> following search pattern in Vim.
> 
> /[.;:].
> 
> Strictly, I should say
> 
> /[.;:!?][^\\]
> 
> and were to bind that to a key, that's probably what I'd use.
> 
> Regards,
> Branden
> 


-- 
Alejandro Colomar
Linux man-pages comaintainer; https://www.kernel.org/doc/man-pages/
http://www.alejandro-colomar.es/

  reply	other threads:[~2021-07-31 11:24 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-30 15:30 [PATCH] termios.3: Add information how to set baudrate to any other value Pali Rohár
2021-07-30 18:29 ` Alejandro Colomar (man-pages)
2021-07-31  1:50   ` G. Branden Robinson
2021-07-31 11:24     ` Alejandro Colomar (man-pages) [this message]
2021-07-30 18:45 ` [PATCH v2] termios.3: Add information how to set baud rate " Pali Rohár
2021-07-30 18:59   ` Alejandro Colomar (man-pages)
2021-07-31  0:19   ` G. Branden Robinson
2021-07-31 11:04     ` Alejandro Colomar (man-pages)
2021-07-31 11:06       ` Pali Rohár
2021-08-01 11:07         ` Alejandro Colomar (man-pages)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2ce98cb8-8bba-8972-22cf-ce69760fa125@gmail.com \
    --to=alx.manpages@gmail.com \
    --cc=g.branden.robinson@gmail.com \
    --cc=linux-man@vger.kernel.org \
    --cc=mtk.manpages@gmail.com \
    --cc=pali@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox