From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6D91C001DE for ; Mon, 31 Jul 2023 20:38:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230136AbjGaUi6 (ORCPT ); Mon, 31 Jul 2023 16:38:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56312 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229550AbjGaUi4 (ORCPT ); Mon, 31 Jul 2023 16:38:56 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 091F8198 for ; Mon, 31 Jul 2023 13:38:56 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 98057612D8 for ; Mon, 31 Jul 2023 20:38:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 70EF9C433C8; Mon, 31 Jul 2023 20:38:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690835935; bh=Cp4vFCPUcVDzGjm6/9nJCOXUQy3BdWH9wvp67BFBJJ0=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=YtH9arvPfMDmo0DMC6n+k+apxneJv/58iSTUEAlaEBJ9drzhyt4ShNenLhFVWjajZ JZHIFnHsyI9Qydm2PI1jtmAAPAiAoopxkmM2ilZ9YOH9nwBJVKczwzeIfd9P9FmQab q282z5PgEeu2+C3I8z1jV5TrypsGlxNOn64QcTIM5lEbgyH/eGvMelFfqzOL33iuZh X9JmXV022Fiolzm1v6ED0Z8Xg5m7YWbW62E4gQBFDVgy/PFFsYeO4IvlLmWorB6ZhR FEusxg0TguPK962qmIP8N2o2+S3hfQjAmrmJbVzodnYvoQTho3bvbbgZ/Cj1GbhjVI F3me8GFSsnIOA== Message-ID: <2fe7d79d-9fdb-4a99-1e4e-c7e847ec542b@kernel.org> Date: Mon, 31 Jul 2023 22:38:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: [PATCH v3] man*/: srcfix Content-Language: en-US To: "G. Branden Robinson" Cc: linux-man@vger.kernel.org References: <20230731174836.5e3fxxe6csgitm4s@illithid> <45228b33-b6c5-a7c8-e1d3-00cdb18829f7@kernel.org> <20230731201934.gjskg73p2k33q52d@illithid> From: Alejandro Colomar Organization: Linux In-Reply-To: <20230731201934.gjskg73p2k33q52d@illithid> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------TJyPFUcB0PbzQbeL08ibtmii" Precedence: bulk List-ID: X-Mailing-List: linux-man@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------TJyPFUcB0PbzQbeL08ibtmii Content-Type: multipart/mixed; boundary="------------ZkkcHjbqxnsFd15O9iPnm0EM"; protected-headers="v1" From: Alejandro Colomar To: "G. Branden Robinson" Cc: linux-man@vger.kernel.org Message-ID: <2fe7d79d-9fdb-4a99-1e4e-c7e847ec542b@kernel.org> Subject: Re: [PATCH v3] man*/: srcfix References: <20230731174836.5e3fxxe6csgitm4s@illithid> <45228b33-b6c5-a7c8-e1d3-00cdb18829f7@kernel.org> <20230731201934.gjskg73p2k33q52d@illithid> In-Reply-To: <20230731201934.gjskg73p2k33q52d@illithid> --------------ZkkcHjbqxnsFd15O9iPnm0EM Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi Branden, On 2023-07-31 22:19, G. Branden Robinson wrote: > Hi Alex, >=20 > At 2023-07-31T21:56:27+0200, Alejandro Colomar wrote: >> Is this that you'll do it in MR sed, or that you forgot to fix it? :D= >=20 > Yes, that's what I meant to indicate by the v3 annotation at the end of= > the mail. Ahh, I'll tell you my usual routine for reviewing patches, which will probably explain why I didn't notice: I first try to find the signature. If there's anything not generated by git(1) right below the "---" and before the list of files, I read that first (of course after the Subject) --that's where I would have expected your comment to go--. Then I may have a fast look at the patch before applying it, especially if I suspect I won't like it at a first glance. But if I trust the sender, I'll directly apply it; reading diffs in the email is not very pleasant, and git will color it nicely for me. And then I review the patch as applied. So, the only chance that I read personal messages like "This is just a resend" or "I didn't provide the diff; apply the attachment" is putting it there, right below the "---" that goes after your signature. That part is mostly ignored by git(1) --unless the content can be confused with a patch, I guess--. >=20 >>> v3: Resubmitted; no change. A revision to "MR.sed" handles this >>> case. Okay; your prerogative. Free Britney! :-} Cheers, Alex >=20 > Regards, > Branden --=20 GPG key fingerprint: A9348594CE31283A826FBDD8D57633D441E25BB5 --------------ZkkcHjbqxnsFd15O9iPnm0EM-- --------------TJyPFUcB0PbzQbeL08ibtmii Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE6jqH8KTroDDkXfJAnowa+77/2zIFAmTIG9UACgkQnowa+77/ 2zJWXw/+K5GMX54jG49gba67MMQgqqy79MQMVkyGNNIqa2FAdn8Kw30jGysb0SRc QVxbR0rxNz0bwGOpHfWjZ3LyQm73a/LYhDS+ckeaBcxjR0Cojm+H8u9fNe2MlwSq fGVf21yvR7B7BWJJ/4C6SAYNh3yGWq0cfJ8cWYgBWEQNJYDmZzLSADqKvq3i0e4D 4UwFedII3HOv7tnw95lr36XEbRxtkPVhfer2+frCVYb+veAXXwJATpoaDFHxFQuA YCf3X3vHDHZvDrYtYygadW0OQ5ueCBM9zpjH6rUpfY/TfOoQ4a8XLOL/eU/vpZfm gNSCsR4jT6pVSrglM6KUWvns5imFSqhctgJ3YERQ0gOhV440nVe5F8Nn0j3y0hyj zW/W/TxzK1EVfAy2tdtEGTTEOmkcDDysPmff5UZ3/Pyzg3G4r6WNuIxtGjTDwaiL e1/4pfk3/1At7tAU6PYWq0KEh9KlO306somTPG7rg+Kesg4qB3YxdJBYCMSA368k acL+dg1kOmni6JVeGh+qKn8FTXdV4wEGYyi4HkWGiD4Am3IXQvUBJvErTnR0wfc9 v4UKVmZftbaL1p4qCQOG5zgBgjzkB2H5Kdu+VnyYRYQ7TOvM43ij6Oy5I23tEIFg oxQSx4PmxT3O0Q2ispA06Fg1OQA9G5n/HqjxVSm+zZqCOuasLeQ= =SwwY -----END PGP SIGNATURE----- --------------TJyPFUcB0PbzQbeL08ibtmii--