From: Mike Frysinger <vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>
To: mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Cc: linux-man <linux-man-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] crypt(3): use real dashes in regex
Date: Thu, 17 Apr 2014 15:55:20 -0400 [thread overview]
Message-ID: <3245891.ebzCqChYRm@vapier> (raw)
In-Reply-To: <CAKgNAkh4yU=nnEVoWA0g36bQovg6csR-ik54Z0FT3Q53Hrn8-g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 497 bytes --]
On Thu 17 Apr 2014 21:22:31 Michael Kerrisk wrote:
> On Thu, Apr 17, 2014 at 7:48 PM, Mike Frysinger wrote:
> > I don't think rendering the dashes in the regex expression as the en
> > style makes sense. This is a literal regex, so use literal dashes.
>
> I agree, but it looks like your patch is inconsistent. But you use
> '\-' in one part of the patch (right), and just '-' in the other part.
> How come?
i wrote the two hunks on different days. iiuc, they should all be \-.
-mike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-04-17 19:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-17 17:48 [PATCH] crypt(3): use real dashes in regex Mike Frysinger
[not found] ` <1397756918-16350-1-git-send-email-vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>
2014-04-17 19:22 ` Michael Kerrisk (man-pages)
[not found] ` <CAKgNAkh4yU=nnEVoWA0g36bQovg6csR-ik54Z0FT3Q53Hrn8-g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-04-17 19:55 ` Mike Frysinger [this message]
2014-04-17 20:09 ` Michael Kerrisk (man-pages)
2014-04-18 15:53 ` Michael Kerrisk (man-pages)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3245891.ebzCqChYRm@vapier \
--to=vapier-abrp7r+bbdudnm+yrofe0a@public.gmane.org \
--cc=linux-man-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).