[PATCH] crypt(3): use real dashes in regex

[PATCH] crypt(3): use real dashes in regex

[Mike Frysinger]

I don't think rendering the dashes in the regex expression as the en
style makes sense.  This is a literal regex, so use literal dashes.

Signed-off-by: Mike Frysinger <vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>
---
 man3/crypt.3 | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/man3/crypt.3 b/man3/crypt.3
index 9baa80a..453bcec 100644
--- a/man3/crypt.3
+++ b/man3/crypt.3
@@ -65,7 +65,7 @@ is a user's typed password.
 .PP
 .I salt
 is a two-character string chosen from the set
-[\fBa\fP\(en\fBzA\fP\(en\fBZ0\fP\(en\fB9./\fP].
+[\fBa\-zA\-Z0\-9./\fP].
 This string is used to
 perturb the algorithm in one of 4096 different ways.
 .PP
@@ -241,7 +241,7 @@ SHA-512 | 86 characters
 .TE
 
 The characters in "\fIsalt\fP" and "\fIencrypted\fP" are drawn from the set
-[\fBa\fP\(en\fBzA\fP\(en\fBZ0\fP\(en\fB9./\fP].
+[\fBa-zA-Z0-9./\fP].
 In the MD5 and SHA implementations the entire
 .I key
 is significant (instead of only the first
-- 
1.9.2

--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] crypt(3): use real dashes in regex

[Michael Kerrisk (man-pages)]

Mike,

On Thu, Apr 17, 2014 at 7:48 PM, Mike Frysinger <vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org> wrote:
> I don't think rendering the dashes in the regex expression as the en
> style makes sense.  This is a literal regex, so use literal dashes.

I agree, but it looks like your patch is inconsistent. But you use
'\-' in one part of the patch (right), and just '-' in the other part.
How come?

Cheers,

Michael

> Signed-off-by: Mike Frysinger <vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>
> ---
>  man3/crypt.3 | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/man3/crypt.3 b/man3/crypt.3
> index 9baa80a..453bcec 100644
> --- a/man3/crypt.3
> +++ b/man3/crypt.3
> @@ -65,7 +65,7 @@ is a user's typed password.
>  .PP
>  .I salt
>  is a two-character string chosen from the set
> -[\fBa\fP\(en\fBzA\fP\(en\fBZ0\fP\(en\fB9./\fP].
> +[\fBa\-zA\-Z0\-9./\fP].
>  This string is used to
>  perturb the algorithm in one of 4096 different ways.
>  .PP
> @@ -241,7 +241,7 @@ SHA-512 | 86 characters
>  .TE
>
>  The characters in "\fIsalt\fP" and "\fIencrypted\fP" are drawn from the set
> -[\fBa\fP\(en\fBzA\fP\(en\fBZ0\fP\(en\fB9./\fP].
> +[\fBa-zA-Z0-9./\fP].
>  In the MD5 and SHA implementations the entire
>  .I key
>  is significant (instead of only the first
> --
> 1.9.2
>



-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] crypt(3): use real dashes in regex

[Mike Frysinger]

[-- Attachment #1: Type: text/plain, Size: 497 bytes --]

On Thu 17 Apr 2014 21:22:31 Michael Kerrisk wrote:
> On Thu, Apr 17, 2014 at 7:48 PM, Mike Frysinger wrote:
> > I don't think rendering the dashes in the regex expression as the en
> > style makes sense.  This is a literal regex, so use literal dashes.
> 
> I agree, but it looks like your patch is inconsistent. But you use
> '\-' in one part of the patch (right), and just '-' in the other part.
> How come?

i wrote the two hunks on different days.  iiuc, they should all be \-.
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH] crypt(3): use real dashes in regex

[Michael Kerrisk (man-pages)]

On Thu, Apr 17, 2014 at 9:55 PM, Mike Frysinger <vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org> wrote:
> On Thu 17 Apr 2014 21:22:31 Michael Kerrisk wrote:
>> On Thu, Apr 17, 2014 at 7:48 PM, Mike Frysinger wrote:
>> > I don't think rendering the dashes in the regex expression as the en
>> > style makes sense.  This is a literal regex, so use literal dashes.
>>
>> I agree, but it looks like your patch is inconsistent. But you use
>> '\-' in one part of the patch (right), and just '-' in the other part.
>> How come?
>
> i wrote the two hunks on different days.  iiuc, they should all be \-.

:-) Okay -- I'll fix.


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] crypt(3): use real dashes in regex

[Michael Kerrisk (man-pages)]

On 04/17/2014 09:55 PM, Mike Frysinger wrote:
> On Thu 17 Apr 2014 21:22:31 Michael Kerrisk wrote:
>> On Thu, Apr 17, 2014 at 7:48 PM, Mike Frysinger wrote:
>>> I don't think rendering the dashes in the regex expression as the en
>>> style makes sense.  This is a literal regex, so use literal dashes.
>>
>> I agree, but it looks like your patch is inconsistent. But you use
>> '\-' in one part of the patch (right), and just '-' in the other part.
>> How come?
> 
> i wrote the two hunks on different days.  iiuc, they should all be \-.

Applied (and fixed, as discussed).

Thanks, Mike.

Cheers,

Michael



-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html