From: "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>
To: Alejandro Colomar <colomar.6.4.3@gmail.com>
Cc: mtk.manpages@gmail.com, linux-man@vger.kernel.org
Subject: Re: [PATCH 04/12] getgrent_r.3: Cast 'gid_t' to 'intmax_t' for printf()
Date: Sun, 13 Sep 2020 08:01:55 +0200 [thread overview]
Message-ID: <379ab003-0407-e11c-e3ed-bed3595ef2cc@gmail.com> (raw)
In-Reply-To: <20200911231411.28406-5-colomar.6.4.3@gmail.com>
Hi Alex,
See my reply to patch 05.
Thanks,
Michael
On 9/12/20 1:14 AM, Alejandro Colomar wrote:
> Signed-off-by: Alejandro Colomar <colomar.6.4.3@gmail.com>
> ---
> man3/getgrent_r.3 | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/man3/getgrent_r.3 b/man3/getgrent_r.3
> index 76deec370..8170cd417 100644
> --- a/man3/getgrent_r.3
> +++ b/man3/getgrent_r.3
> @@ -174,6 +174,7 @@ in the stream with all other threads.
> #define _GNU_SOURCE
> #include <grp.h>
> #include <stdio.h>
> +#include <stdint.h>
> #include <stdlib.h>
> #define BUFLEN 4096
>
> @@ -189,7 +190,7 @@ main(void)
> i = getgrent_r(&grp, buf, sizeof(buf), &grpp);
> if (i)
> break;
> - printf("%s (%d):", grpp\->gr_name, grpp\->gr_gid);
> + printf("%s (%jd):", grpp\->gr_name, (intmax_t) grpp\->gr_gid);
> for (int j = 0; ; j++) {
> if (grpp\->gr_mem[j] == NULL)
> break;
>
--
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
next prev parent reply other threads:[~2020-09-13 6:02 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-11 23:14 [PATCH 00/12] printf() fixes Alejandro Colomar
2020-09-11 23:14 ` [PATCH 01/12] dl_iterate_phdr.3: Cast 'ElfN_Word' to 'uintmax_t' for printf() Alejandro Colomar
2020-09-12 5:52 ` Jakub Wilk
2020-09-12 8:31 ` Alejandro Colomar
2020-09-15 7:35 ` Jakub Wilk
2020-09-15 9:27 ` Alejandro Colomar
2020-09-11 23:14 ` [PATCH 02/12] malloc_hook.3: Remove unneeded cast, and print 'size_t' with "%zu" Alejandro Colomar
2020-09-13 5:46 ` Michael Kerrisk (man-pages)
2020-09-11 23:14 ` [PATCH 03/12] pthread_getcpuclockid.3: Cast 'time_t' to 'intmax_t' for printf() Alejandro Colomar
2020-09-13 5:58 ` Michael Kerrisk (man-pages)
2020-09-13 6:05 ` Michael Kerrisk (man-pages)
2020-09-13 8:12 ` Alejandro Colomar
2020-09-13 12:04 ` Michael Kerrisk (man-pages)
2020-09-14 8:58 ` Jakub Wilk
2020-09-14 19:38 ` Michael Kerrisk (man-pages)
2020-09-11 23:14 ` [PATCH 04/12] getgrent_r.3: Cast 'gid_t' " Alejandro Colomar
2020-09-13 6:01 ` Michael Kerrisk (man-pages) [this message]
2020-09-11 23:14 ` [PATCH 05/12] getpwent_r.3: Cast 'uid_t' " Alejandro Colomar
2020-09-13 6:01 ` Michael Kerrisk (man-pages)
2020-09-13 8:28 ` Alejandro Colomar
2020-09-13 12:04 ` Michael Kerrisk (man-pages)
2020-09-13 13:28 ` Alejandro Colomar
2020-09-13 18:11 ` Alejandro Colomar
2020-09-11 23:14 ` [PATCH 06/12] rtld-audit.7: Use "%u" rather than "%d" when printing 'unsigned int' values Alejandro Colomar
2020-09-13 5:46 ` Michael Kerrisk (man-pages)
2020-09-11 23:14 ` [PATCH 07/12] userfaultfd.2: Use 'PRIx64' rather than "%llx" when printing 64-bit fixed-width types Alejandro Colomar
2020-09-13 5:51 ` Michael Kerrisk (man-pages)
2020-09-11 23:14 ` [PATCH 08/12] clock_getres.2: Cast 'time_t' to 'intmax_t' for printf() and fix the length modifiers Alejandro Colomar
2020-09-12 5:55 ` Jakub Wilk
2020-09-12 8:32 ` Alejandro Colomar
2020-09-12 10:06 ` [PATCH v2 08/12] clock_getres.2: Cast 'time_t' very small,values to 'int' " Alejandro Colomar
2020-09-13 6:05 ` Michael Kerrisk (man-pages)
2020-09-14 9:11 ` Jakub Wilk
2020-09-14 9:48 ` Alejandro Colomar
2020-09-11 23:14 ` [PATCH 09/12] open_by_handle_at.2: Use "%u" rather than "%d" when printing 'unsigned int' values Alejandro Colomar
2020-09-13 5:46 ` Michael Kerrisk (man-pages)
2020-09-11 23:14 ` [PATCH 10/12] spu_run.2: Cast 'int' to 'unsigned int' when printing with "%x" Alejandro Colomar
2020-09-12 10:29 ` Alejandro Colomar
2020-09-13 5:54 ` Michael Kerrisk (man-pages)
2020-09-11 23:14 ` [PATCH 11/12] mprotect.2: Use "%p" rather than casting to 'long' when printing adresses (pointer values) Alejandro Colomar
2020-09-13 5:46 ` Michael Kerrisk (man-pages)
2020-09-11 23:14 ` [PATCH 12/12] pidfd_open.2: Cast 'short' to 'unsigned int' when printing with "%x" Alejandro Colomar
2020-09-13 5:55 ` Michael Kerrisk (man-pages)
2020-09-13 8:06 ` Alejandro Colomar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=379ab003-0407-e11c-e3ed-bed3595ef2cc@gmail.com \
--to=mtk.manpages@gmail.com \
--cc=colomar.6.4.3@gmail.com \
--cc=linux-man@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox