Re: make html: Errors

["Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>]

Hi Alex,

On 2/15/21 10:11 PM, Alejandro Colomar (man-pages) wrote:
> Hi Michael,
> 
> I tried to render HTML pages with the Makefile.
> I had some errors, even though the operation succeed (I have the
> resulting HTML files, and the contents look good in the browser.
> Has it happened to you before?  Do you know how to solve it?
> I copied here the full error messages, in case it is useful.

There's a bug in the script, it seems. Not all of the pages
were being correctly processed. In particular, link pages
(".so dir/page.n") were not being correctly handled. I think
the patch below fixes things. Can you test and confirm?

> I guess this is what you use for generating the online pages, isn't it?

No, which is why I never noticed the bug. I suspect hardly anyone
tried "make html" for a very long time.

Cheers,

Michael


diff --git a/Makefile b/Makefile
index 328418e8e..ea31eab80 100644
--- a/Makefile
+++ b/Makefile
@@ -17,7 +17,7 @@ html:
        for i in man?; do \
                [ -d $(HTDIR)/"$$i" ] || mkdir -p $(HTDIR)/"$$i"; \
                find "$$i/" -type f | while read f; do \
-                       (cd "$$i"; man2html $(HTOPTS) `basename $$f`) | \
+                       man2html $(HTOPTS) $$f | \
                        sed -e '1,2d' > $(HTDIR)/"$$i"/`basename $$f`.html; \
                done; \
        done; fi