Re: [PATCH] quotactl.2: Remove kernel version for Q_XQUOTARM ioctl

["Alejandro Colomar (man-pages)" <alx.manpages@gmail.com>]

[CC += Jan]

Hi Yang,

On 11/3/21 10:29, xuyang2018.jy@fujitsu.com wrote:
> [Fix Alejandro mail address ]
>> Hi Alejandro
>>
>> You merged another quotactl patch, but I guess you missed this.

Thanks!

>>
>>
>> Best Regards
>> Yang Xu
>>> Hi Alejandro, Michael
>>>
>>> Ping!
>>>
>>> Best Regards
>>> Yang Xu
>>>> This patch[1] is designed to fix bug for Q_XQUOTARM ioctl not for introduced.
>>>> So remove it.
>>>>
>>>> [1]https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=9da93f9b7c
>>>>
>>>> Signed-off-by: Yang Xu<xuyang2018.jy@fujitsu.com>
>>>> ---
>>>>      man2/quotactl.2 | 3 +--
>>>>      1 file changed, 1 insertion(+), 2 deletions(-)
>>>>
>>>> diff --git a/man2/quotactl.2 b/man2/quotactl.2
>>>> index d22d8c584..46f77a8b1 100644
>>>> --- a/man2/quotactl.2
>>>> +++ b/man2/quotactl.2
>>>> @@ -651,8 +651,7 @@ The
>>>>      .I id
>>>>      argument is ignored.
>>>>      .TP
>>>> -.B Q_XQUOTARM " (since Linux 3.16)"
>>>> -.\" 9da93f9b7cdf8ab28da6b364cdc1fafc8670b4dc

Okay.  Since you added that line (man-pages commit ae848b1d80), I'm fine 
removing it.  Was it a mistake?  The commit message of that commit is a 
bit unrelated to Q_XQUOTARM, isn't it?

Maybe a better fix would be to replace the kernel version and the commit 
hash when it was really added?

I'll wait for your answer before applying the patch.

Thanks,

Alex

>>>> +.B Q_XQUOTARM
>>>>      Free the disk space taken by disk quotas.
>>>>      The
>>>>      .I addr


-- 
Alejandro Colomar
Linux man-pages comaintainer; https://www.kernel.org/doc/man-pages/
http://www.alejandro-colomar.es/