Re: [PATCH] Fit line in 80 columns

[Alejandro Colomar <alx.manpages@gmail.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1452 bytes --]

Hi Andrii and Alexei,

On 8/25/22 23:36, Andrii Nakryiko wrote:
> On Thu, Aug 25, 2022 at 11:07 AM Alexei Starovoitov
> <alexei.starovoitov@gmail.com> wrote:
>>
>> On Thu, Aug 25, 2022 at 11:02 AM Alejandro Colomar
>> <alx.manpages@gmail.com> wrote:
>>>
>>> That line is used to generate the bpf-helpers(7) manual page.  It
>>> is a no-fill line, since it represents a command, which means that
>>> the formatter can't break the line, and instead just runs across
>>> the right margin (in most set-ups this means that the pager will
>>> break the line).
>>>
>>> Using <fmt> makes it end exactly at the 80-col right margin, both
>>> in the header file, and also in the manual page, and also seems to
>>> be a sensible name.
>>
>> Nack.
>>
>> We don't follow 80 char limit and are not going to because of man pages.
> 
> And it's questionable in general to enforce line length for verbatim
> (code) block. It's verbatim for a good reason, it can't be wrapped.

That's why instead of wrapping, I reduced the length of some 
"identifier".  It's not enforced, but it's nicer if it fits.  There are 
several other cases, where it wasn't easy to make it shorter, and I left 
it exceeding the margin.

It's not so crucial to fix it, and if you prefer it like it is 
currently, it's reasonable.  This is a suggestion, to make it easier to 
read.

Cheers,

Alex

-- 
Alejandro Colomar
<http://www.alejandro-colomar.es/>

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]