From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DE0BC28D13 for ; Thu, 25 Aug 2022 14:48:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242119AbiHYOs1 (ORCPT ); Thu, 25 Aug 2022 10:48:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59630 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241031AbiHYOs0 (ORCPT ); Thu, 25 Aug 2022 10:48:26 -0400 Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [IPv6:2a00:1450:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4DA9CB2862 for ; Thu, 25 Aug 2022 07:48:23 -0700 (PDT) Received: by mail-wr1-x42e.google.com with SMTP id k9so24949496wri.0 for ; Thu, 25 Aug 2022 07:48:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=isovalent-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=U/GqjYthhXwTB8d2nbTjdjFeNP6i46d9zfH+EicQPvI=; b=eF4/mm/uB3JTA2iq0IVbizRpuzK7DuzbrTrjAzs9IKBHwQymK0eHz/Is2D+RY6pjiB z9rSwPibELLIQpmL6lE6bIFe1NXw0Eu0GXqJRwocCGAFz8qfPXFwQGlMjd9v9x0PGZZb P5CN1ech5mMNBNgZvWiHG+wNzRMMWuidaa+oMIVCeZQypWR/chn14EJCcOHCbNEX7muG WczEobh60Z12NepwCC5zizgN5hjOV/oROQ1J/mkXwXVu9UpxnJpGc1OHYf5LZdOy4PB3 6U0EEAtChQAStuR1/4642udiTV3tDGWYN8rTpb8kqPA2CNl/Zha4WJ6ZafRdetzJmS3X PBcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=U/GqjYthhXwTB8d2nbTjdjFeNP6i46d9zfH+EicQPvI=; b=jcGmkAsEW7r0tDnLdnz7+CPgX1xtObhlDdVm0/RLZ8ZrQdIeUtuGo/jqNO+hueLjOy K9HdEye2QRwhLgjItwOBCtslkGUcbYmGryAUdMKumfC1OZlnABaSjW1CY1o7yndYLUWV umISF09EQZ0/ehU7WSt29vzBqXA8GYb6UkwW+qG+A/gAQG0LmfqHL3y0T4491EU2r5Us 0416qdvkcVrNO1/SWGl+VhEPqNDZmBigDdLXqbwioTjLCRbZkJLEQFMmta2PXsgSraGQ UXegb6E+TPQUAagZWX9khE3tFkTUf0PmjakkM/9i1v+VVSKw8PgH8mx4Doy/4y0jhMLE 26yA== X-Gm-Message-State: ACgBeo3TXfbOvWw1XcHSxcjx+uLnU+YDlQmEy26BZIM++1cGeIjw234+ rL9qTm+nrYeb9s3M00Xyi/yj7+uyAzqm9Q== X-Google-Smtp-Source: AA6agR5JOgx2M/L9Gb/I+71ARDJk53g6gF/fFXvk5I/ZVIq8KgWVHdZil7Ch17kYew7LJndc5fU/wA== X-Received: by 2002:a5d:6245:0:b0:225:3e24:e5b1 with SMTP id m5-20020a5d6245000000b002253e24e5b1mr2597594wrv.698.1661438901749; Thu, 25 Aug 2022 07:48:21 -0700 (PDT) Received: from [192.168.178.32] ([51.155.200.13]) by smtp.gmail.com with ESMTPSA id p19-20020a05600c359300b003a6125562e1sm5723694wmq.46.2022.08.25.07.48.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 Aug 2022 07:48:21 -0700 (PDT) Message-ID: <40a62a75-1548-88ff-e536-dcbf3350db01@isovalent.com> Date: Thu, 25 Aug 2022 15:48:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.1.2 Subject: Re: [PATCH bpf-next v2] bpf: Fix a few typos in BPF helpers documentation Content-Language: en-GB To: Jakub Wilk Cc: Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , bpf@vger.kernel.org, Alejandro Colomar , Jesper Dangaard Brouer , linux-man@vger.kernel.org References: <20220825110216.53698-1-quentin@isovalent.com> <20220825142256.of3glbnwi77kgkzo@jwilk.net> From: Quentin Monnet In-Reply-To: <20220825142256.of3glbnwi77kgkzo@jwilk.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-man@vger.kernel.org On 25/08/2022 15:22, Jakub Wilk wrote: > * Quentin Monnet , 2022-08-25 12:02: >> --- a/tools/include/uapi/linux/bpf.h >> +++ b/tools/include/uapi/linux/bpf.h >> @@ -79,7 +79,7 @@ struct bpf_insn { >> /* Key of an a BPF_MAP_TYPE_LPM_TRIE entry */ >> struct bpf_lpm_trie_key { >>     __u32    prefixlen;    /* up to 32 for AF_INET, 128 for AF_INET6 */ >> -    __u8    data[0];    /* Arbitrary size */ >> +    __u8    data[];    /* Arbitrary size */ >> }; > > This hunk picks the change from 94dfc73e7cf4 ("treewide: uapi: Replace > zero-length arrays with flexible-array members"). > > A bit weird to see it in a spelling-fix patch though. Wouldn't it be > better to put it in a separate one? > This has happened several times in the past, and the change is small enough I thought it wouldn't matter much. I can send another version if it's more convenient, though. Quentin