Linux Manual Pages development
 help / color / mirror / Atom feed
From: Alejandro Colomar <colomar.6.4.3@gmail.com>
To: "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>
Cc: linux-man@vger.kernel.org, libc-alpha@sourceware.org
Subject: Re: [PATCH] getdents.2: SYNOPSIS: Add missing header and feature test macro
Date: Wed, 28 Oct 2020 23:00:30 +0100	[thread overview]
Message-ID: <4119a9b5-45bb-6133-837f-25d2dd09505a@gmail.com> (raw)
In-Reply-To: <fec2b038-4124-5fb7-0aec-b9bd9ce59c3b@gmail.com>



On 2020-10-28 22:21, Michael Kerrisk (man-pages) wrote:
 > Hello Alex,
 >
 > On 10/28/20 8:51 PM, Alejandro Colomar wrote:
 >> Signed-off-by: Alejandro Colomar <colomar.6.4.3@gmail.com>
 >
 > Thanks. Patch applied. But tweaked with a follow-on commit
 >
 >> ---
 >>   man2/getdents.2 | 4 ++++
 >>   1 file changed, 4 insertions(+)
 >>
 >> diff --git a/man2/getdents.2 b/man2/getdents.2
 >> index 02790b8f7..17904ed66 100644
 >> --- a/man2/getdents.2
 >> +++ b/man2/getdents.2
 >> @@ -35,6 +35,10 @@ getdents, getdents64 \- get directory entries
 >>   .nf
 >>   .BI "int getdents(unsigned int " fd ", struct linux_dirent *" dirp ,
 >>   .BI "             unsigned int " count );
 >> +.PP
 >> +.BR "#define _GNU_SOURCE" "        /* See feature_test_macros(7) */"
 >> +.BR "#include <dirent.h>" "        /* See NOTES */"
 >
 > I removed the piece "/* See NOTES */", since the NOTES don't
 > really explain the #include.

Hi Michael,

Fair enough.

Cheers,

Alex

      reply	other threads:[~2020-10-28 22:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-28 19:51 [PATCH] getdents.2: SYNOPSIS: Add missing header and feature test macro Alejandro Colomar
2020-10-28 21:21 ` Michael Kerrisk (man-pages)
2020-10-28 22:00   ` Alejandro Colomar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4119a9b5-45bb-6133-837f-25d2dd09505a@gmail.com \
    --to=colomar.6.4.3@gmail.com \
    --cc=libc-alpha@sourceware.org \
    --cc=linux-man@vger.kernel.org \
    --cc=mtk.manpages@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox