public inbox for linux-man@vger.kernel.org
 help / color / mirror / Atom feed
From: "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>
To: Alejandro Colomar <alx.manpages@gmail.com>
Cc: mtk.manpages@gmail.com, linux-man@vger.kernel.org
Subject: Re: [PATCH] delete_module.2: SYNOPSIS: Fix prototype parameter types
Date: Wed, 30 Dec 2020 23:36:37 +0100	[thread overview]
Message-ID: <45b040a9-35f3-e087-97ac-33ef25e9a37f@gmail.com> (raw)
In-Reply-To: <20201230214147.874671-3-alx.manpages@gmail.com>

Hi ALex,

On 12/30/20 10:41 PM, Alejandro Colomar wrote:
> The Linux kernel uses 'unsigned int' instead of 'int' for the
> 'flags' parameter.  As glibc provides no wrapper, use the same
> type the kernel uses> ......
> 
> $ syscall='delete_module';
> $ find linux/ -type f -name '*.c' \
>   |xargs pcregrep -Mn "(?s)^[\w_]*SYSCALL_DEFINE.\(${syscall},.*?\)";
> linux/kernel/module.c:977:
> SYSCALL_DEFINE2(delete_module, const char __user *, name_user,
> 		unsigned int, flags)
> 
> Signed-off-by: Alejandro Colomar <alx.manpages@gmail.com>

Thanks. Patch applied.

Cheers,

Michael

> ---
>  man2/delete_module.2 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/man2/delete_module.2 b/man2/delete_module.2
> index e63545d51..1030e9698 100644
> --- a/man2/delete_module.2
> +++ b/man2/delete_module.2
> @@ -27,7 +27,7 @@
>  delete_module \- unload a kernel module
>  .SH SYNOPSIS
>  .nf
> -.BI "int delete_module(const char *" name ", int " flags );
> +.BI "int delete_module(const char *" name ", unsigned int " flags );
>  .fi
>  .PP
>  .IR Note :
> 


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/

      reply	other threads:[~2020-12-30 22:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-30 21:41 [PATCH] delete_module.2: SYNOPSIS: Fix prototype parameter types Alejandro Colomar
2020-12-30 22:36 ` Michael Kerrisk (man-pages) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45b040a9-35f3-e087-97ac-33ef25e9a37f@gmail.com \
    --to=mtk.manpages@gmail.com \
    --cc=alx.manpages@gmail.com \
    --cc=linux-man@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox