public inbox for linux-man@vger.kernel.org
 help / color / mirror / Atom feed
From: Alejandro Colomar <alx.manpages@gmail.com>
To: Fotios Valasiadis <fvalasiad@gmail.com>, linux-man@vger.kernel.org
Cc: ldv@strace.io, mtk.manpages@gmail.com, lineprinter0@gmail.com,
	Nate Eldredge <nate@thatsmathematics.com>,
	Alejandro Colomar <alx@kernel.org>
Subject: Re: [PATCH] ptrace.2: Add details about usage of PTRACE_GET_SYSCALL_INFO
Date: Wed, 1 Mar 2023 22:00:01 +0100	[thread overview]
Message-ID: <472f9e40-7259-e7a5-ce5b-c462037cda68@gmail.com> (raw)
In-Reply-To: <20230227191731.15069-1-fvalasiad@gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 2394 bytes --]

Hi Fotios,

On 2/27/23 20:19, Φώτης Βαλασιάδης wrote:
> Hi Alex!
> 
> Is that good enough?
> 

Yep.  Patch applied.  Thanks!

Alex

On 2/27/23 20:17, Fotios Valasiadis wrote:
> Document the role of PTRACE_O_TRACESYSGOOD option in connection with
> PTRACE_GET_SYSCALL_INFO.
> 
> Came upon this after writing a test program using PTRACE_GET_SYSCALL_INFO.
> After failing to find what's wrong I posted a StackOverflow question
> which you can find right here:
> <https://stackoverflow.com/questions/72410182/ptrace-get-syscall-info-always-returns-info-op-as-ptrace-syscall-info-none>
> 
> Nate Eldredge found out what happens by looking into the kernel's source
> code, here is a link to the relevant part
> <https://github.com/torvalds/linux/blob/8291eaafed36f575f23951f3ce18407f480e9ecf/kernel/ptrace.c#L1018>
> 
> In the code it can be seen that in case of system call entry or
> exit stops, the union is filled if and only if the signal matches
> "SIGTRAP | 0x80", a signal which is only sent if the PTRACE_O_TRACESYSGOOD
> option is set.  You can read about that in the PTRACE_O_TRACESYSGOOD
> section of ptrace(2)'s manual.
> 
> Complements: fc91449cb "ptrace.2: Document PTRACE_GET_SYSCALL_INFO"
> Cowritten-by: Dmitry V. Levin <ldv@strace.io>
> Signed-off-by: Dmitry V. Levin <ldv@strace.io>
> Signed-off-by: Fotios Valasiadis <fvalasiad@gmail.com>
> Acked-by: Nate Eldredge <nate@thatsmathematics.com>
> Cc: Elvira Khabirova <lineprinter0@gmail.com>
> Signed-off-by: Alejandro Colomar <alx@kernel.org>
> ---
>  man2/ptrace.2 | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/man2/ptrace.2 b/man2/ptrace.2
> index 55d9fd36d..9737b3825 100644
> --- a/man2/ptrace.2
> +++ b/man2/ptrace.2
> @@ -1111,6 +1111,15 @@ stop.
>  .B PTRACE_SYSCALL_INFO_NONE
>  No component of the union contains relevant information.
>  .RE
> +.IP
> +In case of system call entry or exit stops,
> +the data returned by
> +.B PTRACE_GET_SYSCALL_INFO
> +is limited to type
> +.B PTRACE_SYSCALL_INFO_NONE
> +unless
> +.B PTRACE_O_TRACESYSGOOD
> +option is set before the corresponding system call stop has occurred.
>  .\"
>  .SS Death under ptrace
>  When a (possibly multithreaded) process receives a killing signal

-- 
<http://www.alejandro-colomar.es/>
GPG key fingerprint: A9348594CE31283A826FBDD8D57633D441E25BB5

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  parent reply	other threads:[~2023-03-01 21:00 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-25 10:56 [PATCH] ptrace.2: Add details about usage of PTRACE_GET_SYSCALL_INFO Fotios Valasiadis
2023-02-26 21:58 ` Alejandro Colomar
2023-02-26 22:03   ` Dmitry V . Levin
2023-02-26 22:05     ` Alejandro Colomar
2023-02-26 22:14       ` Φώτης Βαλασιάδης
2023-02-26 22:42         ` Alejandro Colomar
2023-02-26 23:30           ` Φώτης Βαλασιάδης
2023-02-26 23:22 ` Fotios Valasiadis
2023-02-27  0:19   ` Alejandro Colomar
2023-02-27  0:41     ` Φώτης Βαλασιάδης
2023-02-27 13:28       ` Alejandro Colomar
2023-02-27 15:33         ` Dmitry V. Levin
2023-02-27 15:35           ` Alejandro Colomar
     [not found]             ` <b57591a9-5ba1-5192-f376-f2de812a9086@gmail.com>
2023-02-27 17:30               ` Fwd: " Φώτης Βαλασιάδης
2023-02-27 18:48               ` Alejandro Colomar
2023-02-27 19:17                 ` Fotios Valasiadis
2023-02-27 19:19                   ` Φώτης Βαλασιάδης
2023-03-01 19:28                     ` Φώτης Βαλασιάδης
2023-03-01 21:00                   ` Alejandro Colomar [this message]
  -- strict thread matches above, loose matches on Subject: below --
2023-02-25  2:42 Fotios Valasiadis
2023-02-25 10:10 ` Dmitry V . Levin
2023-02-25 10:33   ` Φώτης Βαλασιάδης
2023-02-25 10:42     ` Dmitry V . Levin
2023-02-24 16:31 Fotios Valasiadis
2023-02-24 18:53 ` Dmitry V. Levin
2023-02-24 19:11   ` Φώτης Βαλασιάδης
2023-02-24 22:05     ` Dmitry V. Levin
2023-02-24 23:05       ` Φώτης Βαλασιάδης
2023-02-24 23:31         ` Dmitry V. Levin
2023-02-24 23:43           ` Φώτης Βαλασιάδης
2023-02-25  0:08             ` Dmitry V. Levin
2023-02-25  1:21               ` Alex Colomar
2023-02-25  9:39                 ` Dmitry V. Levin
2023-02-25  1:18 ` Alex Colomar
2023-02-25  1:36   ` Φώτης Βαλασιάδης
2023-02-25  2:07   ` Nate Eldredge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=472f9e40-7259-e7a5-ce5b-c462037cda68@gmail.com \
    --to=alx.manpages@gmail.com \
    --cc=alx@kernel.org \
    --cc=fvalasiad@gmail.com \
    --cc=ldv@strace.io \
    --cc=lineprinter0@gmail.com \
    --cc=linux-man@vger.kernel.org \
    --cc=mtk.manpages@gmail.com \
    --cc=nate@thatsmathematics.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox