Re: [patch] mprotect.2: removal of EFAULT from mprotect man page

[Michael Kerrisk <mtk.manpages-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>]

Hi Maxin,

Maxin John wrote:
> Dear Michael,
> 
>               As per the discussion in linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, I
> am sending the patch for removal of EFAULT from mprotect.2 man page to
> the linux-man-u79uwXL29TY76Z2rM5mHXA@public.gmane.org mailing list.
> 
> Signed-off-by: Maxin B. John <maxin.john-qujY0cBTTHtBDgjK7y7TUQ@public.gmane.org>
> 
> 
> diff -Naur man-pages-3.05/man2/mprotect.2
> man-pages-3.05_modified/man2/mprotect.2
> --- man-pages-3.05/man2/mprotect.2      2008-07-23 19:42:13.000000000 +0530
> +++ man-pages-3.05_modified/man2/mprotect.2     2008-08-04
> 15:34:33.400869088 +0530
> @@ -87,9 +87,6 @@
>  to mark it
>  .BR PROT_WRITE .
>  .TP
> -.B EFAULT
> -The memory cannot be accessed.
> -.TP
>  .B EINVAL
>  \fIaddr\fP is not a valid pointer,
>  or not a multiple of the system page size.

As per the discussion at http://thread.gmane.org/gmane.linux.kernel/714574/,
I've actually made the change as shown below (for man-pages-3.07).  Seem
okay to you?

Cheers,

Michael


===================================================================
--- mprotect.2  (revision 3957)
+++ mprotect.2  (working copy)
@@ -87,9 +87,6 @@
  to mark it
  .BR PROT_WRITE .
  .TP
-.B EFAULT
-The memory cannot be accessed.
-.TP
  .B EINVAL
  \fIaddr\fP is not a valid pointer,
  or not a multiple of the system page size.
@@ -97,11 +94,16 @@
  .TP
  .B ENOMEM
  Internal kernel structures could not be allocated.
-Or: addresses in the range
+.TP
+.B ENOMEM
+Addresses in the range
  .RI [ addr ,
  .IR addr + len ]
  are invalid for the address space of the process,
  or specify one or more pages that are not mapped.
+(Before kernel 2.4.19, the error
+.BR EFAULT
+was incorrectly produced for these cases.)
  .SH "CONFORMING TO"
  SVr4, POSIX.1-2001.
  .\" SVr4 defines an additional error


--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html