From: Loic Domaigne <tech-Z4JMKDdsf89Wk0Htik3J/w@public.gmane.org>
To: mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Cc: linux-man-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
josv-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org,
"brian m. carlson"
<sandals-spVehEqlxw627WubY2PhZQivdfXVPZ6z@public.gmane.org>,
Bert Wesarg <bert.wesarg-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>,
Stefan Puiu <stefan.puiu-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Karsten Weiss
<K.Weiss-Pt+Xe7GJXK+P2YhJcF5u+nqWYbMAw+HU@public.gmane.org>
Subject: Re: For review: pthread_setaffinity_np.3
Date: Sat, 15 Nov 2008 20:41:05 +0100 [thread overview]
Message-ID: <491F25D1.8020007@domaigne.com> (raw)
In-Reply-To: <cfd18e0f0811140750r5a22255bx7bd53c580b42cc6-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
Hi Michael!
Looks good to me. I have only one minor comment left, regarding EINVAL
for pthread_setaffinity_np():
> .TP
> .BR EINVAL
> .RB ( pthread_setaffinity_np ())
> .I cpuset
> specified a CPU that was outside the set supported by the kernel.
> (The kernel configuration option
> .BR CONFIG_NR_CPUS
> defines the range of the set supported by the kernel data type
> .\" cpumask_t
> used to represent CPU sets.)
> .\" The raw sched_getaffinity() system call returns the size (in bytes)
> .\" of the cpumask_t type.
In the light of Bert's comment, it seems that the Linux kernel folks
wants to make the cpumask_t dynamic. So CONFIG_NR_CPUS might become
obsolete in the future...
But for now, your explanation is fine.
Cheers,
Loïc.
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2008-11-15 19:41 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-04 22:47 For review: pthread_setaffinity_np.3 Michael Kerrisk
[not found] ` <cfd18e0f0811041447w57dd5de4he68ca780ed963074-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-11-05 18:00 ` Bert Wesarg
[not found] ` <36ca99e90811051000j619ff316u8c836352627fe4a0-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-11-06 19:32 ` Michael Kerrisk
2008-11-08 22:31 ` Loic Domaigne
[not found] ` <4916133A.8060209-Z4JMKDdsf89Wk0Htik3J/w@public.gmane.org>
2008-11-10 18:38 ` Bert Wesarg
[not found] ` <36ca99e90811101038v62348fc0mbb366219168bf2ff-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-11-13 2:30 ` Michael Kerrisk
[not found] ` <cfd18e0f0811121830u3dc6ea30va0298bdbedf1f2fb-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-11-13 7:32 ` Bert Wesarg
2008-11-14 15:04 ` Michael Kerrisk
[not found] ` <cfd18e0f0811140704l18e5741fgdbb5a6c52fb8cbe7-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-11-14 15:38 ` Michael Kerrisk
[not found] ` <001636c5b6831e5a44045ba80779@googlemail.com>
[not found] ` <001636c5b6831e5a44045ba80779-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>
2008-11-14 15:45 ` Delivery Status Notification (Failure) Michael Kerrisk
[not found] ` <cfd18e0f0811140745k69075aend9686e463c9c1a4d-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-11-14 15:56 ` Bert Wesarg
[not found] ` <36ca99e90811140756q7c445d5ei7c31c5b59df7c7a7-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-11-14 16:02 ` Michael Kerrisk
[not found] ` <cfd18e0f0811140802i2c06e0am164648735fa7dda3-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-11-14 16:26 ` Christoph Lameter
[not found] ` <Pine.LNX.4.64.0811141026080.24886-dRBSpnHQED8AvxtiuMwx3w@public.gmane.org>
2008-11-14 16:39 ` Christoph Lameter
[not found] ` <Pine.LNX.4.64.0811141038510.25195-dRBSpnHQED8AvxtiuMwx3w@public.gmane.org>
2008-11-14 16:43 ` Michael Kerrisk
[not found] ` <cfd18e0f0811140843q42971316wfade996b67aa2a6-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-11-14 20:45 ` David Rientjes
[not found] ` <cfd18e0f0811140738i33f2c671kc99bbb7750f2fa44-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-11-14 15:52 ` For review: pthread_setaffinity_np.3 Bert Wesarg
[not found] ` <36ca99e90811140752t1c04f87do88926777d2be614a-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-11-14 16:04 ` Michael Kerrisk
2008-11-14 15:50 ` Michael Kerrisk
[not found] ` <cfd18e0f0811140750r5a22255bx7bd53c580b42cc6-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-11-15 19:41 ` Loic Domaigne [this message]
[not found] ` <491F25D1.8020007-Z4JMKDdsf89Wk0Htik3J/w@public.gmane.org>
2008-11-17 17:15 ` Michael Kerrisk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=491F25D1.8020007@domaigne.com \
--to=tech-z4jmkddsf89wk0htik3j/w@public.gmane.org \
--cc=K.Weiss-Pt+Xe7GJXK+P2YhJcF5u+nqWYbMAw+HU@public.gmane.org \
--cc=bert.wesarg-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org \
--cc=josv-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=linux-man-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=sandals-spVehEqlxw627WubY2PhZQivdfXVPZ6z@public.gmane.org \
--cc=stefan.puiu-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox