public inbox for linux-man@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] getpass.3: Add description of the function is not thread-safe
@ 2011-09-06  9:40 Peng Haitao
       [not found] ` <4E65EA98.6070807-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
  0 siblings, 1 reply; 2+ messages in thread
From: Peng Haitao @ 2011-09-06  9:40 UTC (permalink / raw)
  To: Michael Kerrisk; +Cc: linux-man-u79uwXL29TY76Z2rM5mHXA


The function getpass() uses a static variable "buf", so it is not thread-safe.

Signed-off-by: Peng Haitao <penght-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
---
 man3/getpass.3 |    7 ++++++-
 1 files changed, 6 insertions(+), 1 deletions(-)

diff --git a/man3/getpass.3 b/man3/getpass.3
index d363ec4..d07a323 100644
--- a/man3/getpass.3
+++ b/man3/getpass.3
@@ -20,7 +20,7 @@
 .\" Software Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111,
 .\" USA.
 .\"
-.TH GETPASS 3  2010-09-20 "Linux" "Linux Programmer's Manual"
+.TH GETPASS 3  2011-09-06 "Linux" "Linux Programmer's Manual"
 .SH NAME
 getpass \- get a password
 .SH SYNOPSIS
@@ -86,6 +86,11 @@ The process does not have a controlling terminal.
 .\" A
 .\" .BR getpass ()
 .\" function appeared in Version 7 AT&T UNIX.
+.SH ATTRIBUTES
+.SS Multithreading (see pthreads(7))
+The
+.BR getpass ()
+function is not thread-safe.
 .SH "CONFORMING TO"
 Present in SUSv2, but marked LEGACY.
 Removed in POSIX.1-2001.
-- 
1.7.1

-- 
Best Regards,
Peng Haitao

--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] getpass.3: Add description of the function is not thread-safe
       [not found] ` <4E65EA98.6070807-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
@ 2013-03-17 10:53   ` Michael Kerrisk (man-pages)
  0 siblings, 0 replies; 2+ messages in thread
From: Michael Kerrisk (man-pages) @ 2013-03-17 10:53 UTC (permalink / raw)
  To: Peng Haitao; +Cc: linux-man-u79uwXL29TY76Z2rM5mHXA

On Tue, Sep 6, 2011 at 11:40 AM, Peng Haitao <penght-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org> wrote:
>
> The function getpass() uses a static variable "buf", so it is not thread-safe.

Applied.

Thanks,

Michael


> Signed-off-by: Peng Haitao <penght-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
> ---
>  man3/getpass.3 |    7 ++++++-
>  1 files changed, 6 insertions(+), 1 deletions(-)
>
> diff --git a/man3/getpass.3 b/man3/getpass.3
> index d363ec4..d07a323 100644
> --- a/man3/getpass.3
> +++ b/man3/getpass.3
> @@ -20,7 +20,7 @@
>  .\" Software Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111,
>  .\" USA.
>  .\"
> -.TH GETPASS 3  2010-09-20 "Linux" "Linux Programmer's Manual"
> +.TH GETPASS 3  2011-09-06 "Linux" "Linux Programmer's Manual"
>  .SH NAME
>  getpass \- get a password
>  .SH SYNOPSIS
> @@ -86,6 +86,11 @@ The process does not have a controlling terminal.
>  .\" A
>  .\" .BR getpass ()
>  .\" function appeared in Version 7 AT&T UNIX.
> +.SH ATTRIBUTES
> +.SS Multithreading (see pthreads(7))
> +The
> +.BR getpass ()
> +function is not thread-safe.
>  .SH "CONFORMING TO"
>  Present in SUSv2, but marked LEGACY.
>  Removed in POSIX.1-2001.
> --
> 1.7.1
>
> --
> Best Regards,
> Peng Haitao
>



-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Author of "The Linux Programming Interface"; http://man7.org/tlpi/
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-03-17 10:53 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-06  9:40 [PATCH] getpass.3: Add description of the function is not thread-safe Peng Haitao
     [not found] ` <4E65EA98.6070807-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2013-03-17 10:53   ` Michael Kerrisk (man-pages)

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox