public inbox for linux-man@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] getpwnam.3: Add description of the functions are not thread-safe
@ 2011-09-15  8:34 Peng Haitao
       [not found] ` <4E71B895.704-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
  0 siblings, 1 reply; 2+ messages in thread
From: Peng Haitao @ 2011-09-15  8:34 UTC (permalink / raw)
  To: Michael Kerrisk; +Cc: linux-man-u79uwXL29TY76Z2rM5mHXA


The functions getpwnam() and getpwuid() return a pointer to a static area which
is overwritten by a subsequent call to them. So they are thread-unsafe.

Signed-off-by: Peng Haitao <penght-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
---
 man3/getpwnam.3 |   15 ++++++++++++++-
 1 files changed, 14 insertions(+), 1 deletions(-)

diff --git a/man3/getpwnam.3 b/man3/getpwnam.3
index 649da01..679477d 100644
--- a/man3/getpwnam.3
+++ b/man3/getpwnam.3
@@ -32,7 +32,7 @@
 .\" Modified 2003-11-15 by aeb
 .\" 2008-11-07, mtk, Added an example program for getpwnam_r().
 .\"
-.TH GETPWNAM 3  2010-10-21 "GNU" "Linux Programmer's Manual"
+.TH GETPWNAM 3  2011-09-15 "GNU" "Linux Programmer's Manual"
 .SH NAME
 getpwnam, getpwnam_r, getpwuid, getpwuid_r \- get password file entry
 .SH SYNOPSIS
@@ -206,6 +206,19 @@ Insufficient buffer space supplied.
 .TP
 .I /etc/passwd
 local password database file
+.SH ATTRIBUTES
+.SS Multithreading (see pthreads(7))
+The two functions
+.BR getpwnam ()
+and
+.BR getpwuid ()
+are not thread_safe.
+.LP
+The two functions
+.BR getpwnam_r ()
+and
+.BR getpwuid_r ()
+are thread-safe.
 .SH "CONFORMING TO"
 SVr4, 4.3BSD, POSIX.1-2001.
 The
-- 
1.7.1

-- 
Best Regards,
Peng Haitao

--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] getpwnam.3: Add description of the functions are not thread-safe
       [not found] ` <4E71B895.704-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
@ 2013-03-17 10:48   ` Michael Kerrisk (man-pages)
  0 siblings, 0 replies; 2+ messages in thread
From: Michael Kerrisk (man-pages) @ 2013-03-17 10:48 UTC (permalink / raw)
  To: Peng Haitao; +Cc: linux-man-u79uwXL29TY76Z2rM5mHXA

Peng,

I dug through some old mails...

On Thu, Sep 15, 2011 at 10:34 AM, Peng Haitao <penght-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org> wrote:
>
> The functions getpwnam() and getpwuid() return a pointer to a static area which
> is overwritten by a subsequent call to them. So they are thread-unsafe.

I've applied this to my local branch.

Cheers,

Michael


> Signed-off-by: Peng Haitao <penght-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
> ---
>  man3/getpwnam.3 |   15 ++++++++++++++-
>  1 files changed, 14 insertions(+), 1 deletions(-)
>
> diff --git a/man3/getpwnam.3 b/man3/getpwnam.3
> index 649da01..679477d 100644
> --- a/man3/getpwnam.3
> +++ b/man3/getpwnam.3
> @@ -32,7 +32,7 @@
>  .\" Modified 2003-11-15 by aeb
>  .\" 2008-11-07, mtk, Added an example program for getpwnam_r().
>  .\"
> -.TH GETPWNAM 3  2010-10-21 "GNU" "Linux Programmer's Manual"
> +.TH GETPWNAM 3  2011-09-15 "GNU" "Linux Programmer's Manual"
>  .SH NAME
>  getpwnam, getpwnam_r, getpwuid, getpwuid_r \- get password file entry
>  .SH SYNOPSIS
> @@ -206,6 +206,19 @@ Insufficient buffer space supplied.
>  .TP
>  .I /etc/passwd
>  local password database file
> +.SH ATTRIBUTES
> +.SS Multithreading (see pthreads(7))
> +The two functions
> +.BR getpwnam ()
> +and
> +.BR getpwuid ()
> +are not thread_safe.
> +.LP
> +The two functions
> +.BR getpwnam_r ()
> +and
> +.BR getpwuid_r ()
> +are thread-safe.
>  .SH "CONFORMING TO"
>  SVr4, 4.3BSD, POSIX.1-2001.
>  The
> --
> 1.7.1
>
> --
> Best Regards,
> Peng Haitao
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-man" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Author of "The Linux Programming Interface"; http://man7.org/tlpi/
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-03-17 10:48 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-15  8:34 [PATCH] getpwnam.3: Add description of the functions are not thread-safe Peng Haitao
     [not found] ` <4E71B895.704-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2013-03-17 10:48   ` Michael Kerrisk (man-pages)

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox