From: "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>
To: Alejandro Colomar <alx.manpages@gmail.com>
Cc: mtk.manpages@gmail.com, linux-man@vger.kernel.org
Subject: Re: [PATCH] process_madvise.2: SYNOPSIS: Fix prototype parameter type
Date: Sat, 13 Feb 2021 16:46:50 +0100 [thread overview]
Message-ID: <4cfdf6a3-28f0-5dcb-41c9-60ccec271e56@gmail.com> (raw)
In-Reply-To: <20210211174454.48112-3-alx.manpages@gmail.com>
Hi Alex,
On 2/11/21 6:44 PM, Alejandro Colomar wrote:
> The type of vlen is 'size_t', and not 'unsigned int'. Fix it.
>
> ......
>
> $ grep_syscall process_madvise
> mm/madvise.c:1161:
> SYSCALL_DEFINE5(process_madvise, int, pidfd, const struct iovec __user *, vec,
> size_t, vlen, int, behavior, unsigned int, flags)
> include/linux/syscalls.h:887:
> asmlinkage long sys_process_madvise(int pidfd, const struct iovec __user *vec,
> size_t vlen, int behavior, unsigned int flags);
>
> function grep_syscall()
> {
> if ! [ -v 1 ]; then
> >&2 echo "Usage: ${FUNCNAME[0]} <syscall>";
> return ${EX_USAGE};
> fi
>
> find * -type f \
> |grep '\.c$' \
> |sort -V \
> |xargs pcregrep -Mn "(?s)^\w*SYSCALL_DEFINE.\(${1},.*?\)" \
> |sed -E 's/^[^:]+:[0-9]+:/&\n/';
>
> find * -type f \
> |grep '\.[ch]$' \
> |sort -V \
> |xargs pcregrep -Mn "(?s)^asmlinkage\s+[\w\s]+\**sys_${1}\s*\(.*?\)" \
> |sed -E 's/^[^:]+:[0-9]+:/&\n/';
> }
>
> Signed-off-by: Alejandro Colomar <alx.manpages@gmail.com>
Thanks. Patch applied.
Cheers,
Michael
> ---
> man2/process_madvise.2 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/man2/process_madvise.2 b/man2/process_madvise.2
> index 9dc90ced1..b00ceb6fc 100644
> --- a/man2/process_madvise.2
> +++ b/man2/process_madvise.2
> @@ -33,7 +33,7 @@ process_madvise \- give advice about use of memory to a process
> .B #include <sys/uio.h>
> .PP
> .BI "ssize_t process_madvise(int " pidfd ", const struct iovec *" iovec ,
> -.BI " unsigned long " vlen ", int " advice ,
> +.BI " size_t " vlen ", int " advice ,
> .BI " unsigned int " flags ");"
> .fi
> .PP
>
--
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
prev parent reply other threads:[~2021-02-13 15:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-11 17:44 [PATCH] process_madvise.2: SYNOPSIS: Fix prototype parameter type Alejandro Colomar
2021-02-13 15:46 ` Michael Kerrisk (man-pages) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4cfdf6a3-28f0-5dcb-41c9-60ccec271e56@gmail.com \
--to=mtk.manpages@gmail.com \
--cc=alx.manpages@gmail.com \
--cc=linux-man@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox