From: "Alejandro Colomar (man-pages)" <alx.manpages@gmail.com>
To: mtk.manpages@gmail.com
Cc: linux-man@vger.kernel.org
Subject: Re: [PATCH v2] circleq.3, list.3, slist.3, stailq.3, tailq.3: Improve readability, especially in SYNOPSIS
Date: Tue, 5 Jan 2021 23:53:44 +0100 [thread overview]
Message-ID: <4ec7cc66-fe37-30d7-cc03-a93438fad0cd@gmail.com> (raw)
In-Reply-To: <20210105223955.63678-1-alx.manpages@gmail.com>
A minor correction below:
On 1/5/21 11:39 PM, Alejandro Colomar wrote:
> - Group macros by kinds.
> - Align so that it's easiest to distinguish differences
> between related macros.
> (Align all continuations for consistency on PDF.)
> - Fix minor typos.
> - Remove redundant text:
> 'The macro xxx() ...':
> The first paragraph already says that these are macros.
> 'circular|tail|... queue':
> Don't need to repeat every time.
> Generic text makes it easier to spot the differences.
> - Fit lines into 78 columns.
> - Reorder descriptions to match SYNOPSIS,
> and add subsections to DESCRIPTION.
> - srcfix: fix a few smantic newlines.
>
> I noticed a bug which should be fixed next:
> CIRCLEQ_LOOP_*() return a 'struct TYPE *'.
>
> Signed-off-by: Alejandro Colomar <alx.manpages@gmail.com>
> ---
> man3/circleq.3 | 199 ++++++++++++++++++----------------------
> man3/list.3 | 159 +++++++++++++++-----------------
> man3/slist.3 | 159 +++++++++++++++-----------------
> man3/stailq.3 | 184 +++++++++++++++++--------------------
> man3/tailq.3 | 241 +++++++++++++++++++++++--------------------------
> 5 files changed, 433 insertions(+), 509 deletions(-)
>
[...]
> diff --git a/man3/slist.3 b/man3/slist.3
> index 6868a63c2..1b041773e 100644
> --- a/man3/slist.3
> +++ b/man3/slist.3
[...]
> @@ -200,30 +218,21 @@ turn to
[...]
> -.PP
> -The macro
> -.BR SLIST_NEXT ()
> -returns the next element in the list.
> +from the head of the list.
> +For optimum efficiency,
> +elements being removed from the head of the list
> +should explicitly use this macro instead of the generic
> +.IR SLIST_REMOVE ().
s/.IR/.BR/
[...]
--
Alejandro Colomar
Linux man-pages comaintainer; https://www.kernel.org/doc/man-pages/
http://www.alejandro-colomar.es/
next prev parent reply other threads:[~2021-01-05 22:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-04 22:45 [PATCH] circleq.3, list.3, slist.3, stailq.3, tailq.3: Improve readability, especially in SYNOPSIS Alejandro Colomar
2021-01-04 23:05 ` Alejandro Colomar (man-pages)
2021-01-05 13:25 ` Michael Kerrisk (man-pages)
2021-01-05 22:39 ` [PATCH v2] " Alejandro Colomar
2021-01-05 22:53 ` Alejandro Colomar (man-pages) [this message]
2021-01-06 12:54 ` Michael Kerrisk (man-pages)
2021-01-06 11:12 ` Michael Kerrisk (man-pages)
2021-01-05 12:00 ` [PATCH] " Michael Kerrisk (man-pages)
2021-01-05 14:05 ` pdfman Alejandro Colomar (man-pages)
2021-01-06 11:09 ` pdfman Michael Kerrisk (man-pages)
2024-11-03 5:31 ` pdfman Alejandro Colomar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ec7cc66-fe37-30d7-cc03-a93438fad0cd@gmail.com \
--to=alx.manpages@gmail.com \
--cc=linux-man@vger.kernel.org \
--cc=mtk.manpages@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox