From: "Alejandro Colomar (man-pages)" <alx.manpages@gmail.com>
To: Jakub Wilk <jwilk@jwilk.net>
Cc: Michael Kerrisk <mtk.manpages@gmail.com>, linux-man@vger.kernel.org
Subject: Re: Makefile: Use standard variables and locations
Date: Sun, 28 Mar 2021 13:57:07 +0200 [thread overview]
Message-ID: <5015ca93-b9f2-0c19-2029-939c7aa9b1a7@gmail.com> (raw)
In-Reply-To: <20210325220655.egwiilcs6pf7eher@jwilk.net>
Hi Jakub,
On 3/25/21 11:06 PM, Jakub Wilk wrote:
> * Alejandro Colomar <alx.manpages@gmail.com>, 2021-03-20, 22:03:
>> - Is '|| exit $$?' really needed? AFAIK, make exits on error.
>
> Make catches errors, but shell doesn't by default. So if a recipe
> contains more than a simple command, you need to care of error handling
> yourself. For example:
>
> $ printf 'all:\n\tfalse; echo moo\n' > Makefile
>
> $ make
> false; echo moo
> moo
>
> $ echo $?
> 0
Ahh, I see.
>
>> - Specify SHELL = /bin/sh
>
> This is the default on Unix-like systems.
Humm, yes, it feels better to not specify it. I was just following GNU
recommendations, but this one doesn't make much sense. I'll remove it.
Thanks,
Alex
--
Alejandro Colomar
Linux man-pages comaintainer; https://www.kernel.org/doc/man-pages/
http://www.alejandro-colomar.es/
prev parent reply other threads:[~2021-03-28 11:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-20 21:03 Makefile: Use standard variables and locations Alejandro Colomar (man-pages)
2021-03-25 22:06 ` Jakub Wilk
2021-03-28 11:57 ` Alejandro Colomar (man-pages) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5015ca93-b9f2-0c19-2029-939c7aa9b1a7@gmail.com \
--to=alx.manpages@gmail.com \
--cc=jwilk@jwilk.net \
--cc=linux-man@vger.kernel.org \
--cc=mtk.manpages@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox