From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael Kerrisk (man-pages)" Subject: Re: [patch v2] perf_event_open.2 : document PERF_FLAG_FD_CLOEXEC flag Date: Thu, 10 Apr 2014 21:56:17 +0200 Message-ID: <5346F761.5040705@gmail.com> References: <533BBF1F.4070608@gmail.com> <533E6A8D.3020408@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-man-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Vince Weaver Cc: mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, linux-man-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-man@vger.kernel.org On 04/07/2014 07:02 AM, Vince Weaver wrote: > On Fri, 4 Apr 2014, Michael Kerrisk (man-pages) wrote: > >>>> on-exec flags at creation time, rather than later with >>>> fcntl(2), avoids potential race conditions where the >>>> calling thread invokes perf_event_open() at the same >>>> time as another thread calls fork(2) then execve(2). >>> >>> I'm not sure of a scuccint way to express that though. >> >> I think the existing text suffices. > > My concern is that it should be > "where the calling thread invokes *fcntl()* at the same time..." > rather than > "where the calling thread invokes *perf_event_open()* at the same time..." Fair enough. I've added the words "and fcntl(2)" after invokes perf_event_open(). Thanks, Michael. > but maybe that's just a small detail, I'm fine with the current text > otherwise. > > Vince > -- Michael Kerrisk Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/ Linux/UNIX System Programming Training: http://man7.org/training/ -- To unsubscribe from this list: send the line "unsubscribe linux-man" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html