[PATCH 00/10] Fix various inconsistencies

[PATCH 00/10] Fix various inconsistencies

[Rasmus Villemoes]

With the help of a perl script (which will be sent separately once
it's no longer as embarrassing as it is currently), I checked the
man2-pages for consistency with the actual installed headers.

Rasmus Villemoes (10):
  Fix return type of readlinkat()
  Fix prototype for stime()
  Fix prototypes for semop() and semtimedop()
  Fix prototypes for [sg]etpriority()
  Fix prototype for sched_setaffinity()
  Add <sys/types.h> to synopsis of get_robust_list()
  Fix prototype for mbind(2)
  Add <signal.h> to synopsis for ppoll()
  Fix prototype for set_mempolicy(2)
  Fix prototype for syscall(2)

 man2/get_robust_list.2   | 1 +
 man2/getpriority.2       | 4 ++--
 man2/mbind.2             | 6 +++---
 man2/poll.2              | 1 +
 man2/readlink.2          | 4 ++--
 man2/sched_setaffinity.2 | 2 +-
 man2/semop.2             | 6 +++---
 man2/set_mempolicy.2     | 4 ++--
 man2/stime.2             | 2 +-
 man2/syscall.2           | 2 +-
 10 files changed, 17 insertions(+), 15 deletions(-)

-- 
1.9.2

--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 01/10] Fix return type of readlinkat()

[Rasmus Villemoes]

Signed-off-by: Rasmus Villemoes <rv-qQsb+v5E8BnlAoU/VqSP6n9LOBIZ5rWg@public.gmane.org>
---
 man2/readlink.2 | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/man2/readlink.2 b/man2/readlink.2
index 586ab9e..9dc2a31 100644
--- a/man2/readlink.2
+++ b/man2/readlink.2
@@ -54,8 +54,8 @@ readlink, readlinkat \- read value of a symbolic link
 .BR "#include <fcntl.h>           " "/* Definition of AT_* constants */"
 .B #include <unistd.h>
 .sp
-.BI "int readlinkat(int " dirfd ", const char *" pathname ,
-.BI "               char *" buf ", size_t " bufsiz );
+.BI "ssize_t readlinkat(int " dirfd ", const char *" pathname ,
+.BI "                   char *" buf ", size_t " bufsiz );
 .sp
 .fi
 .in -4n
-- 
1.9.2

--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 01/10] Fix return type of readlinkat()

[Michael Kerrisk (man-pages)]

Looks like the prototype changed between glibc 2.4 and 2.5...

Applied!

Thanks,

Michael


On 04/30/2014 09:42 PM, Rasmus Villemoes wrote:
> Signed-off-by: Rasmus Villemoes <rv-qQsb+v5E8BnlAoU/VqSP6n9LOBIZ5rWg@public.gmane.org>
> ---
>  man2/readlink.2 | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/man2/readlink.2 b/man2/readlink.2
> index 586ab9e..9dc2a31 100644
> --- a/man2/readlink.2
> +++ b/man2/readlink.2
> @@ -54,8 +54,8 @@ readlink, readlinkat \- read value of a symbolic link
>  .BR "#include <fcntl.h>           " "/* Definition of AT_* constants */"
>  .B #include <unistd.h>
>  .sp
> -.BI "int readlinkat(int " dirfd ", const char *" pathname ,
> -.BI "               char *" buf ", size_t " bufsiz );
> +.BI "ssize_t readlinkat(int " dirfd ", const char *" pathname ,
> +.BI "                   char *" buf ", size_t " bufsiz );
>  .sp
>  .fi
>  .in -4n
> 


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 02/10] Fix prototype for stime()

[Rasmus Villemoes]

The argument is const, both according to the actual header
files and according to <http://www.sco.com/developers/devspecs/vol1a.pdf>.

Signed-off-by: Rasmus Villemoes <rv-qQsb+v5E8BnlAoU/VqSP6n9LOBIZ5rWg@public.gmane.org>
---
 man2/stime.2 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/man2/stime.2 b/man2/stime.2
index afecfba..fa47ecd 100644
--- a/man2/stime.2
+++ b/man2/stime.2
@@ -33,7 +33,7 @@ stime \- set time
 .SH SYNOPSIS
 .B #include <time.h>
 .sp
-.BI "int stime(time_t *" t );
+.BI "int stime(const time_t *" t );
 .sp
 .in -4n
 Feature Test Macro Requirements for glibc (see
-- 
1.9.2

--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 02/10] Fix prototype for stime()

[Michael Kerrisk (man-pages)]

On 04/30/2014 09:42 PM, Rasmus Villemoes wrote:
> The argument is const, both according to the actual header
> files and according to <http://www.sco.com/developers/devspecs/vol1a.pdf>.

Applied!

Thanks,

Michael


> Signed-off-by: Rasmus Villemoes <rv-qQsb+v5E8BnlAoU/VqSP6n9LOBIZ5rWg@public.gmane.org>
> ---
>  man2/stime.2 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/man2/stime.2 b/man2/stime.2
> index afecfba..fa47ecd 100644
> --- a/man2/stime.2
> +++ b/man2/stime.2
> @@ -33,7 +33,7 @@ stime \- set time
>  .SH SYNOPSIS
>  .B #include <time.h>
>  .sp
> -.BI "int stime(time_t *" t );
> +.BI "int stime(const time_t *" t );
>  .sp
>  .in -4n
>  Feature Test Macro Requirements for glibc (see
> 


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 03/10] Fix prototypes for semop() and semtimedop()

[Rasmus Villemoes]

The nsops arguments have type size_t, not unsigned, and the
timeout argument of semtimedop() is const.

Signed-off-by: Rasmus Villemoes <rv-qQsb+v5E8BnlAoU/VqSP6n9LOBIZ5rWg@public.gmane.org>
---
 man2/semop.2 | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/man2/semop.2 b/man2/semop.2
index c55473b..8f70e63 100644
--- a/man2/semop.2
+++ b/man2/semop.2
@@ -41,10 +41,10 @@ semop, semtimedop \- System V semaphore operations
 .B #include <sys/ipc.h>
 .B #include <sys/sem.h>
 .sp
-.BI "int semop(int " semid ", struct sembuf *" sops ", unsigned " nsops );
+.BI "int semop(int " semid ", struct sembuf *" sops ", size_t " nsops );
 .sp
-.BI "int semtimedop(int " semid ", struct sembuf *" sops ", unsigned " nsops ,
-.BI "               struct timespec *" timeout );
+.BI "int semtimedop(int " semid ", struct sembuf *" sops ", size_t " nsops ,
+.BI "               const struct timespec *" timeout );
 .fi
 .sp
 .in -4n
-- 
1.9.2

--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 03/10] Fix prototypes for semop() and semtimedop()

[Michael Kerrisk (man-pages)]

On 04/30/2014 09:42 PM, Rasmus Villemoes wrote:
> The nsops arguments have type size_t, not unsigned, and the
> timeout argument of semtimedop() is const.

Looks like the semop() prototype changed between glibc 2.1 and 2.2.
(The semtimedop() prototype was always "size_t". Probably, 
I cut-pasted...)

Applied!

Thanks,

Michael


> Signed-off-by: Rasmus Villemoes <rv-qQsb+v5E8BnlAoU/VqSP6n9LOBIZ5rWg@public.gmane.org>
> ---
>  man2/semop.2 | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/man2/semop.2 b/man2/semop.2
> index c55473b..8f70e63 100644
> --- a/man2/semop.2
> +++ b/man2/semop.2
> @@ -41,10 +41,10 @@ semop, semtimedop \- System V semaphore operations
>  .B #include <sys/ipc.h>
>  .B #include <sys/sem.h>
>  .sp
> -.BI "int semop(int " semid ", struct sembuf *" sops ", unsigned " nsops );
> +.BI "int semop(int " semid ", struct sembuf *" sops ", size_t " nsops );
>  .sp
> -.BI "int semtimedop(int " semid ", struct sembuf *" sops ", unsigned " nsops ,
> -.BI "               struct timespec *" timeout );
> +.BI "int semtimedop(int " semid ", struct sembuf *" sops ", size_t " nsops ,
> +.BI "               const struct timespec *" timeout );
>  .fi
>  .sp
>  .in -4n
> 


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 04/10] Fix prototypes for [sg]etpriority()

[Rasmus Villemoes]

The who argument has type id_t (which happens to be u32 on linux).

Signed-off-by: Rasmus Villemoes <rv-qQsb+v5E8BnlAoU/VqSP6n9LOBIZ5rWg@public.gmane.org>
---
 man2/getpriority.2 | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/man2/getpriority.2 b/man2/getpriority.2
index a448a0f..daedf4c 100644
--- a/man2/getpriority.2
+++ b/man2/getpriority.2
@@ -53,9 +53,9 @@ getpriority, setpriority \- get/set program scheduling priority
 .br
 .B #include <sys/resource.h>
 .sp
-.BI "int getpriority(int " which ", int " who );
+.BI "int getpriority(int " which ", id_t " who );
 .br
-.BI "int setpriority(int " which ", int " who ", int " prio );
+.BI "int setpriority(int " which ", id_t " who ", int " prio );
 .SH DESCRIPTION
 The scheduling priority of the process, process group, or user, as
 indicated by
-- 
1.9.2

--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 04/10] Fix prototypes for [sg]etpriority()

[Michael Kerrisk (man-pages)]

On 04/30/2014 09:42 PM, Rasmus Villemoes wrote:
> The who argument has type id_t (which happens to be u32 on linux).

Looks like there was a change between glibc 2.1 and 2.2.

Applied!

Thanks,

Michael



> Signed-off-by: Rasmus Villemoes <rv-qQsb+v5E8BnlAoU/VqSP6n9LOBIZ5rWg@public.gmane.org>
> ---
>  man2/getpriority.2 | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/man2/getpriority.2 b/man2/getpriority.2
> index a448a0f..daedf4c 100644
> --- a/man2/getpriority.2
> +++ b/man2/getpriority.2
> @@ -53,9 +53,9 @@ getpriority, setpriority \- get/set program scheduling priority
>  .br
>  .B #include <sys/resource.h>
>  .sp
> -.BI "int getpriority(int " which ", int " who );
> +.BI "int getpriority(int " which ", id_t " who );
>  .br
> -.BI "int setpriority(int " which ", int " who ", int " prio );
> +.BI "int setpriority(int " which ", id_t " who ", int " prio );
>  .SH DESCRIPTION
>  The scheduling priority of the process, process group, or user, as
>  indicated by
> 


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 05/10] Fix prototype for sched_setaffinity()

[Rasmus Villemoes]

The mask argument is const.

Signed-off-by: Rasmus Villemoes <rv-qQsb+v5E8BnlAoU/VqSP6n9LOBIZ5rWg@public.gmane.org>
---
 man2/sched_setaffinity.2 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/man2/sched_setaffinity.2 b/man2/sched_setaffinity.2
index 4078b88..b77f5b6 100644
--- a/man2/sched_setaffinity.2
+++ b/man2/sched_setaffinity.2
@@ -41,7 +41,7 @@ set and get a thread's CPU affinity mask
 .B #include <sched.h>
 .sp
 .BI "int sched_setaffinity(pid_t " pid ", size_t " cpusetsize ,
-.BI "                      cpu_set_t *" mask );
+.BI "                      const cpu_set_t *" mask );
 .sp
 .BI "int sched_getaffinity(pid_t " pid ", size_t " cpusetsize ,
 .BI "                      cpu_set_t *" mask );
-- 
1.9.2

--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 05/10] Fix prototype for sched_setaffinity()

[Michael Kerrisk (man-pages)]

On 04/30/2014 09:42 PM, Rasmus Villemoes wrote:
> The mask argument is const.

Applied!

Thanks,

Michael


> Signed-off-by: Rasmus Villemoes <rv-qQsb+v5E8BnlAoU/VqSP6n9LOBIZ5rWg@public.gmane.org>
> ---
>  man2/sched_setaffinity.2 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/man2/sched_setaffinity.2 b/man2/sched_setaffinity.2
> index 4078b88..b77f5b6 100644
> --- a/man2/sched_setaffinity.2
> +++ b/man2/sched_setaffinity.2
> @@ -41,7 +41,7 @@ set and get a thread's CPU affinity mask
>  .B #include <sched.h>
>  .sp
>  .BI "int sched_setaffinity(pid_t " pid ", size_t " cpusetsize ,
> -.BI "                      cpu_set_t *" mask );
> +.BI "                      const cpu_set_t *" mask );
>  .sp
>  .BI "int sched_getaffinity(pid_t " pid ", size_t " cpusetsize ,
>  .BI "                      cpu_set_t *" mask );
> 


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 06/10] Add <sys/types.h> to synopsis of get_robust_list()

[Rasmus Villemoes]

If one were to implement wrappers for [gs]et_robust_list() using the
given prototypes, one would also have to include sys/types.h to get
a definition of size_t.

Signed-off-by: Rasmus Villemoes <rv-qQsb+v5E8BnlAoU/VqSP6n9LOBIZ5rWg@public.gmane.org>
---
 man2/get_robust_list.2 | 1 +
 1 file changed, 1 insertion(+)

diff --git a/man2/get_robust_list.2 b/man2/get_robust_list.2
index 76453ea..377d7e4 100644
--- a/man2/get_robust_list.2
+++ b/man2/get_robust_list.2
@@ -32,6 +32,7 @@ get_robust_list, set_robust_list \- get/set list of robust futexes
 .SH SYNOPSIS
 .nf
 .B #include <linux/futex.h>
+.B #include <sys/types.h>
 .B #include <syscall.h>
 .sp
 .BI "long get_robust_list(int " pid ", struct robust_list_head **" head_ptr ,
-- 
1.9.2

--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 06/10] Add <sys/types.h> to synopsis of get_robust_list()

[Michael Kerrisk (man-pages)]

On 04/30/2014 09:42 PM, Rasmus Villemoes wrote:
> If one were to implement wrappers for [gs]et_robust_list() using the
> given prototypes, one would also have to include sys/types.h to get
> a definition of size_t.

Applied!

Thanks,

Michael


> Signed-off-by: Rasmus Villemoes <rv-qQsb+v5E8BnlAoU/VqSP6n9LOBIZ5rWg@public.gmane.org>
> ---
>  man2/get_robust_list.2 | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/man2/get_robust_list.2 b/man2/get_robust_list.2
> index 76453ea..377d7e4 100644
> --- a/man2/get_robust_list.2
> +++ b/man2/get_robust_list.2
> @@ -32,6 +32,7 @@ get_robust_list, set_robust_list \- get/set list of robust futexes
>  .SH SYNOPSIS
>  .nf
>  .B #include <linux/futex.h>
> +.B #include <sys/types.h>
>  .B #include <syscall.h>
>  .sp
>  .BI "long get_robust_list(int " pid ", struct robust_list_head **" head_ptr ,
> 


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 07/10] Fix prototype for mbind(2)

[Rasmus Villemoes]

The nmask argument is const. The return type in numaif.h is long.

---
Well, at least <numaif.h> says nmask is const. The current kernel does
not define it as a const argument, but sys_mbind() only passes it to
get_nodes(), which does treat it as const.

Signed-off-by: Rasmus Villemoes <rv-qQsb+v5E8BnlAoU/VqSP6n9LOBIZ5rWg@public.gmane.org>
---
 man2/mbind.2 | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/man2/mbind.2 b/man2/mbind.2
index 2a690e6..6cff10a 100644
--- a/man2/mbind.2
+++ b/man2/mbind.2
@@ -49,9 +49,9 @@ mbind \- set memory policy for a memory range
 .nf
 .B "#include <numaif.h>"
 .sp
-.BI "int mbind(void *" addr ", unsigned long " len  ", int " mode ,
-.BI "          unsigned long *" nodemask  ", unsigned long " maxnode ,
-.BI "          unsigned " flags );
+.BI "long mbind(void *" addr ", unsigned long " len  ", int " mode ,
+.BI "           const unsigned long *" nodemask  ", unsigned long " maxnode ,
+.BI "           unsigned " flags );
 .sp
 Link with \fI\-lnuma\fP.
 .fi
-- 
1.9.2

--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 07/10] Fix prototype for mbind(2)

[Michael Kerrisk (man-pages)]

On 04/30/2014 09:42 PM, Rasmus Villemoes wrote:
> The nmask argument is const. The return type in numaif.h is long.

Thanks. Applied!

Cheers,

Michael

> ---
> Well, at least <numaif.h> says nmask is const. The current kernel does
> not define it as a const argument, but sys_mbind() only passes it to
> get_nodes(), which does treat it as const.
> 
> Signed-off-by: Rasmus Villemoes <rv-qQsb+v5E8BnlAoU/VqSP6n9LOBIZ5rWg@public.gmane.org>
> ---
>  man2/mbind.2 | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/man2/mbind.2 b/man2/mbind.2
> index 2a690e6..6cff10a 100644
> --- a/man2/mbind.2
> +++ b/man2/mbind.2
> @@ -49,9 +49,9 @@ mbind \- set memory policy for a memory range
>  .nf
>  .B "#include <numaif.h>"
>  .sp
> -.BI "int mbind(void *" addr ", unsigned long " len  ", int " mode ,
> -.BI "          unsigned long *" nodemask  ", unsigned long " maxnode ,
> -.BI "          unsigned " flags );
> +.BI "long mbind(void *" addr ", unsigned long " len  ", int " mode ,
> +.BI "           const unsigned long *" nodemask  ", unsigned long " maxnode ,
> +.BI "           unsigned " flags );
>  .sp
>  Link with \fI\-lnuma\fP.
>  .fi
> 


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 08/10] Add <signal.h> to synopsis for ppoll()

[Rasmus Villemoes]

One needs to #include <signal.h> to get the definition of the
type (sigset_t) of the mask argument to ppoll().

Signed-off-by: Rasmus Villemoes <rv-qQsb+v5E8BnlAoU/VqSP6n9LOBIZ5rWg@public.gmane.org>
---
 man2/poll.2 | 1 +
 1 file changed, 1 insertion(+)

diff --git a/man2/poll.2 b/man2/poll.2
index f034001..4967869 100644
--- a/man2/poll.2
+++ b/man2/poll.2
@@ -38,6 +38,7 @@ poll, ppoll \- wait for some event on a file descriptor
 .BI "int poll(struct pollfd *" fds ", nfds_t " nfds ", int " timeout );
 .sp
 .BR "#define _GNU_SOURCE" "         /* See feature_test_macros(7) */"
+.B #include <signal.h>
 .B #include <poll.h>
 .sp
 .BI "int ppoll(struct pollfd *" fds ", nfds_t " nfds ", "
-- 
1.9.2

--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 08/10] Add <signal.h> to synopsis for ppoll()

[Michael Kerrisk (man-pages)]

On 04/30/2014 09:42 PM, Rasmus Villemoes wrote:
> One needs to #include <signal.h> to get the definition of the
> type (sigset_t) of the mask argument to ppoll().

Nice find! Patch applied.

Cheers,

Michael


> Signed-off-by: Rasmus Villemoes <rv-qQsb+v5E8BnlAoU/VqSP6n9LOBIZ5rWg@public.gmane.org>
> ---
>  man2/poll.2 | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/man2/poll.2 b/man2/poll.2
> index f034001..4967869 100644
> --- a/man2/poll.2
> +++ b/man2/poll.2
> @@ -38,6 +38,7 @@ poll, ppoll \- wait for some event on a file descriptor
>  .BI "int poll(struct pollfd *" fds ", nfds_t " nfds ", int " timeout );
>  .sp
>  .BR "#define _GNU_SOURCE" "         /* See feature_test_macros(7) */"
> +.B #include <signal.h>
>  .B #include <poll.h>
>  .sp
>  .BI "int ppoll(struct pollfd *" fds ", nfds_t " nfds ", "
> 


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 09/10] Fix prototype for set_mempolicy(2)

[Rasmus Villemoes]

The nodemask argument is const, and the return type is long.

Signed-off-by: Rasmus Villemoes <rv-qQsb+v5E8BnlAoU/VqSP6n9LOBIZ5rWg@public.gmane.org>
---
 man2/set_mempolicy.2 | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/man2/set_mempolicy.2 b/man2/set_mempolicy.2
index 843208c..b17cf30 100644
--- a/man2/set_mempolicy.2
+++ b/man2/set_mempolicy.2
@@ -31,8 +31,8 @@ set_mempolicy \- set default NUMA memory policy for a process and its children
 .nf
 .B "#include <numaif.h>"
 .sp
-.BI "int set_mempolicy(int " mode ", unsigned long *" nodemask ,
-.BI "                  unsigned long " maxnode );
+.BI "long set_mempolicy(int " mode ", const unsigned long *" nodemask ,
+.BI "                   unsigned long " maxnode );
 .sp
 Link with \fI\-lnuma\fP.
 .fi
-- 
1.9.2

--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 09/10] Fix prototype for set_mempolicy(2)

[Michael Kerrisk (man-pages)]

On 04/30/2014 09:42 PM, Rasmus Villemoes wrote:
> The nodemask argument is const, and the return type is long.

Thanks. Applied!

Cheers,

Michael

> Signed-off-by: Rasmus Villemoes <rv-qQsb+v5E8BnlAoU/VqSP6n9LOBIZ5rWg@public.gmane.org>
> ---
>  man2/set_mempolicy.2 | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/man2/set_mempolicy.2 b/man2/set_mempolicy.2
> index 843208c..b17cf30 100644
> --- a/man2/set_mempolicy.2
> +++ b/man2/set_mempolicy.2
> @@ -31,8 +31,8 @@ set_mempolicy \- set default NUMA memory policy for a process and its children
>  .nf
>  .B "#include <numaif.h>"
>  .sp
> -.BI "int set_mempolicy(int " mode ", unsigned long *" nodemask ,
> -.BI "                  unsigned long " maxnode );
> +.BI "long set_mempolicy(int " mode ", const unsigned long *" nodemask ,
> +.BI "                   unsigned long " maxnode );
>  .sp
>  Link with \fI\-lnuma\fP.
>  .fi
> 


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 10/10] Fix prototype for syscall(2)

[Rasmus Villemoes]

The first argument and the return value of syscall() has type long,
not int.

Signed-off-by: Rasmus Villemoes <rv-qQsb+v5E8BnlAoU/VqSP6n9LOBIZ5rWg@public.gmane.org>
---
 man2/syscall.2 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/man2/syscall.2 b/man2/syscall.2
index 01a4739..f30e77a 100644
--- a/man2/syscall.2
+++ b/man2/syscall.2
@@ -46,7 +46,7 @@ syscall \- indirect system call
 .B #include <unistd.h>
 .BR "#include <sys/syscall.h>   "  "/* For SYS_xxx definitions */"
 
-.BI "int syscall(int " number ", ...);"
+.BI "long syscall(long " number ", ...);"
 .fi
 .SH DESCRIPTION
 .BR syscall ()
-- 
1.9.2

--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 10/10] Fix prototype for syscall(2)

[Michael Kerrisk (man-pages)]

On 04/30/2014 09:42 PM, Rasmus Villemoes wrote:
> The first argument and the return value of syscall() has type long,
> not int.

Applied!

Thanks,

Michael


> Signed-off-by: Rasmus Villemoes <rv-qQsb+v5E8BnlAoU/VqSP6n9LOBIZ5rWg@public.gmane.org>
> ---
>  man2/syscall.2 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/man2/syscall.2 b/man2/syscall.2
> index 01a4739..f30e77a 100644
> --- a/man2/syscall.2
> +++ b/man2/syscall.2
> @@ -46,7 +46,7 @@ syscall \- indirect system call
>  .B #include <unistd.h>
>  .BR "#include <sys/syscall.h>   "  "/* For SYS_xxx definitions */"
>  
> -.BI "int syscall(int " number ", ...);"
> +.BI "long syscall(long " number ", ...);"
>  .fi
>  .SH DESCRIPTION
>  .BR syscall ()
> 


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 00/10] Fix various inconsistencies

[Michael Kerrisk (man-pages)]

On 04/30/2014 09:42 PM, Rasmus Villemoes wrote:
> With the help of a perl script (which will be sent separately once
> it's no longer as embarrassing as it is currently), I checked the
> man2-pages for consistency with the actual installed headers.

Great stuff, Rasmus. Who knows, that script might be handy again 
one day, if you want to polish it up.

All of the patches look correct to me, and I've applied.
In a few cases, the errors came about because glibc
has changed the prototypes (in the distant past).

Thanks for the patches!

Cheers,

Michael


> Rasmus Villemoes (10):
>   Fix return type of readlinkat()
>   Fix prototype for stime()
>   Fix prototypes for semop() and semtimedop()
>   Fix prototypes for [sg]etpriority()
>   Fix prototype for sched_setaffinity()
>   Add <sys/types.h> to synopsis of get_robust_list()
>   Fix prototype for mbind(2)
>   Add <signal.h> to synopsis for ppoll()
>   Fix prototype for set_mempolicy(2)
>   Fix prototype for syscall(2)
> 
>  man2/get_robust_list.2   | 1 +
>  man2/getpriority.2       | 4 ++--
>  man2/mbind.2             | 6 +++---
>  man2/poll.2              | 1 +
>  man2/readlink.2          | 4 ++--
>  man2/sched_setaffinity.2 | 2 +-
>  man2/semop.2             | 6 +++---
>  man2/set_mempolicy.2     | 4 ++--
>  man2/stime.2             | 2 +-
>  man2/syscall.2           | 2 +-
>  10 files changed, 17 insertions(+), 15 deletions(-)
> 


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html