linux-man.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Michael Kerrisk (man-pages)" <mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Peng Haitao <penght-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
Cc: mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	carlos-v2tUB8YBRSi3e3T8WW9gsA@public.gmane.org,
	aoliva-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
	linux-man-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] siginterrupt.3: ATTRIBUTES: Note function that is not thread-safe
Date: Wed, 11 Jun 2014 10:41:52 +0200	[thread overview]
Message-ID: <53981650.5020900@gmail.com> (raw)
In-Reply-To: <1402470146-16506-1-git-send-email-penght-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>

Thanks, Haitao. Applied.

May I suggest that you CC Qian Lei on all of your patches, at least 
for as long as you are both working on this topic?

Cheers,

Michael


On 06/11/2014 09:02 AM, Peng Haitao wrote:
> The function siginterrupt() is not thread safe.
> 
> Signed-off-by: Peng Haitao <penght-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
> ---
>  man3/siginterrupt.3 | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/man3/siginterrupt.3 b/man3/siginterrupt.3
> index bdf8b21..8365348 100644
> --- a/man3/siginterrupt.3
> +++ b/man3/siginterrupt.3
> @@ -84,6 +84,12 @@ set to indicate the cause of the error.
>  .TP
>  .B EINVAL
>  The specified signal number is invalid.
> +.SH ATTRIBUTES
> +.SS Multithreading (see pthreads(7))
> +The
> +.BR siginterrupt ()
> +function uses a global variable that is not protected,
> +so it is not thread-safe.
>  .SH CONFORMING TO
>  4.3BSD, POSIX.1-2001.
>  POSIX.1-2008 marks
> 


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2014-06-11  8:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-11  7:02 [PATCH] siginterrupt.3: ATTRIBUTES: Note function that is not thread-safe Peng Haitao
     [not found] ` <1402470146-16506-1-git-send-email-penght-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2014-06-11  8:41   ` Michael Kerrisk (man-pages)
2014-06-11  8:41   ` Michael Kerrisk (man-pages) [this message]
     [not found]     ` <53981650.5020900-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-06-11  9:09       ` Peng Haitao
     [not found]         ` <53981CB2.60509-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2014-06-11  9:25           ` Michael Kerrisk (man-pages)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53981650.5020900@gmail.com \
    --to=mtk.manpages-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=aoliva-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=carlos-v2tUB8YBRSi3e3T8WW9gsA@public.gmane.org \
    --cc=linux-man-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=penght-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).