Re: [PATCH] mq_unlink.3: ATTRIBUTES: Note function that is thread-safe

["Michael Kerrisk (man-pages)" <mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]

On 06/11/2014 11:28 AM, Qian Lei wrote:
> Hello Michael
> 
> On Wed, 2014-06-11 at 10:35 +0200, Michael Kerrisk (man-pages) wrote:
>> Hello Qian Lei,
>>
>> On 06/11/2014 07:45 AM, Qian Lei wrote:
>>> Hello Michael
>>>
>>> Thank you for your suggestions, I'll CC Peng Haitao and add
>>> "Reviewed-by" in my patches.
>>
>> I want to check that we have not misunderstood each other here.
> 
> Sorry for my unclear description. I got it and understood what you mean.
> 
>> My idea is that the Reviewed-by: tag should be added only if 
>> the other person has actually reviewed the patch. 
> 
> Patches with the tag were reviewed by Peng Haitao before I posted.
> I will not add the tag to patches if nobody reviews them.

Thanks!

Cheers,

Michael


>> I'll normally
>> accept patches from the two of you without the need for the 
>> Reviewed-by: tag, but it would be nice to have that extra level 
>> of assurance, if possible.
>>
>> Cheers,
>>
>> Michael
>>
>>> Qian Lei
>>>
>>> On Tue, 2014-06-10 at 16:44 +0200, Michael Kerrisk (man-pages) wrote:
>>>> On 06/10/2014 08:28 AM, Qian Lei wrote:
>>>>> Hello Michael
>>>>>
>>>>> Yeah, You are right. I'm working together with Peng Haitao.
>>>>
>>>> Hello Qian Lei,
>>>>
>>>> Thanks for the info, 
>>>>
>>>> I do not know how closely you are working together, but if you are
>>>> reviewing each other's work, it would be great if you CCed each 
>>>> other on your patches, and perhaps also provided an "Reviewed-by" 
>>>> for each other's work.
>>>>
>>>> Thanks,
>>>>
>>>> Michael
>>>>
>>>>
>>>>> On Mon, 2014-06-09 at 19:57 +0200, Michael Kerrisk (man-pages) wrote:
>>>>>> On 06/09/2014 05:45 AM, Qian Lei wrote:
>>>>>>> The function mq_unlink() is thread safe.
>>>>>>
>>>>>> Hello Qian Lei,
>>>>>>
>>>>>> Am I correct to assume that you are working together with Peng Haitao?
>>>>>>
>>>>>> Cheers,
>>>>>>
>>>>>> Michael
>>>>>>
>>>>>>
>>>>>>> Signed-off-by: Qian Lei <qianl.fnst-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
>>>>>>> ---
>>>>>>>  man3/mq_unlink.3 | 5 +++++
>>>>>>>  1 file changed, 5 insertions(+)
>>>>>>>
>>>>>>> diff --git a/man3/mq_unlink.3 b/man3/mq_unlink.3
>>>>>>> index 19b977f..bf49e9c 100644
>>>>>>> --- a/man3/mq_unlink.3
>>>>>>> +++ b/man3/mq_unlink.3
>>>>>>> @@ -59,6 +59,11 @@ was too long.
>>>>>>>  .B ENOENT
>>>>>>>  There is no message queue with the given
>>>>>>>  .IR name .
>>>>>>> +.SH ATTRIBUTES
>>>>>>> +.SS Multithreading (see pthreads(7))
>>>>>>> +The
>>>>>>> +.BR mq_unlink ()
>>>>>>> +function is thread-safe.
>>>>>>>  .SH CONFORMING TO
>>>>>>>  POSIX.1-2001.
>>>>>>>  .SH SEE ALSO
>>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>
>>>>
>>>
>>>
>>
>>
> 
> 


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html