linux-man.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Carlos O'Donell" <carlos-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Michael Kerrisk
	<mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	"linux-man-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-man-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: [patch] getpw.3: Function could return -1 and set errno to zero.
Date: Thu, 15 Jan 2015 22:29:03 -0500	[thread overview]
Message-ID: <54B8857F.2060307@redhat.com> (raw)

All of the BSD interfaces, including glibc's own implementation
of getpw return -1 and set errno to 0 to indicate that there
was no user corresponding to that uid.

I have never under any condition seen an NSS backend return
ENOENT via the set of APIs that getpw uses internally in
glibc.

Therefore I would suggest the manual page be expanded to include
0 in the list of valid errno values that indicate no corresponding
user. I reorganize the list of errors to have the non-error
at the top, as is done with getgrnam.3 and getpwnam.3 which have
similar behaviour in the non-error case.

Patch against master.

diff --git a/man3/getpw.3 b/man3/getpw.3
index 4054823..3eed9a7 100644
--- a/man3/getpw.3
+++ b/man3/getpw.3
@@ -77,14 +77,14 @@ function returns 0 on success; on error, it returns \-1, and
 is set to indicate the error.
 .SH ERRORS
 .TP
+.BR 0 " or " ENOENT
+No user corresponding to
+.IR uid .
+.TP
 .B EINVAL
 .I buf
 is NULL.
 .TP
-.B 0 or ENOENT
-No user corresponding to
-.IR uid .
-.TP
 .B ENOMEM
 Insufficient memory to allocate
 .I passwd
---

Cheers,
Carlos.
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

             reply	other threads:[~2015-01-16  3:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-16  3:29 Carlos O'Donell [this message]
     [not found] ` <54B8857F.2060307-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-01-16  6:38   ` [patch] getpw.3: Function could return -1 and set errno to zero Michael Kerrisk (man-pages)
     [not found]     ` <54B8B1EB.4040000-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-01-16 21:02       ` Carlos O'Donell
     [not found]         ` <54B97C72.6060809-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-01-17  8:41           ` Michael Kerrisk (man-pages)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54B8857F.2060307@redhat.com \
    --to=carlos-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
    --cc=linux-man-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).