[PATCH] termios.3: Modify thread-safety information

[PATCH] termios.3: Modify thread-safety information

[Ma Shimiao]

As annotation in glibc manual is more detailed, change the 
thread-safety information to be the same as glibc manual.

Signed-off-by: Ma Shimiao <mashimiao.fnst-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
---
 man3/termios.3 | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/man3/termios.3 b/man3/termios.3
index 371bdf7..8eb04be 100644
--- a/man3/termios.3
+++ b/man3/termios.3
@@ -979,15 +979,14 @@ For an explanation of the terms used in this section, see
 .TS
 allbox;
 lb lb lb
-lw37 l l.
+l l l.
 Interface	Attribute	Value
 T{
 .BR tcgetattr (),
 .BR tcsetattr (),
-.BR tcsendbreak (),
 .BR tcdrain (),
+.br
 .BR tcflush (),
-.BR tcflow (),
 .BR cfmakeraw (),
 .BR cfgetispeed (),
 .BR cfgetospeed (),
@@ -995,6 +994,10 @@ T{
 .BR cfsetospeed (),
 .BR cfsetspeed ()
 T}	Thread safety	MT-Safe
+T{
+.BR tcsendbreak (),
+.BR tcflow ()
+T}	Thread safety	MT-Unsafe race:tcattr(filedes)/bsd
 .TE
 .ad
 .hy
-- 
1.8.3.1

--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] termios.3: Modify thread-safety information

[Michael Kerrisk (man-pages)]

On 01/21/2015 08:40 AM, Ma Shimiao wrote:
> As annotation in glibc manual is more detailed, change the 
> thread-safety information to be the same as glibc manual.

Thanks, Ma Shimiao. I've applied, but with a question below.


> 
> Signed-off-by: Ma Shimiao <mashimiao.fnst-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
> ---
>  man3/termios.3 | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/man3/termios.3 b/man3/termios.3
> index 371bdf7..8eb04be 100644
> --- a/man3/termios.3
> +++ b/man3/termios.3
> @@ -979,15 +979,14 @@ For an explanation of the terms used in this section, see
>  .TS
>  allbox;
>  lb lb lb
> -lw37 l l.
> +l l l.
>  Interface	Attribute	Value
>  T{
>  .BR tcgetattr (),
>  .BR tcsetattr (),
> -.BR tcsendbreak (),
>  .BR tcdrain (),
> +.br
>  .BR tcflush (),
> -.BR tcflow (),
>  .BR cfmakeraw (),
>  .BR cfgetispeed (),
>  .BR cfgetospeed (),
> @@ -995,6 +994,10 @@ T{
>  .BR cfsetospeed (),
>  .BR cfsetspeed ()
>  T}	Thread safety	MT-Safe
> +T{
> +.BR tcsendbreak (),
> +.BR tcflow ()
> +T}	Thread safety	MT-Unsafe race:tcattr(filedes)/bsd

What does "bsd" mean here?

>  .TE
>  .ad
>  .hy

Cheers,

Michael




-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] termios.3: Modify thread-safety information

[Ma Shimiao]

On 01/21/2015 04:03 PM, Michael Kerrisk (man-pages) wrote:
> On 01/21/2015 08:40 AM, Ma Shimiao wrote:
>> As annotation in glibc manual is more detailed, change the 
>> thread-safety information to be the same as glibc manual.
> 
> Thanks, Ma Shimiao. I've applied, but with a question below.
> 
> 
>>
>> Signed-off-by: Ma Shimiao <mashimiao.fnst-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
>> ---
>>  man3/termios.3 | 9 ++++++---
>>  1 file changed, 6 insertions(+), 3 deletions(-)
>>
>> diff --git a/man3/termios.3 b/man3/termios.3
>> index 371bdf7..8eb04be 100644
>> --- a/man3/termios.3
>> +++ b/man3/termios.3
>> @@ -979,15 +979,14 @@ For an explanation of the terms used in this section, see
>>  .TS
>>  allbox;
>>  lb lb lb
>> -lw37 l l.
>> +l l l.
>>  Interface	Attribute	Value
>>  T{
>>  .BR tcgetattr (),
>>  .BR tcsetattr (),
>> -.BR tcsendbreak (),
>>  .BR tcdrain (),
>> +.br
>>  .BR tcflush (),
>> -.BR tcflow (),
>>  .BR cfmakeraw (),
>>  .BR cfgetispeed (),
>>  .BR cfgetospeed (),
>> @@ -995,6 +994,10 @@ T{
>>  .BR cfsetospeed (),
>>  .BR cfsetspeed ()
>>  T}	Thread safety	MT-Safe
>> +T{
>> +.BR tcsendbreak (),
>> +.BR tcflow ()
>> +T}	Thread safety	MT-Unsafe race:tcattr(filedes)/bsd
> 
> What does "bsd" mean here?
/bsd means if the glibc is built for BSD(Berkeley Software Distribution) kernel, the function
is MT-Unsafe. Otherwise, the function is MT-Safe.
> 
>>  .TE
>>  .ad
>>  .hy
> 
> Cheers,
> 
> Michael
> 
> 
> 
> 


-- 
Ma Shimiao
Development Dept.I
Nanjing Fujitsu Nanda Software Tech. Co., Ltd.(FNST)
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] termios.3: Modify thread-safety information

[Michael Kerrisk (man-pages)]

On 21 January 2015 at 09:17, Ma Shimiao <mashimiao.fnst-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org> wrote:
> On 01/21/2015 04:03 PM, Michael Kerrisk (man-pages) wrote:
>> On 01/21/2015 08:40 AM, Ma Shimiao wrote:
>>> As annotation in glibc manual is more detailed, change the
>>> thread-safety information to be the same as glibc manual.
>>
>> Thanks, Ma Shimiao. I've applied, but with a question below.
>>
>>
>>>
>>> Signed-off-by: Ma Shimiao <mashimiao.fnst-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
>>> ---
>>>  man3/termios.3 | 9 ++++++---
>>>  1 file changed, 6 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/man3/termios.3 b/man3/termios.3
>>> index 371bdf7..8eb04be 100644
>>> --- a/man3/termios.3
>>> +++ b/man3/termios.3
>>> @@ -979,15 +979,14 @@ For an explanation of the terms used in this section, see
>>>  .TS
>>>  allbox;
>>>  lb lb lb
>>> -lw37 l l.
>>> +l l l.
>>>  Interface   Attribute       Value
>>>  T{
>>>  .BR tcgetattr (),
>>>  .BR tcsetattr (),
>>> -.BR tcsendbreak (),
>>>  .BR tcdrain (),
>>> +.br
>>>  .BR tcflush (),
>>> -.BR tcflow (),
>>>  .BR cfmakeraw (),
>>>  .BR cfgetispeed (),
>>>  .BR cfgetospeed (),
>>> @@ -995,6 +994,10 @@ T{
>>>  .BR cfsetospeed (),
>>>  .BR cfsetspeed ()
>>>  T}  Thread safety   MT-Safe
>>> +T{
>>> +.BR tcsendbreak (),
>>> +.BR tcflow ()
>>> +T}  Thread safety   MT-Unsafe race:tcattr(filedes)/bsd
>>
>> What does "bsd" mean here?
> /bsd means if the glibc is built for BSD(Berkeley Software Distribution) kernel, the function
> is MT-Unsafe. Otherwise, the function is MT-Safe.

Yes, but these are the *Linux* man pages. So, this information is more
confusing than useful, I would say.

The pages should describe the Linux situation. So, something needs to
be fixed. Should the patch be reverted, or should it be revised?

Thanks,

Michael



-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] termios.3: Modify thread-safety information

[Ma Shimiao]

On 01/21/2015 04:40 PM, Michael Kerrisk (man-pages) wrote:
> Yes, but these are the *Linux* man pages. So, this information is more
> confusing than useful, I would say.
Thanks for reminding!
It's my mistake.
I just think about making it to be the same as glibc manual.
> 
> The pages should describe the Linux situation. So, something needs to
> be fixed. Should the patch be reverted, or should it be revised?
I will resend a patch to fix it.
Thanks again.

-- 
Ma Shimiao
Development Dept.I
Nanjing Fujitsu Nanda Software Tech. Co., Ltd.(FNST)
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] termios.3: Modify thread-safety information

[Ma Shimiao]

As this is man page for Linux, we don't need thread safety information
for bsd

Signed-off-by: Ma Shimiao <mashimiao.fnst-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
---
 man3/termios.3 | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/man3/termios.3 b/man3/termios.3
index 8eb04be..314218f 100644
--- a/man3/termios.3
+++ b/man3/termios.3
@@ -984,9 +984,12 @@ Interface	Attribute	Value
 T{
 .BR tcgetattr (),
 .BR tcsetattr (),
+.BR tcsendbreak (),
 .BR tcdrain (),
 .br
 .BR tcflush (),
+.br
+.BR tcflow (),
 .BR cfmakeraw (),
 .BR cfgetispeed (),
 .BR cfgetospeed (),
@@ -994,10 +997,6 @@ T{
 .BR cfsetospeed (),
 .BR cfsetspeed ()
 T}	Thread safety	MT-Safe
-T{
-.BR tcsendbreak (),
-.BR tcflow ()
-T}	Thread safety	MT-Unsafe race:tcattr(filedes)/bsd
 .TE
 .ad
 .hy
-- 
1.8.3.1

--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] termios.3: Modify thread-safety information

[Michael Kerrisk (man-pages)]

On 01/21/2015 10:07 AM, Ma Shimiao wrote:
> As this is man page for Linux, we don't need thread safety information
> for bsd

Thanks, Ma Shimiao. Applied.

Cheers,

Michael


> Signed-off-by: Ma Shimiao <mashimiao.fnst-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
> ---
>  man3/termios.3 | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/man3/termios.3 b/man3/termios.3
> index 8eb04be..314218f 100644
> --- a/man3/termios.3
> +++ b/man3/termios.3
> @@ -984,9 +984,12 @@ Interface	Attribute	Value
>  T{
>  .BR tcgetattr (),
>  .BR tcsetattr (),
> +.BR tcsendbreak (),
>  .BR tcdrain (),
>  .br
>  .BR tcflush (),
> +.br
> +.BR tcflow (),
>  .BR cfmakeraw (),
>  .BR cfgetispeed (),
>  .BR cfgetospeed (),
> @@ -994,10 +997,6 @@ T{
>  .BR cfsetospeed (),
>  .BR cfsetspeed ()
>  T}	Thread safety	MT-Safe
> -T{
> -.BR tcsendbreak (),
> -.BR tcflow ()
> -T}	Thread safety	MT-Unsafe race:tcattr(filedes)/bsd
>  .TE
>  .ad
>  .hy
> 


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html