[patch] ipv6.7: documents SOL_IPV6 as an alternative to IPPROTO_IPV6 for socket level.

[patch] ipv6.7: documents SOL_IPV6 as an alternative to IPPROTO_IPV6 for socket level.

[saulery-GANU6spQydw]

From: Stéphane Aulery <saulery-GANU6spQydw@public.gmane.org>

Fix for Debian bug #472447 reported by David Madore <david.madore@ens.fr>

Signed-off-by: Stéphane Aulery <saulery-GANU6spQydw@public.gmane.org>
---
 man7/ipv6.7 | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/man7/ipv6.7 b/man7/ipv6.7
index c4e6cac..cd1af35 100644
--- a/man7/ipv6.7
+++ b/man7/ipv6.7
@@ -195,7 +195,9 @@ IPv6 supports some protocol-specific socket options that can be set with
 and read with
 .BR getsockopt (2).
 The socket option level for IPv6 is
-.BR IPPROTO_IPV6 .
+.BR IPPROTO_IPV6 
+(or its alternative
+.BR SOL_IPV6 ).
 A boolean integer flag is zero when it is false, otherwise true.
 .TP
 .B IPV6_ADDRFORM
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [patch] ipv6.7: documents SOL_IPV6 as an alternative to IPPROTO_IPV6 for socket level.

[Michael Kerrisk (man-pages)]

Hi Stéphane,

On 03/04/2015 12:20 AM, saulery-GANU6spQydw@public.gmane.org wrote:
> From: Stéphane Aulery <saulery-GANU6spQydw@public.gmane.org>
> 
> Fix for Debian bug #472447 reported by David Madore <david.madore@ens.fr>

I know it's tiresome, but it's nice to have a URL for easy clicking:

https://bugs.debian.org/472447

But, I am skeptical about the bug report. The reporter says that the
page "[does not] mention SOL_IPV6 as an alternative to IPPROTO_IPV6
for socket level.  It would be nice if it could."

This is not a very useful report. *Why* would it be nice? SOL_IPV6 is
not in any standard as far as I can see, nor on any other implementation.
Furthermore, ip(7) says of the analogous "SOL_IP" constant:

       Using  SOL_IP  socket  options  level  isn't  portable, BSD-based
       stacks use IPPROTO_IP level.

So, it appears to me that mentioning SOL_IPV6 is just leading people 
into a portability trap.

In general: one must question bug reports. The reporter may suggest 
that something is true or desirable, but that needs explanation or
justification.

Summary: I won't apply this. (I would entertain a patch that mention 
SOL_IPV6 in NOTES, with a careful note that it is nonportable.)

Cheers,

Michael

> 
> Signed-off-by: Stéphane Aulery <saulery-GANU6spQydw@public.gmane.org>
> ---
>  man7/ipv6.7 | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/man7/ipv6.7 b/man7/ipv6.7
> index c4e6cac..cd1af35 100644
> --- a/man7/ipv6.7
> +++ b/man7/ipv6.7
> @@ -195,7 +195,9 @@ IPv6 supports some protocol-specific socket options that can be set with
>  and read with
>  .BR getsockopt (2).
>  The socket option level for IPv6 is
> -.BR IPPROTO_IPV6 .
> +.BR IPPROTO_IPV6 
> +(or its alternative
> +.BR SOL_IPV6 ).
>  A boolean integer flag is zero when it is false, otherwise true.
>  .TP
>  .B IPV6_ADDRFORM
> 


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [patch] ipv6.7: documents SOL_IPV6 as an alternative to IPPROTO_IPV6 for socket level.

[Stéphane Aulery]

Hi Michael,

Le mercredi 04 mars 2015 à 07:24:53, Michael Kerrisk (man-pages) a écrit :
> 
> On 03/04/2015 12:20 AM, saulery-GANU6spQydw@public.gmane.org wrote:
> > From: Stéphane Aulery <saulery-GANU6spQydw@public.gmane.org>
> > 
> > Fix for Debian bug #472447 reported by David Madore <david.madore@ens.fr>
> 
> I know it's tiresome, but it's nice to have a URL for easy clicking:
> 
> https://bugs.debian.org/472447

In contrary I prefer with a link, but I was not thinking to that.

> But, I am skeptical about the bug report. The reporter says that the
> page "[does not] mention SOL_IPV6 as an alternative to IPPROTO_IPV6
> for socket level.  It would be nice if it could."
> 
> [...]
> 
> Summary: I won't apply this. (I would entertain a patch that mention 
> SOL_IPV6 in NOTES, with a careful note that it is nonportable.)

Good for me. I will close Debian Bug with a detailed answer.

Regards,

-- 
Stéphane Aulery
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] ipv6.7: SOL_IPV6 and other SOL_* options socket are not portable

[Stéphane Aulery]

Fix for Debian bug #472447 reported by David Madore <david.madore@ens.fr>

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=472447
Signed-off-by: Stéphane Aulery <saulery-GANU6spQydw@public.gmane.org>
---
 man7/ipv6.7 | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/man7/ipv6.7 b/man7/ipv6.7
index c4e6cac..16c760b 100644
--- a/man7/ipv6.7
+++ b/man7/ipv6.7
@@ -393,6 +393,18 @@ Programs that assume that all address types can be stored safely in a
 need to be changed to use
 .I struct sockaddr_storage
 for that instead.
+.PP
+.BR SOL_IP ,
+.BR SOL_IPV6 ,
+.B SOL_ICMPV6
+and other
+.BR SOL_ *
+socket options are not portable
+variants of
+.BR IPPROTO_ *.
+For more information, see
+.BR ip (7),
+glibc and kernel headers.
 .SH BUGS
 The IPv6 extended API as in RFC\ 2292 is currently only partly
 implemented;
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ipv6.7: SOL_IPV6 and other SOL_* options socket are not portable

[Stéphane Aulery]

Only this patch you forgot.


Le lundi 09 mars 2015 à 02:04:53, AULERY Stéphane a écrit :
> Fix for Debian bug #472447 reported by David Madore <david.madore@ens.fr>
> 
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=472447
> Signed-off-by: Stéphane Aulery <saulery-GANU6spQydw@public.gmane.org>
> ---
>  man7/ipv6.7 | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/man7/ipv6.7 b/man7/ipv6.7
> index c4e6cac..16c760b 100644
> --- a/man7/ipv6.7
> +++ b/man7/ipv6.7
> @@ -393,6 +393,18 @@ Programs that assume that all address types can be stored safely in a
>  need to be changed to use
>  .I struct sockaddr_storage
>  for that instead.
> +.PP
> +.BR SOL_IP ,
> +.BR SOL_IPV6 ,
> +.B SOL_ICMPV6
> +and other
> +.BR SOL_ *
> +socket options are not portable
> +variants of
> +.BR IPPROTO_ *.
> +For more information, see
> +.BR ip (7),
> +glibc and kernel headers.
>  .SH BUGS
>  The IPv6 extended API as in RFC\ 2292 is currently only partly
>  implemented;
> -- 
> 2.1.4
> 

-- 
Stéphane Aulery
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ipv6.7: SOL_IPV6 and other SOL_* options socket are not portable

[Michael Kerrisk (man-pages)]

Hi Stéphane,

On 03/09/2015 02:04 PM, Stéphane Aulery wrote:
> Fix for Debian bug #472447 reported by David Madore <david.madore@ens.fr>
> 
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=472447
> Signed-off-by: Stéphane Aulery <saulery-GANU6spQydw@public.gmane.org>

Applied, but some comments below.

Take a look also at commit 8013e4ef703e3d1199dfb628e6fe1e0fd290ca49
to see how you could tweak your commit messages to better fit with
my normal layout.

Cheers,

Michael

http://git.kernel.org/cgit/docs/man-pages/man-pages.git/commit/?id=8013e4ef703e3d1199dfb628e6fe1e0fd290ca49

> ---
>  man7/ipv6.7 | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/man7/ipv6.7 b/man7/ipv6.7
> index c4e6cac..16c760b 100644
> --- a/man7/ipv6.7
> +++ b/man7/ipv6.7
> @@ -393,6 +393,18 @@ Programs that assume that all address types can be stored safely in a
>  need to be changed to use
>  .I struct sockaddr_storage
>  for that instead.
> +.PP
> +.BR SOL_IP ,
> +.BR SOL_IPV6 ,
> +.B SOL_ICMPV6
> +and other
> +.BR SOL_ *
> +socket options are not portable
> +variants of
> +.BR IPPROTO_ *.
> +For more information, see
> +.BR ip (7),
> +glibc and kernel headers.

I made that last sentence just: "See also ip(7)." I think
it suffices.

Cheers,

Michael


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ipv6.7: SOL_IPV6 and other SOL_* options socket are not portable

[Stéphane Aulery]

Hi Michael,

Le lundi 23 mars 2015 à 07:17:57, Michael Kerrisk (man-pages) a écrit :
> Hi Stéphane,
> 
> On 03/09/2015 02:04 PM, Stéphane Aulery wrote:
> > Fix for Debian bug #472447 reported by David Madore <david.madore@ens.fr>
> > 
> > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=472447
> > Signed-off-by: Stéphane Aulery <saulery-GANU6spQydw@public.gmane.org>
> 
> Applied, but some comments below.
> 
> Take a look also at commit 8013e4ef703e3d1199dfb628e6fe1e0fd290ca49
> to see how you could tweak your commit messages to better fit with
> my normal layout.

Is the field "Reported-by:" an option of git format-patch ?

Regards,

-- 
Stéphane Aulery
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ipv6.7: SOL_IPV6 and other SOL_* options socket are not portable

[Michael Kerrisk (man-pages)]

On 23 March 2015 at 08:58, Stéphane Aulery <saulery-GANU6spQydw@public.gmane.org> wrote:
> Hi Michael,
>
> Le lundi 23 mars 2015 à 07:17:57, Michael Kerrisk (man-pages) a écrit :
>> Hi Stéphane,
>>
>> On 03/09/2015 02:04 PM, Stéphane Aulery wrote:
>> > Fix for Debian bug #472447 reported by David Madore <david.madore@ens.fr>
>> >
>> > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=472447
>> > Signed-off-by: Stéphane Aulery <saulery-GANU6spQydw@public.gmane.org>
>>
>> Applied, but some comments below.
>>
>> Take a look also at commit 8013e4ef703e3d1199dfb628e6fe1e0fd290ca49
>> to see how you could tweak your commit messages to better fit with
>> my normal layout.
>
> Is the field "Reported-by:" an option of git format-patch ?

I think not. I just add it manually.

Cheers,

Michael


> Stéphane Aulery



-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html