linux-man.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] getutent.3: ATTRIBUTES: Note functions those aren't thread-safe
@ 2015-03-25  3:15 Zeng Linggang
       [not found] ` <1427253330-27357-1-git-send-email-zenglg.jy-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
  0 siblings, 1 reply; 11+ messages in thread
From: Zeng Linggang @ 2015-03-25  3:15 UTC (permalink / raw)
  To: mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w; +Cc: linux-man-u79uwXL29TY76Z2rM5mHXA

The markings match glibc markings.

Signed-off-by: Zeng Linggang <zenglg.jy-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
---
 man3/getutent.3 | 40 ++++++++++++++++++++++++++++++++++++++++
 1 file changed, 40 insertions(+)

diff --git a/man3/getutent.3 b/man3/getutent.3
index 4ff5581..3365382 100644
--- a/man3/getutent.3
+++ b/man3/getutent.3
@@ -155,6 +155,46 @@ functions can also fail for the reasons described in
 /var/run/utmp	database of currently logged-in users
 .br
 /var/log/wtmp	database of past user logins
+.SH ATTRIBUTES
+For an explanation of the terms used in this section, see
+.BR attributes (7).
+.TS
+allbox;
+lb lb lbw28
+l l l.
+Interface	Attribute	Value
+T{
+.BR getutent ()
+T}	Thread safety	T{
+MT-Unsafe init race:utent
+.br
+race:utentbuf sig:ALRM timer
+T}
+T{
+.BR getutid (),
+.br
+.BR getutline ()
+T}	Thread safety	T{
+MT-Unsafe init race:utent
+.br
+sig:ALRM timer
+T}
+T{
+.BR pututline ()
+T}	Thread safety	T{
+MT-Unsafe race:utent
+.br
+sig:ALRM timer
+T}
+T{
+.BR setutent (),
+.br
+.BR endutent (),
+.br
+.BR utmpname ()
+T}	Thread safety	MT-Unsafe race:utent
+.TE
+
 .SH CONFORMING TO
 XPG2, SVr4.
 .LP
-- 
1.9.3

--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [PATCH v2] perror.3: ATTRIBUTES: Note function that is thread-safe
       [not found] ` <1427253330-27357-1-git-send-email-zenglg.jy-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
@ 2015-03-25  3:15   ` Zeng Linggang
  2015-03-25  3:15   ` [PATCH v2] printf.3: ATTRIBUTES: Note functions those are thread-safe Zeng Linggang
                     ` (5 subsequent siblings)
  6 siblings, 0 replies; 11+ messages in thread
From: Zeng Linggang @ 2015-03-25  3:15 UTC (permalink / raw)
  To: mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w; +Cc: linux-man-u79uwXL29TY76Z2rM5mHXA

The marking matches glibc marking.

Signed-off-by: Zeng Linggang <zenglg.jy-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
---
 man3/perror.3 | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/man3/perror.3 b/man3/perror.3
index 20f2209..2d67edc 100644
--- a/man3/perror.3
+++ b/man3/perror.3
@@ -108,6 +108,19 @@ Thus, if a failing call is not immediately followed by a call to
 the value of
 .I errno
 should be saved.
+.SH ATTRIBUTES
+For an explanation of the terms used in this section, see
+.BR attributes (7).
+.TS
+allbox;
+lb lb lb
+l l l.
+Interface	Attribute	Value
+T{
+.BR perror ()
+T}	Thread safety	MT-Safe race:stderr
+.TE
+
 .SH CONFORMING TO
 The function
 .BR perror ()
-- 
1.9.3

--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [PATCH v2] printf.3: ATTRIBUTES: Note functions those are thread-safe
       [not found] ` <1427253330-27357-1-git-send-email-zenglg.jy-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
  2015-03-25  3:15   ` [PATCH v2] perror.3: ATTRIBUTES: Note function that is thread-safe Zeng Linggang
@ 2015-03-25  3:15   ` Zeng Linggang
  2015-03-25  3:15   ` [PATCH v2] scandir.3: " Zeng Linggang
                     ` (4 subsequent siblings)
  6 siblings, 0 replies; 11+ messages in thread
From: Zeng Linggang @ 2015-03-25  3:15 UTC (permalink / raw)
  To: mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w; +Cc: linux-man-u79uwXL29TY76Z2rM5mHXA

The markings match glibc markings.

Signed-off-by: Zeng Linggang <zenglg.jy-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
---
 man3/printf.3 | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/man3/printf.3 b/man3/printf.3
index bf84f07..fc1b1a0 100644
--- a/man3/printf.3
+++ b/man3/printf.3
@@ -822,6 +822,29 @@ A \(aq%\(aq is written.
 No argument is converted.
 The complete conversion
 specification is \(aq%%\(aq.
+.SH ATTRIBUTES
+For an explanation of the terms used in this section, see
+.BR attributes (7).
+.TS
+allbox;
+lbw23 lb lb
+l l l.
+Interface	Attribute	Value
+T{
+.BR printf (),
+.BR fprintf (),
+.br
+.BR sprintf (),
+.BR snprintf (),
+.br
+.BR vprintf (),
+.BR vfprintf (),
+.br
+.BR vsprintf (),
+.BR vsnprintf ()
+T}	Thread safety	MT-Safe locale
+.TE
+
 .SH CONFORMING TO
 The
 .BR fprintf (),
-- 
1.9.3

--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [PATCH v2] scandir.3: ATTRIBUTES: Note functions those are thread-safe
       [not found] ` <1427253330-27357-1-git-send-email-zenglg.jy-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
  2015-03-25  3:15   ` [PATCH v2] perror.3: ATTRIBUTES: Note function that is thread-safe Zeng Linggang
  2015-03-25  3:15   ` [PATCH v2] printf.3: ATTRIBUTES: Note functions those are thread-safe Zeng Linggang
@ 2015-03-25  3:15   ` Zeng Linggang
  2015-03-25  3:15   ` [PATCH v2] scanf.3: " Zeng Linggang
                     ` (3 subsequent siblings)
  6 siblings, 0 replies; 11+ messages in thread
From: Zeng Linggang @ 2015-03-25  3:15 UTC (permalink / raw)
  To: mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w; +Cc: linux-man-u79uwXL29TY76Z2rM5mHXA

The markings match glibc markings.

Signed-off-by: Zeng Linggang <zenglg.jy-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
---
 man3/scandir.3 | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/man3/scandir.3 b/man3/scandir.3
index 6322c2e..640a275 100644
--- a/man3/scandir.3
+++ b/man3/scandir.3
@@ -226,6 +226,24 @@ was added to glibc in version 2.1.
 
 .BR scandirat ()
 was added to glibc in version 2.15.
+.SH ATTRIBUTES
+For an explanation of the terms used in this section, see
+.BR attributes (7).
+.TS
+allbox;
+lbw26 lb lb
+l l l.
+Interface	Attribute	Value
+T{
+.BR scandir (),
+.BR scandirat ()
+T}	Thread safety	MT-Safe
+T{
+.BR alphasort (),
+.BR versionsort ()
+T}	Thread safety	MT-Safe locale
+.TE
+
 .SH CONFORMING TO
 .BR alphasort (),
 .BR scandir ():
-- 
1.9.3

--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [PATCH v2] scanf.3: ATTRIBUTES: Note functions those are thread-safe
       [not found] ` <1427253330-27357-1-git-send-email-zenglg.jy-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
                     ` (2 preceding siblings ...)
  2015-03-25  3:15   ` [PATCH v2] scandir.3: " Zeng Linggang
@ 2015-03-25  3:15   ` Zeng Linggang
  2015-03-25  3:15   ` [PATCH v2] wprintf.3: " Zeng Linggang
                     ` (2 subsequent siblings)
  6 siblings, 0 replies; 11+ messages in thread
From: Zeng Linggang @ 2015-03-25  3:15 UTC (permalink / raw)
  To: mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w; +Cc: linux-man-u79uwXL29TY76Z2rM5mHXA

The markings match glibc markings.

Signed-off-by: Zeng Linggang <zenglg.jy-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
---
 man3/scanf.3 | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/man3/scanf.3 b/man3/scanf.3
index 02455b4..6018694 100644
--- a/man3/scanf.3
+++ b/man3/scanf.3
@@ -574,6 +574,26 @@ Out of memory.
 .B ERANGE
 The result of an integer conversion would exceed the size
 that can be stored in the corresponding integer type.
+.SH ATTRIBUTES
+For an explanation of the terms used in this section, see
+.BR attributes (7).
+.TS
+allbox;
+lbw20 lb lb
+l l l.
+Interface	Attribute	Value
+T{
+.BR scanf (),
+.BR fscanf (),
+.br
+.BR sscanf (),
+.BR vscanf (),
+.br
+.BR vsscanf (),
+.BR vfscanf ()
+T}	Thread safety	MT-Safe locale
+.TE
+
 .SH CONFORMING TO
 The functions
 .BR fscanf (),
-- 
1.9.3

--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [PATCH v2] wprintf.3: ATTRIBUTES: Note functions those are thread-safe
       [not found] ` <1427253330-27357-1-git-send-email-zenglg.jy-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
                     ` (3 preceding siblings ...)
  2015-03-25  3:15   ` [PATCH v2] scanf.3: " Zeng Linggang
@ 2015-03-25  3:15   ` Zeng Linggang
  2015-04-01  9:01   ` [PATCH v3] getutent.3: ATTRIBUTES: Note functions those aren't thread-safe Zeng Linggang
  2015-04-08  3:07   ` [PATCH v2] getutent.3: ATTRIBUTES: Note functions those aren't thread-safe Zeng Linggang
  6 siblings, 0 replies; 11+ messages in thread
From: Zeng Linggang @ 2015-03-25  3:15 UTC (permalink / raw)
  To: mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w; +Cc: linux-man-u79uwXL29TY76Z2rM5mHXA

The markings match glibc markings.

Signed-off-by: Zeng Linggang <zenglg.jy-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
---
 man3/wprintf.3 | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/man3/wprintf.3 b/man3/wprintf.3
index 57d1cf4..219560d 100644
--- a/man3/wprintf.3
+++ b/man3/wprintf.3
@@ -208,6 +208,26 @@ case of the functions
 and
 .BR vswprintf ().
 They return \-1 when an error occurs.
+.SH ATTRIBUTES
+For an explanation of the terms used in this section, see
+.BR attributes (7).
+.TS
+allbox;
+lbw24 lb lb
+l l l.
+Interface	Attribute	Value
+T{
+.BR wprintf (),
+.BR fwprintf (),
+.br
+.BR swprintf (),
+.BR vwprintf (),
+.br
+.BR vfwprintf (),
+.BR vswprintf ()
+T}	Thread safety	MT-Safe locale
+.TE
+
 .SH CONFORMING TO
 C99.
 .SH NOTES
-- 
1.9.3

--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [PATCH v3] getutent.3: ATTRIBUTES: Note functions those aren't thread-safe
       [not found] ` <1427253330-27357-1-git-send-email-zenglg.jy-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
                     ` (4 preceding siblings ...)
  2015-03-25  3:15   ` [PATCH v2] wprintf.3: " Zeng Linggang
@ 2015-04-01  9:01   ` Zeng Linggang
       [not found]     ` <1427878863-17821-1-git-send-email-zenglg.jy-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
  2015-04-08  3:07   ` [PATCH v2] getutent.3: ATTRIBUTES: Note functions those aren't thread-safe Zeng Linggang
  6 siblings, 1 reply; 11+ messages in thread
From: Zeng Linggang @ 2015-04-01  9:01 UTC (permalink / raw)
  To: mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w; +Cc: linux-man-u79uwXL29TY76Z2rM5mHXA

The markings match glibc markings.

Signed-off-by: Zeng Linggang <zenglg.jy-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
Signed-off-by: Ma Shimiao <mashimiao.fnst-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
---
 man3/getutent.3 | 55 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 55 insertions(+)

diff --git a/man3/getutent.3 b/man3/getutent.3
index 4ff5581..1611d9b 100644
--- a/man3/getutent.3
+++ b/man3/getutent.3
@@ -155,6 +155,61 @@ functions can also fail for the reasons described in
 /var/run/utmp	database of currently logged-in users
 .br
 /var/log/wtmp	database of past user logins
+.SH ATTRIBUTES
+For an explanation of the terms used in this section, see
+.BR attributes (7).
+.TS
+allbox;
+lb lb lbw28
+l l l.
+Interface	Attribute	Value
+T{
+.BR getutent ()
+T}	Thread safety	T{
+MT-Unsafe init race:utent
+.br
+race:utentbuf sig:ALRM timer
+T}
+T{
+.BR getutid (),
+.br
+.BR getutline ()
+T}	Thread safety	T{
+MT-Unsafe init race:utent
+.br
+sig:ALRM timer
+T}
+T{
+.BR pututline ()
+T}	Thread safety	T{
+MT-Unsafe race:utent
+.br
+sig:ALRM timer
+T}
+T{
+.BR setutent (),
+.br
+.BR endutent (),
+.br
+.BR utmpname ()
+T}	Thread safety	MT-Unsafe race:utent
+.TE
+
+In the above table,
+.I utent
+in
+.I race:utent
+signifies that if any of the functions
+.BR setutent (3),
+.BR getutent (3),
+.BR getutid (3),
+.BR getutline (3),
+.BR pututline (3),
+.BR utmpname (3),
+or
+.BR endutent (3)
+are used in parallel in different threads of a program,
+then data races could occur.
 .SH CONFORMING TO
 XPG2, SVr4.
 .LP
-- 
1.9.3

--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 11+ messages in thread

* ATTRIBUTES patch problems!
       [not found]     ` <1427878863-17821-1-git-send-email-zenglg.jy-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
@ 2015-04-04  8:35       ` Michael Kerrisk (man-pages)
       [not found]         ` <551FA25F.9020804-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
  0 siblings, 1 reply; 11+ messages in thread
From: Michael Kerrisk (man-pages) @ 2015-04-04  8:35 UTC (permalink / raw)
  To: Zeng Linggang
  Cc: mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w,
	linux-man-u79uwXL29TY76Z2rM5mHXA, Ma Shimiao

[Was: Re: [PATCH v3] getutent.3: ATTRIBUTES: Note functions those 
aren't thread-safe]

On 04/01/2015 10:01 AM, Zeng Linggang wrote:
> The markings match glibc markings.

Hello Zeng Linggang and Ma Shimiao,

Arrgghhh! What is going on?

I started processing this queue of patches from Zeng Linggang, 
and now I see there are v2 and even now a v3 patch for some 
of the pages! With no explanation of the differences in 
one version of the patches from one version to the next...
And all of the different versions of the patches with a 
statement that the markings match the glibc markings...
That can't be true, because the different versions of the 
man-pages patches have different markings! (At least in the 
cases that I looked at.) Please explain.

And, all of the v1 patches are signed off by Ma Shimiao, implying
some degree of review by Ma Shimiao. Is this true? If so, why
do I get two or even three versions of the patches? Please 
explain.

I'm not happy about this. And I'd rather you could explain what's 
happening, and fix the problem. I'm sorry, but Zeng Linggang,
I have just reverted all the patches that I just applied from you,
and I've deleted the remaining v2 and v3 patches from you. Could you
get together with Ma Shimiao and send me new correct versions 
of these patches. And please, Ma Shimiao, if your name goes
into the Signed-off-by, I take this as some indication that you
checked the patches. If that's not the case, I should not see a 
Signed-off-by.

For the future, could you both, when sending patches, please 
in the commit message also quote the text of the glibc markings
so I can compare. (Just quoting the source text is fine.)

Thanks,

Michael



> Signed-off-by: Zeng Linggang <zenglg.jy-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
> Signed-off-by: Ma Shimiao <mashimiao.fnst-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
> ---
>  man3/getutent.3 | 55 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 55 insertions(+)
> 
> diff --git a/man3/getutent.3 b/man3/getutent.3
> index 4ff5581..1611d9b 100644
> --- a/man3/getutent.3
> +++ b/man3/getutent.3
> @@ -155,6 +155,61 @@ functions can also fail for the reasons described in
>  /var/run/utmp	database of currently logged-in users
>  .br
>  /var/log/wtmp	database of past user logins
> +.SH ATTRIBUTES
> +For an explanation of the terms used in this section, see
> +.BR attributes (7).
> +.TS
> +allbox;
> +lb lb lbw28
> +l l l.
> +Interface	Attribute	Value
> +T{
> +.BR getutent ()
> +T}	Thread safety	T{
> +MT-Unsafe init race:utent
> +.br
> +race:utentbuf sig:ALRM timer
> +T}
> +T{
> +.BR getutid (),
> +.br
> +.BR getutline ()
> +T}	Thread safety	T{
> +MT-Unsafe init race:utent
> +.br
> +sig:ALRM timer
> +T}
> +T{
> +.BR pututline ()
> +T}	Thread safety	T{
> +MT-Unsafe race:utent
> +.br
> +sig:ALRM timer
> +T}
> +T{
> +.BR setutent (),
> +.br
> +.BR endutent (),
> +.br
> +.BR utmpname ()
> +T}	Thread safety	MT-Unsafe race:utent
> +.TE
> +
> +In the above table,
> +.I utent
> +in
> +.I race:utent
> +signifies that if any of the functions
> +.BR setutent (3),
> +.BR getutent (3),
> +.BR getutid (3),
> +.BR getutline (3),
> +.BR pututline (3),
> +.BR utmpname (3),
> +or
> +.BR endutent (3)
> +are used in parallel in different threads of a program,
> +then data races could occur.
>  .SH CONFORMING TO
>  XPG2, SVr4.
>  .LP
> 


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: ATTRIBUTES patch problems!
       [not found]         ` <551FA25F.9020804-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
@ 2015-04-07  4:29           ` Zeng Linggang
       [not found]             ` <1428380951.6749.60.camel-HPT4HQ9wKwaGsR6CxgJlS1Kr0EmMEXJSn9A1Ff6Mc9Q@public.gmane.org>
  0 siblings, 1 reply; 11+ messages in thread
From: Zeng Linggang @ 2015-04-07  4:29 UTC (permalink / raw)
  To: Michael Kerrisk (man-pages); +Cc: linux-man-u79uwXL29TY76Z2rM5mHXA, Ma Shimiao

Hello, Mr Michael!

On Sat, 2015-04-04 at 09:35 +0100, Michael Kerrisk (man-pages) wrote:
> [Was: Re: [PATCH v3] getutent.3: ATTRIBUTES: Note functions those 
> aren't thread-safe]
> 
> On 04/01/2015 10:01 AM, Zeng Linggang wrote:
> > The markings match glibc markings.
> 
> Hello Zeng Linggang and Ma Shimiao,
> 
> Arrgghhh! What is going on?
> 

We are so sorry to bring you so much trouble.

> I started processing this queue of patches from Zeng Linggang, 
> and now I see there are v2 and even now a v3 patch for some 
> of the pages! With no explanation of the differences in 
> one version of the patches from one version to the next...
> And all of the different versions of the patches with a 
> statement that the markings match the glibc markings...
> That can't be true, because the different versions of the 
> man-pages patches have different markings! (At least in the 
> cases that I looked at.) Please explain.
> 

Hmm, we have checked the different version carefully, we did not change
the markings. We just found some blemish in V1('lb' --> 'lbw[x]' and in
the third column some markings are too long we added '.br'). In V3 we
just added explanation for "race:utent". So sorry for no adding any
statements for the changes. If you find the different markings, we are
glad to be noticed.

> And, all of the v1 patches are signed off by Ma Shimiao, implying
> some degree of review by Ma Shimiao. Is this true? If so, why
> do I get two or even three versions of the patches? Please 
> explain.
> 
> I'm not happy about this. And I'd rather you could explain what's 
> happening, and fix the problem. I'm sorry, but Zeng Linggang,
> I have just reverted all the patches that I just applied from you,
> and I've deleted the remaining v2 and v3 patches from you. Could you
> get together with Ma Shimiao and send me new correct versions 
> of these patches. And please, Ma Shimiao, if your name goes
> into the Signed-off-by, I take this as some indication that you
> checked the patches. If that's not the case, I should not see a 
> Signed-off-by.
> 
> For the future, could you both, when sending patches, please 
> in the commit message also quote the text of the glibc markings
> so I can compare. (Just quoting the source text is fine.)
> 

OK. We will send new patches with the glibc markings ASAP.

Thank you very much.

Best regards,
Zeng

> Thanks,
> 
> Michael
> 
> 
> 
> > Signed-off-by: Zeng Linggang <zenglg.jy-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
> > Signed-off-by: Ma Shimiao <mashimiao.fnst-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
> > ---
> >  man3/getutent.3 | 55 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
> >  1 file changed, 55 insertions(+)
> > 
> > diff --git a/man3/getutent.3 b/man3/getutent.3
> > index 4ff5581..1611d9b 100644
> > --- a/man3/getutent.3
> > +++ b/man3/getutent.3
> > @@ -155,6 +155,61 @@ functions can also fail for the reasons described in
> >  /var/run/utmp	database of currently logged-in users
> >  .br
> >  /var/log/wtmp	database of past user logins
> > +.SH ATTRIBUTES
> > +For an explanation of the terms used in this section, see
> > +.BR attributes (7).
> > +.TS
> > +allbox;
> > +lb lb lbw28
> > +l l l.
> > +Interface	Attribute	Value
> > +T{
> > +.BR getutent ()
> > +T}	Thread safety	T{
> > +MT-Unsafe init race:utent
> > +.br
> > +race:utentbuf sig:ALRM timer
> > +T}
> > +T{
> > +.BR getutid (),
> > +.br
> > +.BR getutline ()
> > +T}	Thread safety	T{
> > +MT-Unsafe init race:utent
> > +.br
> > +sig:ALRM timer
> > +T}
> > +T{
> > +.BR pututline ()
> > +T}	Thread safety	T{
> > +MT-Unsafe race:utent
> > +.br
> > +sig:ALRM timer
> > +T}
> > +T{
> > +.BR setutent (),
> > +.br
> > +.BR endutent (),
> > +.br
> > +.BR utmpname ()
> > +T}	Thread safety	MT-Unsafe race:utent
> > +.TE
> > +
> > +In the above table,
> > +.I utent
> > +in
> > +.I race:utent
> > +signifies that if any of the functions
> > +.BR setutent (3),
> > +.BR getutent (3),
> > +.BR getutid (3),
> > +.BR getutline (3),
> > +.BR pututline (3),
> > +.BR utmpname (3),
> > +or
> > +.BR endutent (3)
> > +are used in parallel in different threads of a program,
> > +then data races could occur.
> >  .SH CONFORMING TO
> >  XPG2, SVr4.
> >  .LP
> > 
> 
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH v2] getutent.3: ATTRIBUTES: Note functions those aren't thread-safe
       [not found] ` <1427253330-27357-1-git-send-email-zenglg.jy-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
                     ` (5 preceding siblings ...)
  2015-04-01  9:01   ` [PATCH v3] getutent.3: ATTRIBUTES: Note functions those aren't thread-safe Zeng Linggang
@ 2015-04-08  3:07   ` Zeng Linggang
  6 siblings, 0 replies; 11+ messages in thread
From: Zeng Linggang @ 2015-04-08  3:07 UTC (permalink / raw)
  To: mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w; +Cc: linux-man-u79uwXL29TY76Z2rM5mHXA

Hi,

Sorry for the bother. Please *ignore* these patches. I have sent new
correct versions just a moment ago.

Best regards,
Zeng

On Wed, 2015-03-25 at 11:15 +0800, Zeng Linggang wrote:
> The markings match glibc markings.
> 
> Signed-off-by: Zeng Linggang <zenglg.jy-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
> ---
>  man3/getutent.3 | 40 ++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 40 insertions(+)
> 
> diff --git a/man3/getutent.3 b/man3/getutent.3
> index 4ff5581..3365382 100644
> --- a/man3/getutent.3
> +++ b/man3/getutent.3
> @@ -155,6 +155,46 @@ functions can also fail for the reasons described in
>  /var/run/utmp	database of currently logged-in users
>  .br
>  /var/log/wtmp	database of past user logins
> +.SH ATTRIBUTES
> +For an explanation of the terms used in this section, see
> +.BR attributes (7).
> +.TS
> +allbox;
> +lb lb lbw28
> +l l l.
> +Interface	Attribute	Value
> +T{
> +.BR getutent ()
> +T}	Thread safety	T{
> +MT-Unsafe init race:utent
> +.br
> +race:utentbuf sig:ALRM timer
> +T}
> +T{
> +.BR getutid (),
> +.br
> +.BR getutline ()
> +T}	Thread safety	T{
> +MT-Unsafe init race:utent
> +.br
> +sig:ALRM timer
> +T}
> +T{
> +.BR pututline ()
> +T}	Thread safety	T{
> +MT-Unsafe race:utent
> +.br
> +sig:ALRM timer
> +T}
> +T{
> +.BR setutent (),
> +.br
> +.BR endutent (),
> +.br
> +.BR utmpname ()
> +T}	Thread safety	MT-Unsafe race:utent
> +.TE
> +
>  .SH CONFORMING TO
>  XPG2, SVr4.
>  .LP


--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: ATTRIBUTES patch problems!
       [not found]             ` <1428380951.6749.60.camel-HPT4HQ9wKwaGsR6CxgJlS1Kr0EmMEXJSn9A1Ff6Mc9Q@public.gmane.org>
@ 2015-04-11  6:35               ` Michael Kerrisk (man-pages)
  0 siblings, 0 replies; 11+ messages in thread
From: Michael Kerrisk (man-pages) @ 2015-04-11  6:35 UTC (permalink / raw)
  To: Zeng Linggang
  Cc: mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w,
	linux-man-u79uwXL29TY76Z2rM5mHXA, Ma Shimiao

On 04/07/2015 06:29 AM, Zeng Linggang wrote:
> Hello, Mr Michael!
> 
> On Sat, 2015-04-04 at 09:35 +0100, Michael Kerrisk (man-pages) wrote:
>> [Was: Re: [PATCH v3] getutent.3: ATTRIBUTES: Note functions those 
>> aren't thread-safe]
>>
>> On 04/01/2015 10:01 AM, Zeng Linggang wrote:
>>> The markings match glibc markings.
>>
>> Hello Zeng Linggang and Ma Shimiao,
>>
>> Arrgghhh! What is going on?
>>
> 
> We are so sorry to bring you so much trouble.
> 
>> I started processing this queue of patches from Zeng Linggang, 
>> and now I see there are v2 and even now a v3 patch for some 
>> of the pages! With no explanation of the differences in 
>> one version of the patches from one version to the next...
>> And all of the different versions of the patches with a 
>> statement that the markings match the glibc markings...
>> That can't be true, because the different versions of the 
>> man-pages patches have different markings! (At least in the 
>> cases that I looked at.) Please explain.
>>
> 
> Hmm, we have checked the different version carefully, we did not change
> the markings. We just found some blemish in V1('lb' --> 'lbw[x]' and in
> the third column some markings are too long we added '.br'). In V3 we
> just added explanation for "race:utent". So sorry for no adding any
> statements for the changes. If you find the different markings, we are
> glad to be noticed.

Okay -- thanks.

>> And, all of the v1 patches are signed off by Ma Shimiao, implying
>> some degree of review by Ma Shimiao. Is this true? If so, why
>> do I get two or even three versions of the patches? Please 
>> explain.
>>
>> I'm not happy about this. And I'd rather you could explain what's 
>> happening, and fix the problem. I'm sorry, but Zeng Linggang,
>> I have just reverted all the patches that I just applied from you,
>> and I've deleted the remaining v2 and v3 patches from you. Could you
>> get together with Ma Shimiao and send me new correct versions 
>> of these patches. And please, Ma Shimiao, if your name goes
>> into the Signed-off-by, I take this as some indication that you
>> checked the patches. If that's not the case, I should not see a 
>> Signed-off-by.
>>
>> For the future, could you both, when sending patches, please 
>> in the commit message also quote the text of the glibc markings
>> so I can compare. (Just quoting the source text is fine.)
>>
> 
> OK. We will send new patches with the glibc markings ASAP.

Thanks, Zeng.

Cheers,

Michael


> Zeng
> 
>> Thanks,
>>
>> Michael
>>
>>
>>
>>> Signed-off-by: Zeng Linggang <zenglg.jy-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
>>> Signed-off-by: Ma Shimiao <mashimiao.fnst-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
>>> ---
>>>  man3/getutent.3 | 55 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
>>>  1 file changed, 55 insertions(+)
>>>
>>> diff --git a/man3/getutent.3 b/man3/getutent.3
>>> index 4ff5581..1611d9b 100644
>>> --- a/man3/getutent.3
>>> +++ b/man3/getutent.3
>>> @@ -155,6 +155,61 @@ functions can also fail for the reasons described in
>>>  /var/run/utmp	database of currently logged-in users
>>>  .br
>>>  /var/log/wtmp	database of past user logins
>>> +.SH ATTRIBUTES
>>> +For an explanation of the terms used in this section, see
>>> +.BR attributes (7).
>>> +.TS
>>> +allbox;
>>> +lb lb lbw28
>>> +l l l.
>>> +Interface	Attribute	Value
>>> +T{
>>> +.BR getutent ()
>>> +T}	Thread safety	T{
>>> +MT-Unsafe init race:utent
>>> +.br
>>> +race:utentbuf sig:ALRM timer
>>> +T}
>>> +T{
>>> +.BR getutid (),
>>> +.br
>>> +.BR getutline ()
>>> +T}	Thread safety	T{
>>> +MT-Unsafe init race:utent
>>> +.br
>>> +sig:ALRM timer
>>> +T}
>>> +T{
>>> +.BR pututline ()
>>> +T}	Thread safety	T{
>>> +MT-Unsafe race:utent
>>> +.br
>>> +sig:ALRM timer
>>> +T}
>>> +T{
>>> +.BR setutent (),
>>> +.br
>>> +.BR endutent (),
>>> +.br
>>> +.BR utmpname ()
>>> +T}	Thread safety	MT-Unsafe race:utent
>>> +.TE
>>> +
>>> +In the above table,
>>> +.I utent
>>> +in
>>> +.I race:utent
>>> +signifies that if any of the functions
>>> +.BR setutent (3),
>>> +.BR getutent (3),
>>> +.BR getutid (3),
>>> +.BR getutline (3),
>>> +.BR pututline (3),
>>> +.BR utmpname (3),
>>> +or
>>> +.BR endutent (3)
>>> +are used in parallel in different threads of a program,
>>> +then data races could occur.
>>>  .SH CONFORMING TO
>>>  XPG2, SVr4.
>>>  .LP
>>>
>>
>>
> 
> 
> 


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2015-04-11  6:35 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-25  3:15 [PATCH v2] getutent.3: ATTRIBUTES: Note functions those aren't thread-safe Zeng Linggang
     [not found] ` <1427253330-27357-1-git-send-email-zenglg.jy-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2015-03-25  3:15   ` [PATCH v2] perror.3: ATTRIBUTES: Note function that is thread-safe Zeng Linggang
2015-03-25  3:15   ` [PATCH v2] printf.3: ATTRIBUTES: Note functions those are thread-safe Zeng Linggang
2015-03-25  3:15   ` [PATCH v2] scandir.3: " Zeng Linggang
2015-03-25  3:15   ` [PATCH v2] scanf.3: " Zeng Linggang
2015-03-25  3:15   ` [PATCH v2] wprintf.3: " Zeng Linggang
2015-04-01  9:01   ` [PATCH v3] getutent.3: ATTRIBUTES: Note functions those aren't thread-safe Zeng Linggang
     [not found]     ` <1427878863-17821-1-git-send-email-zenglg.jy-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2015-04-04  8:35       ` ATTRIBUTES patch problems! Michael Kerrisk (man-pages)
     [not found]         ` <551FA25F.9020804-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-04-07  4:29           ` Zeng Linggang
     [not found]             ` <1428380951.6749.60.camel-HPT4HQ9wKwaGsR6CxgJlS1Kr0EmMEXJSn9A1Ff6Mc9Q@public.gmane.org>
2015-04-11  6:35               ` Michael Kerrisk (man-pages)
2015-04-08  3:07   ` [PATCH v2] getutent.3: ATTRIBUTES: Note functions those aren't thread-safe Zeng Linggang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).