From: Alejandro Colomar <alx.manpages@gmail.com>
To: Shawn Webb <shawn.webb@hardenedbsd.org>,
oss-security@lists.openwall.com,
John Helmert III <ajak@gentoo.org>,
Demi Marie Obenour <demi@invisiblethingslab.com>,
Jan Engelhardt <jengelh@inai.de>,
"Lyndon Nerenberg (VE7TFX/VE6BBM)" <lyndon@orthanc.ca>
Cc: Michael Kerrisk <mtk.manpages@gmail.com>,
linux-kernel@vger.kernel.org, linux-man@vger.kernel.org
Subject: Re: [oss-security] [patch] proc.5: tell how to parse /proc/*/stat correctly
Date: Wed, 28 Dec 2022 20:57:04 +0100 [thread overview]
Message-ID: <551c6d28-2b4e-ce4e-7602-29afe014d725@gmail.com> (raw)
In-Reply-To: <20221228192436.viuoyil2ntr4lxjo@mutt-hbsd>
[-- Attachment #1.1: Type: text/plain, Size: 2760 bytes --]
Hi all,
On 12/28/22 20:24, Shawn Webb wrote:
> On Wed, Dec 28, 2022 at 01:02:35PM -0500, Demi Marie Obenour wrote:
>> On Wed, Dec 28, 2022 at 12:25:17PM -0500, Shawn Webb wrote:
>>> On Wed, Dec 28, 2022 at 11:47:25AM -0500, Demi Marie Obenour wrote:
>>>> On Wed, Dec 28, 2022 at 10:24:58AM -0500, Shawn Webb wrote:
>>>>> On Tue, Dec 27, 2022 at 04:44:49PM -0800, Lyndon Nerenberg (VE7TFX/VE6BBM) wrote:
>>>>>> Dominique Martinet writes:
>>>>>>
>>>>>>> But, really, I just don't see how this can practically be said to be parsable...
>>>>>>
>>>>>> In its current form it never will be. The solution is to place
>>>>>> this variable-length field last. Then you can "cut -d ' ' -f 51-"
>>>>>> to get the command+args part (assuming I counted all those fields
>>>>>> correctly ...)
>>>>>>
>>>>>> Of course, this breaks backwards compatability.
>>>>>
>>>>> It would also break forwards compatibility in the case new fields
>>>>> needed to be added.
>>>>>
>>>>> The only solution would be a libxo-style feature wherein a
>>>>> machine-parseable format is exposed by virtue of a file extension.
>>>>>
>>>>> Examples:
>>>>>
>>>>> 1. /proc/pid/stats.json
>>>>> 2. /proc/pid/stats.xml
>>>>> 3. /proc/pid/stats.yaml_shouldnt_be_a_thing
>>>>
>>>> A binary format would be even better. No risk of ambiguity.
>>>
>>> I think the argument I'm trying to make is to be flexible in
>>> implementation, allowing for future needs and wants--that is "future
>>> proofing".
>>
>> Linux should not have an XML, JSON, or YAML serializer. Linux already
>> does way too much; let’s not add one more thing to the list.
>
> Somewhat agreed. I think formats like JSON provide a good balance
> between machine parseable and human readable.
> a
> As I described earlier, though, when it comes to concepts like procfs
> and sysfs, I have a bias towards abandoning them in favor of sysctl.
> If sysctl nodes were to be used, no new serialization formats would
> need to be implemented--and developers would also use a safter method
> of system and process inspection and manipulation.
>
Just a comment as someone who is reading without much understanding of the
contents of /prod/pid/stat:
If organization of the data in the file is a problem, and the format starts to
matter, maybe it's a hint that there are too many different contents, and could
be split into different files, each one with its own formatting rules. I'll
suggest that maybe a set of files, maybe contained in a common directory
stats.d, is what you're looking for?
Binary format is not of my preference, since most user-space tools work with the
standard interface, that is, text.
Cheers,
Alex
--
<http://www.alejandro-colomar.es/>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-12-28 19:57 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-22 16:42 [patch] proc.5: tell how to parse /proc/*/stat correctly Alexey Dobriyan
2022-12-22 22:03 ` [oss-security] " Dominique Martinet
2022-12-22 23:21 ` Solar Designer
2022-12-23 0:15 ` Dominique Martinet
2022-12-23 0:21 ` Jan Engelhardt
2022-12-28 0:44 ` Lyndon Nerenberg (VE7TFX/VE6BBM)
2022-12-28 1:50 ` Tavis Ormandy
2022-12-30 20:15 ` Jakub Wilk
2022-12-28 15:24 ` Shawn Webb
2022-12-28 15:31 ` Shawn Webb
2022-12-28 16:47 ` Demi Marie Obenour
2022-12-28 17:09 ` Jan Engelhardt
2022-12-28 17:25 ` Shawn Webb
2022-12-28 18:02 ` Demi Marie Obenour
2022-12-28 18:36 ` John Helmert III
2022-12-28 19:24 ` Shawn Webb
2022-12-28 19:57 ` Alejandro Colomar [this message]
2022-12-28 22:14 ` Theodore Ts'o
2022-12-29 0:33 ` Demi Marie Obenour
2022-12-31 16:31 ` David Laight
2022-12-31 17:27 ` Solar Designer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=551c6d28-2b4e-ce4e-7602-29afe014d725@gmail.com \
--to=alx.manpages@gmail.com \
--cc=ajak@gentoo.org \
--cc=demi@invisiblethingslab.com \
--cc=jengelh@inai.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-man@vger.kernel.org \
--cc=lyndon@orthanc.ca \
--cc=mtk.manpages@gmail.com \
--cc=oss-security@lists.openwall.com \
--cc=shawn.webb@hardenedbsd.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox