[PATCH] fgetpwent.3: ATTRIBUTES: Note function that is not thread-safe

[PATCH] fgetpwent.3: ATTRIBUTES: Note function that is not thread-safe

[Ma Shimiao]

The marking matches glibc marking.

Signed-off-by: Ma Shimiao <mashimiao.fnst-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
---
 man3/fgetpwent.3 | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/man3/fgetpwent.3 b/man3/fgetpwent.3
index 3076494..3c4a57a 100644
--- a/man3/fgetpwent.3
+++ b/man3/fgetpwent.3
@@ -98,6 +98,18 @@ structure.
 .TP
 .I /etc/passwd
 password database file
+.SH ATTRIBUTES
+For an explanation of the terms used in this section, see
+.BR attributes (7).
+.TS
+allbox;
+lb lb lb
+l l l.
+Interface	Attribute	Value
+T{
+.BR fgetpwent ()
+T}	Thread safety	MT-Unsafe race:fpwent
+.TE
 .SH CONFORMING TO
 SVr4.
 .SH SEE ALSO
-- 
1.9.3

--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] fgetpwent.3: ATTRIBUTES: Note function that is not thread-safe

[Michael Kerrisk (man-pages)]

On 02/11/2015 08:41 AM, Ma Shimiao wrote:
> The marking matches glibc marking.

Hello Ma Shimiao,

This is just a reminder for us both that this patch is awaiting
resolution of some questions with Alexandre.

Cheers,

Michael

> Signed-off-by: Ma Shimiao <mashimiao.fnst-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
> ---
>  man3/fgetpwent.3 | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/man3/fgetpwent.3 b/man3/fgetpwent.3
> index 3076494..3c4a57a 100644
> --- a/man3/fgetpwent.3
> +++ b/man3/fgetpwent.3
> @@ -98,6 +98,18 @@ structure.
>  .TP
>  .I /etc/passwd
>  password database file
> +.SH ATTRIBUTES
> +For an explanation of the terms used in this section, see
> +.BR attributes (7).
> +.TS
> +allbox;
> +lb lb lb
> +l l l.
> +Interface	Attribute	Value
> +T{
> +.BR fgetpwent ()
> +T}	Thread safety	MT-Unsafe race:fpwent
> +.TE
>  .SH CONFORMING TO
>  SVr4.
>  .SH SEE ALSO
> 


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] fgetpwent.3: ATTRIBUTES: Note function that is not thread-safe

[Michael Kerrisk (man-pages)]

Hello Zeng Linggang,

This patch from a while ago was sent by Ma Shimiao. Since you've now
taken up the work of Ma Shimiao, I bring you into this discussion.
The patch stalled because of some terminology questions that Ma Shimiao
wanted to resolve with Alexandre (in CC), but I'm not sure if there
was any progress. (I'll thread you into that discussion as well, which
took place off list.) Maybe you can discuss with Ma Shimiao and pursue 
with Alexandre?

Cheers,

Michael


On 04/18/2015 08:26 PM, Michael Kerrisk (man-pages) wrote:
> On 02/11/2015 08:41 AM, Ma Shimiao wrote:
>> The marking matches glibc marking.
> 
> Hello Ma Shimiao,
> 
> This is just a reminder for us both that this patch is awaiting
> resolution of some questions with Alexandre.
> 
> Cheers,
> 
> Michael
> 
>> Signed-off-by: Ma Shimiao <mashimiao.fnst-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
>> ---
>>  man3/fgetpwent.3 | 12 ++++++++++++
>>  1 file changed, 12 insertions(+)
>>
>> diff --git a/man3/fgetpwent.3 b/man3/fgetpwent.3
>> index 3076494..3c4a57a 100644
>> --- a/man3/fgetpwent.3
>> +++ b/man3/fgetpwent.3
>> @@ -98,6 +98,18 @@ structure.
>>  .TP
>>  .I /etc/passwd
>>  password database file
>> +.SH ATTRIBUTES
>> +For an explanation of the terms used in this section, see
>> +.BR attributes (7).
>> +.TS
>> +allbox;
>> +lb lb lb
>> +l l l.
>> +Interface	Attribute	Value
>> +T{
>> +.BR fgetpwent ()
>> +T}	Thread safety	MT-Unsafe race:fpwent
>> +.TE
>>  .SH CONFORMING TO
>>  SVr4.
>>  .SH SEE ALSO
>>
> 
> 


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] fgetpwent.3: ATTRIBUTES: Note function that is not thread-safe

[Zeng Linggang]

The marking matches glibc marking.
marking of function in glibc is:
- fgetgrent: MT-Unsafe race:fpwent

ps: We think race:fpwent in glibc maybe hard for users to understand,
and have sent a patch to the GNU libc community for changing it to
race:fgetpwent, however, something about the copyright impeded the progress.
Here we mark it "race:fgetpwent", so there is a little different.

Signed-off-by: Zeng Linggang <zenglg.jy-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
---
 man3/fgetpwent.3 | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/man3/fgetpwent.3 b/man3/fgetpwent.3
index 3076494..84e0379 100644
--- a/man3/fgetpwent.3
+++ b/man3/fgetpwent.3
@@ -98,6 +98,22 @@ structure.
 .TP
 .I /etc/passwd
 password database file
+.TS
+allbox;
+lb lb lb
+l l l.
+Interface	Attribute	Value
+T{
+.BR fgetpwent ()
+.\" FIXME: the following marking is different from which in glibc manual,
+.\" marking in glibc manual is,
+.\" fgetpwent: MT-Unsafe race:fpwent
+.\" We think race:fpwent in glibc maybe hard for users to understand,
+.\" and have sent a patch to the GNU libc community for changing it to
+.\" race:fgetpwent, however, something about the copyright impeded the progress.
+T}	Thread safety	MT-Unsafe race:fgetpwent
+.TE
+
 .SH CONFORMING TO
 SVr4.
 .SH SEE ALSO
-- 
1.9.3

--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] fgetpwent.3: ATTRIBUTES: Note function that is not thread-safe

[Michael Kerrisk (man-pages)]

On 08/24/2015 12:19 PM, Zeng Linggang wrote:
> The marking matches glibc marking.
> marking of function in glibc is:
> - fgetgrent: MT-Unsafe race:fpwent
> 
> ps: We think race:fpwent in glibc maybe hard for users to understand,
> and have sent a patch to the GNU libc community for changing it to
> race:fgetpwent, however, something about the copyright impeded the progress.
> Here we mark it "race:fgetpwent", so there is a little different.

Applied!  Thanks, Zeng Linggang.

Cheers,

Michael

> Signed-off-by: Zeng Linggang <zenglg.jy-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
> ---
>  man3/fgetpwent.3 | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/man3/fgetpwent.3 b/man3/fgetpwent.3
> index 3076494..84e0379 100644
> --- a/man3/fgetpwent.3
> +++ b/man3/fgetpwent.3
> @@ -98,6 +98,22 @@ structure.
>  .TP
>  .I /etc/passwd
>  password database file
> +.TS
> +allbox;
> +lb lb lb
> +l l l.
> +Interface	Attribute	Value
> +T{
> +.BR fgetpwent ()
> +.\" FIXME: the following marking is different from which in glibc manual,
> +.\" marking in glibc manual is,
> +.\" fgetpwent: MT-Unsafe race:fpwent
> +.\" We think race:fpwent in glibc maybe hard for users to understand,
> +.\" and have sent a patch to the GNU libc community for changing it to
> +.\" race:fgetpwent, however, something about the copyright impeded the progress.
> +T}	Thread safety	MT-Unsafe race:fgetpwent
> +.TE
> +
>  .SH CONFORMING TO
>  SVr4.
>  .SH SEE ALSO
> 


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html